submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Samuel Young	61eb52516d	CLDC-4204: Update bulk upload fields sales (#3223 ) * CLDC-4204: Renumber fields to match spec * CLDC-4204: Update log to csv for 2026 * CLDC-4204: Cleanup BU todo commments * CLDC-4204: Replace BU example file * CLDC-4204: Update row parser question titles to match form * fixup! CLDC-4204: Update row parser question titles to match form fix sales log typo Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com> * fixup! CLDC-4204: Renumber fields to match spec update dupe fields comment Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com> * fixup! CLDC-4204: Renumber fields to match spec check the same field as before --------- Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>	2 days ago
Samuel Young	599307029d	CLDC-4215, CLDC-4216: Add mortgage used Don't Know option (#3208 ) * CLDC-4215: Show Don't Know on all paths of mortgageused * CLDC-4215: Update tests * fixup! CLDC-4215: Show Don't Know on all paths of mortgageused * fixup! CLDC-4215: Update tests cover all cases * fixup! CLDC-4215: Show Don't Know on all paths of mortgageused * fixup! CLDC-4215: Update tests	6 days ago
Nat Dean-Lewis	cd51f7c2c4	CLDC-4166: How many live in property updates (#3194 ) * CLDC-4166: question updaets * CLDC-4166: question updates * CLDC-4166: test updates * CLDC-4166: test updates * CLDC-4166: test updates * CLDC-4226: Index logs by org and ID (#3199) * CLDC-4226: index logs by org and id * CLDC-4226: include teamwide non-functional schema change * CLDC-4226: schema update * CLDC-4176: fix failing tests * CLDC-4176: renumber case insensitive fields test * CLDC-4166: update csv export spec * CLDC-4166: linting * CLDC-4166: copy updates in fixtures * CLDC-4166: copy updates in fixtures * CLDC-4166: copy updates in fixtures * CLDC-4166: var defs count update * CLDC-4166: fixtures tweak for hhtype * CLDC-4166: fixtures tweak for hhtype * CLDC-4166: fixtures tweak for hhtype * CLDC-4166: export update * CLDC-4166: whitespace linting * CLDC-4166: update number_of_others_in_property_spec.rb * CLDC-4166: update log_variable_definitions_spec.rb * CLDC-4166: update sales_log_csv_service_spec.rb * CLDC-4166: update tests * CLDC-4166: update tests	6 days ago
Samuel Young	c085cbb572	CLDC-4179: Amend sales duplicate log check (#3207 ) * CLDC-4179: Add sexrab & postcode to frontend duplicate log checks * CLDC-4179: Add sexrab & postcode to BU duplicate log checks * CLDC-4179: Update tests	6 days ago
Nat Dean-Lewis	f747034261	CLDC-4175: add new service charge question sales (#3200 ) * add the question * CLDC-4174: update question number for 2026 * CLDc-4174: update question number for 2026 * CLDc-4174: update subsection * CLDc-4174: update question specs * CLDC-4174: add subsection spec * CLDc-4174: lint * CLDc-4174: add new page test * CLDC-4241: lint * CLDC-4241: lint * CLDC-4175: db updates * CLDC-4175: add new question to ui flow * CLDC-4175: csv label for new question * CLDC-4175: row parser updates * CLDC-4175: export updates * CLDC-4174: copy updates * CLDC-4174: add validation that new value is different * CLDC-4174: parser updates * CLDC-4174: migration linting * CLDC-4174: add tests * CLDC-4174: fixture updates * CLDC-4174: linting * CLDC-4175: export and test updates * CLDC-4175: row parser field renumbering * CLDC-4175: test fixes * CLDC-4175: test and schema updates post merge * CLDC-4175: lint * CLDC-4175: lint * CLDC-4175: lint * CLDC-4175: add reverse validation * CLDC-4175: cleanup sales_log_to_csv.rb * CLDC-4226: test fixture updates * CLDC-4175: update export spec * CLDC-4175: update validation message * CLDC-4175: remove redundant range validation * CLDC-4175: test with real values in row parser * CLDC-4175: export test updates * CLDC-4175: update row parser spec and examples * CLDC-4175: update row parser spec and examples * CLDC-4175: update row parser spec and examples * CLDC-4175: update row parser spec and examples * CLDC-4175: update row parser spec and examples * CLDC-4248: respond to comments * CLDC-4175: remove newservicecharges custom call chain * CLDC-4175: include new spec requirement * CLDC-4175: update financial_validations_spec.rb --------- Co-authored-by: Samuel Young <samuel.young@softwire.com>	1 week ago
Nat Dean-Lewis	34664bde2d	CLDC-4178: Add gender same as sex question for sales (#3188 ) * CLDC-4173: add new buildheightclass db changes * CLDC-4173: add new buildheightclass page and question * CLDC-4173: add new buildheightclass bu and export updates * CLDC-4173: update tests * CLDC-4173: update var defs * CLDC-4173: add sales csv export tests for 26 including buildheightclass * CLDC-4173: add sales csv export tests for 25 and 26 including buildheightclass * CLDC-4173: update sales export spec * CLDC-4173: update sales export spec and make sales log csv service future-proof * CLDC-4178: add gender same as sex question for sales db changes * CLDC-4178: add gender same as sex question for sales questions and pages * CLDC-4178: add gender same as sex question for sales questions and pages * CLDC-4178: add gender same as sex question for sales copy * CLDC-4178: add gender same as sex question for sales person known page * CLDC-4178: add gender same as sex question for sales service updates * CLDC-4178: add gender same as sex question for sales test updates * CLDC-4140: update sales log to csv * CLDC-4140: revert typo * CLDC-4140: update factory * CLDC-4140: update factory * CLDC-4140: filename linting * CLDC-4178: update parser tests * CLDC-4178: update fixtures * CLDC-4173: add missing sales log export fixtures and tests * CLDC-4178: add missing sales log export fixtures and tests * CLDC-4178: update log var defs count * CLDC-4178: fix tests * CLDC-4237: Use each over for_each in sidekiq init (#3196) linter incorrectly assumes it is an activerecord relation * CLDC-4173: date refactoring in tests * CLDC-4173: date refactoring in tests * CLDC-4173: schema updates * CLDC-4173: cleanup and test improvements * CLDC-4173: remove deduplicated code * CLDC-4173: update dates in tests * CLDC-4178: more test date updates * CLDC-4173: test date updates * CLDC-4178: test date updates * CLDC-4178: unused copy cleanup * CLDC-4178: use shared person subsection block from CLDC-4176 * CLDC-4178: comment refactoring * CLDC-4178: person_n_present? updates * CLDC-4178: copy main csv fixtures * CLDC-4178: update csv fixtures * CLDC-4178: factory updates * CLDC-4178: export updates * CLDC-4178: refactoring for consistency with lettings * CLDC-4178: add copy key to gender same as sex * CLDC-4178: fix typo in export test * CLDC-4178: fix typo in locale copy --------- Co-authored-by: Samuel Young <samuel.young@softwire.com>	2 weeks ago
Samuel Young	8e7e9f1b71	CLDC-4167, CLDC-4168: Add don't know option to mortgage length questions (#3195 ) * CLDC-4168: Add check for mortgage length known * CLDC-4168: Add mortgage length known to question page * CLDC-4168: Make mortgage length conditional on interview requires a little changing to question logic to account for if the conditional question is not visible right now * CLDC-4168: Add R override to BU * CLDC-4168: Enforce mortlen is not R if buyer not interviewed in BU * CLDC-4168: Update tests * CLDC-4168: Add a lint task that autocorrects * CLDC-4168: Add mortgage length known to sales log factory * CLDC-4168: Allow mortgage not know if buyer wasn't interviewed previously had this the wrong way around. this makes sense because if you interviewed the buyer you should know this * CLDC-4168: Rename mortgage_length_known to mortlen_known matches the mortlen field * fixup! CLDC-4168: Add mortgage length known to question page remove old year numbers * fixup! CLDC-4168: Rename mortgage_length_known to mortlen_known * fixup! CLDC-4168: Allow mortgage not know if buyer wasn't interviewed missed test fix * CLDC-4168: Revert changes to outright_sale section * fixup! CLDC-4168: Revert changes to outright_sale section * fixup! CLDC-4168: Update tests * CLDC-4168: Allow for "r" in mortlen	2 weeks ago
Nat Dean-Lewis	9c018f8467	CLDC-4176: include new case insensitive fields in field renumbering (#3206 ) * CLDC-4176: fix failing tests * CLDC-4176: renumber case insensitive fields test	2 weeks ago
Samuel Young	3942db4000	CLDC-4176: Remove gender identity question sales (#3201 ) * CLDC-4176: Remove sexn from web UI * CLDC-4176: Remove sexn from BU replace fields with sexrabn ones * CLDC-4176: Remove sexn from CSV export * CLDC-4176: Remove sexn from XML export	2 weeks ago
Samuel Young	97e2170699	CLDC-4012: Allow lower case letters for codes in BU (#3181 ) * CLDC-4012: Add case-sensitive function for 2025 * CLDC-4012: Add case-sensitive function for 2026 * CLDC-4012: Add tests * CLDC-4012: Remove integer attributes * fixup! CLDC-4012: Add tests move R overrides for integers to their own test * fixup! CLDC-4012: Add tests don't check field 58 * fixup! CLDC-4012: Add tests Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com> --------- Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>	2 weeks ago
Nat Dean-Lewis	037f59122c	CLDC-4173: add new building height question sales (#3186 ) * CLDC-4173: add new buildheightclass db changes * CLDC-4173: add new buildheightclass page and question * CLDC-4173: add new buildheightclass bu and export updates * CLDC-4173: update tests * CLDC-4173: update var defs * CLDC-4173: add sales csv export tests for 26 including buildheightclass * CLDC-4173: add sales csv export tests for 25 and 26 including buildheightclass * CLDC-4173: update sales export spec * CLDC-4173: update sales export spec and make sales log csv service future-proof * CLDC-4173: add missing sales log export fixtures and tests * CLDC-4173: date refactoring in tests * CLDC-4173: date refactoring in tests * CLDC-4173: schema updates * CLDC-4173: test date updates	2 weeks ago
Samuel Young	d79cfcd415	CLDC-4237: Upgrade ruby version (#3190 ) * CLDC-4237: Upgrade ruby to 3.4.4 * CLDC-4237: Add additional build dependencies to Dockerfile * CLDC-4237: Update rubocop * CLDC-4237: Fix new rubocop rules most auto applies RSpec/IndexedLet had 200 hits needing manual correction so left these for now * CLDC-4237: Resolve vulnerable dependencies * CLDC-4237: Fix erb files * CLDC-4237: Downgrade connection_pool	3 weeks ago
Katherine Langford	d2fff16808	CLDC-4177: New Sex At Birth question for sales logs (#3144 ) * CLDC-4177: Create new sex-at-birth question * CLDC-4177: Update database * CLDC-4177: Adds SAB form for the primary buyer. * CLDC-4177: Adds sex-at-birth question for other household members * CLCD-4177: Unit tests * CLDC-4177: Misc inclusions where sex is also used * CLDC-4177: Lint fixes * CLDC-4177: Do not include sexRAB in pre-2026 exports * CLDC-4177: Fixes bug with copy key in new page * CLDC-4177: Changes logic used to decide which fields to export * CLDC-4177: Linting fixes * CLDC-4177: Converts new field to lowercase * CLDC-4177: Satisfy bulk upload tests (not tested manually) * CLDC-4177: Rename new fields to lowercase * CLDC-4177: Rename field in bulk upload. * Fix db casing * CLDC-4177: remove frozen string literals * Delete redundant migration * Remove extraneous lines from schema.rb * Add new sexrab fields to the :completed trait in the Sales Log factory * CLDC-4177: remove redundant inferred CYA vals * CLDC-4177: update bu files * CLDC-4177: update sales log export service * CLDC-4177: update schema * CLDC-4177: linting * CLDC-4177: update sales log export constants * CLDC-4177: update factories * CLDC-4177: lint * CLDC-4177: csv parser updates * CLDC-4177: bu field updates * CLDC-4177: update var def spec * CLDC-4177: make to_2026_row explicit * CLDC-4177: use shared field count * CLDC-4177: refactor to remove max cols going forwards * CLDC-4141: update schema * CLDC-4141: update schema * CLDC-4141: update schema * CLDC-4141: remove X from factory options * CLDC-4177: update log var defs * CLDC-4177: use correct shared field count * CLDC-4177: remove trailing commas * CLDC-4177: update bulk upload csv example * CLDC-4177: update bulk upload csv example * CLDC-4177: remove sexrab from expected sales export for now --------- Co-authored-by: oscar-richardson-softwire <oscar.richardson@softwire.com> Co-authored-by: Nat Dean-Lewis <nat.dean-lewis@softwire.com>	1 month ago
Samuel Young	a513984440	CLDC-4162: Set up Bulk Uploads for 2026 (#3134 ) * CLDC-4162: Add parsers for 2026 * CLDC-4162: Integrate 2026 parsers into codebase * CLDC-4162: Add tests * CLDC-4162: Update tests for existing years remove year dependencies where possible * CLDC-4162: Add example 2026 bulk upload files * CLDC-4162: Update BU test file generate buttons * fixup! CLDC-4162: Update BU test file generate buttons we only need the 14 days validation when the future forms feature toggle is off, otherwise any date can be input * fixup! CLDC-4162: Integrate 2026 parsers into codebase improve TODOs * fixup! CLDC-4162: Add parsers for 2026 add todos for unknown info * fixup! CLDC-4162: Update tests for existing years properly mark year specific tests * fixup! CLDC-4162: Update tests for existing years use 25 over 2025 * fixup! CLDC-4162 Update BU test file generate buttons --------- Co-authored-by: carolynbarker <8038496+carolynbarker@users.noreply.github.com>	2 months ago

14 Commits (61eb52516dbc4592a4507f0a12e1afe77b61699d)