submit-social-housing-lettings-and-sales-data

3496 Commits

243 Branches

296 Tags

84 MiB

Tree: 20f787349b

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	d89e03cc62	Cldc 1675 rent validations (#959 ) * feat: add 2022 rent range data, update rake task for population of this * feat: change file format so ranges_rent_id is recognised * feat: add updated error messages and casing * tests: make tests pass * feat: ensure there is a location_code in all locations and use this (and beds = 0) for supported housing rent validations * feat: fix general needs validation behaviour * feat: add local authorities enum to location.rb * feat: ensure case when beds > 4 is accounted for * feat: add error messages on property postcode page as well as la page * feat: add error messages on scheme_id and location_id as well as la page * feat: add error messages on scheme_id and location_id as well as la page * feat: null coalescing and validations on changing las to one that invalidates rent in supported housing * feat: nil protection * refactor: linting * refactor: combining duplicated logic * tests: add hard validation tests split by needstype * feat: update validations when beds > 4 * feat: update validations when beds > 4 * refactor: simplification, use preivous la method * refactor: response to PR comments, fixing beds.negative validation * feat: remove dynamic local auth name text from interruption screens - to be added back in later if this becomes a priority, would need some work on adding local auth name to log for supported housing logs not just leaving it in the location	3 years ago
kosiakkatrina	612b29122b	Cldc 491 rent and charges validations (#411 ) * Add rent ranges table and basic hard range validation Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com> * Add import rent ranges rake task Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com> * Update the rent range validation to validate all related fields and check for the correct collection year * Add ranges data * add error messages * Add readme step * extract get collection year method * rename method * create instead of find and create laRentRange record Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com>	4 years ago

Author

SHA1

Message

Date

natdeanlewissoftwire

d89e03cc62

Cldc 1675 rent validations (#959 )

* feat: add 2022 rent range data, update rake task for population of this

* feat: change file format so ranges_rent_id is recognised

* feat: add updated error messages and casing

* tests: make tests pass

* feat: ensure there is a location_code in all locations and use this (and beds = 0) for supported housing rent validations

* feat: fix general needs validation behaviour

* feat: add local authorities enum to location.rb

* feat: ensure case when beds > 4 is accounted for

* feat: add error messages on property postcode page as well as la page

* feat: add error messages on scheme_id and location_id as well as la page

* feat: add error messages on scheme_id and location_id as well as la page

* feat: null coalescing and validations on changing las to one that invalidates rent in supported housing

* feat: nil protection

* refactor: linting

* refactor: combining duplicated logic

* tests: add hard validation tests split by needstype

* feat: update validations when beds > 4

* feat: update validations when beds > 4

* refactor: simplification, use preivous la method

* refactor: response to PR comments, fixing beds.negative validation

* feat: remove dynamic local auth name text from interruption screens - to be added back in later if this becomes a priority, would need some work on adding local auth name to log for supported housing logs not just leaving it in the location

3 years ago

kosiakkatrina

612b29122b

Cldc 491 rent and charges validations (#411 )

* Add rent ranges table and basic hard range validation

Co-authored-by: baarkerlounger  <baarkerlounger@users.noreply.github.com>

* Add import rent ranges rake task

Co-authored-by: baarkerlounger  <baarkerlounger@users.noreply.github.com>

* Update the rent range validation to validate all related fields and check for the correct collection year

* Add ranges data

* add error messages

* Add readme step

* extract get collection year method

* rename method

* create instead of find and create laRentRange record

Co-authored-by: baarkerlounger  <baarkerlounger@users.noreply.github.com>

4 years ago

2 Commits (20f787349bda1545f158636e892cab44804fc03b)