samyou-softwire
0e378b20a0
fixup! CLDC-4325: Fix sales soft validations
2 weeks ago
samyou-softwire
e145858e57
CLDC-4325: Properly run tests on current day
2 weeks ago
samyou-softwire
123bc805d7
CLDC-4325: Run tests on 2nd april
2 weeks ago
samyou-softwire
204aa46285
CLDC-4325: Run tests on 31st march
2 weeks ago
samyou-softwire
63edaddc69
CLDC-4325: Run tests in current day
2 weeks ago
samyou-softwire
a37576031f
CLDC-4325: Make start controller spec not year specific
2 weeks ago
samyou-softwire
116120c630
fixup! CLDC-4325: Fix sales log spec in 2025
2 weeks ago
samyou-softwire
2f6d9329bd
fixup! CLDC-4325: Fix sales log spec in 2025
2 weeks ago
Samuel Young
c23c4abd8a
fixup! CLDC-4325: Fix lettings household validations spec
...
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
2 weeks ago
samyou-softwire
9d928009ec
CLDC-4325: Delete recalculate_reasonpref_dontknow rake
...
only needed for 2024 logs
2 weeks ago
samyou-softwire
14cf86b1cb
fixup! CLDC-4325: Fix check answers summary component
2 weeks ago
Samuel Young
b2ed8405a3
CLDC-4221: Add 2026 collection deadlines ( #3218 )
...
* CLDC-4221: Add 2026 collection deadlines
* CLDC-4221: Update tests
* CLDC-4221: Use form submission deadline for 4th quarter
2 weeks ago
Samuel Young
18d061143d
CLDC-4270: Fix text being coerced to 0 on integer fields ( #3230 )
...
* CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
* CLDC-4270: Add tests
* CLDC-4270: Port changes to other years' parsers
sales 2025 2026
lettings 2026
* fixup! CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
* fixup! CLDC-4270: Port changes to other years' parsers
* CLDC-4270: Fix tests post merge
* fixup! CLDC-4270: Add tests
* CLDC-4270: Add ? to boolean method
2 weeks ago
Nat Dean-Lewis
66bcfd7f16
CLDC-4302: Align buyer interviewed copy with paper form ( #3255 )
...
* CLDC-4301: copy updates
* CLDC-4302: row parser and fixture updates
* CLDC-4302: typo fix
* CLDC-4302: bu validation update
* CLDC-4302: update log var def spec
2 weeks ago
Nat Dean-Lewis
05abccd7bc
CLDC-4312: Fix broken purchase price soft validation ( #3253 )
...
* CLDC-4297: set derived for sales beds
* CLDC-4312: update tests
2 weeks ago
Samuel Young
328ea6272b
CLDC-4309: Add copy for staircasing transaction mortgage used ( #3251 )
...
* CLDC-4309: Add copy for staircasing transaction mortgage used
* CLDC-4309: Update tests
2 weeks ago
Samuel Young
319af27e75
CLDC-4215: Don't run validate_discounted_ownership_value if mortgageused is 3 ( #3239 )
...
* CLDC-4215: Don't run validate_discounted_ownership_value if mortgageused is 3
I don't think this should have ever been turned on. if we don't know the mortgage we can't assume info in this check
* CLDC-4215: Add a verifying test
2 weeks ago
Nat Dean-Lewis
9600112cda
CLDC-4318: update min for 26 onwards and test ( #3257 )
2 weeks ago
Nat Dean-Lewis
4aae303e09
CLDC-4290: filter address responses to England only ( #3256 )
...
* CLDC-4290: filter address responses to england only
* CLDC-4290: update test stubs
* CLDC-4290: update other stubbed urls
2 weeks ago
Nat Dean-Lewis
9e36fe7d34
CLDC-4314: Monthly service charge soft validation redirect bug ( #3249 )
...
* CLDC-4314: set unique urls for shared ownership soft validations
* CLDC-4314: update specs
2 weeks ago
Samuel Young
dddf661f63
CLDC-4157: Remove nursing care from scheme level of support ( #3224 )
...
* CLDC-4157: Remove nursing care home level of support
* CLDC-4157: Add a helper script to mark impacted schemes & logs as incomplete
* CLDC-4157: Update scheme factory
* CLDC-4157: Remove redundant scheme hint functions
* fixup! CLDC-4157: Add a helper script to mark impacted schemes & logs as incomplete
correct script name
2 weeks ago
Samuel Young
749e69d5ea
CLDC-4239: Widen age range for pregnancy soft validation ( #3192 )
...
* CLDC-4239: Update age range for pregnancy soft validation for 2026
* CLDC-4239: Update tests
looks like the 2026 tests were testing the 2025 method, so have updated
* fixup! CLDC-4239: Update tests
* fixup! CLDC-4239: Update tests
add boundary cases for 2025
* fixup! CLDC-4239: Update tests
make 8 household memmbers clear
2 weeks ago
Samuel Young
3305e3017b
CLDC-4306: Correct sales still serving options for 2026 ( #3248 )
2 weeks ago
Nat Dean-Lewis
80329f5c9a
CLDC-4249: reorder answer options ( #3220 )
2 weeks ago
samyou-softwire
c04f10f89a
CLDC-4325: Turn the 2026 override on again
2 weeks ago
samyou-softwire
bc61f733bc
CLDC-4325: Fix lettings log derived spec in 2025
...
timecop required for the start dates to work
2 weeks ago
samyou-softwire
7e690964db
CLDC-4325: Fix sales log spec in 2025
...
need to use let rather than let! so the timecop can run first
2 weeks ago
samyou-softwire
6f5446e956
CLDC-4325: Add a corresponding return to timecop missing one
2 weeks ago
samyou-softwire
563f34fd3f
CLDC-4325: Turn off 2026 override
2 weeks ago
samyou-softwire
58d922ccd1
CLDC-4325: Run all tests now and in 2026
2 weeks ago
samyou-softwire
af822ded37
CLDC-4325: Fix guidance helper spec
2 weeks ago
samyou-softwire
dafbac8063
CLDC-4325: Use or later in all touched tests
2 weeks ago
samyou-softwire
818041d1f3
CLDC-4325: Remove 2024 rake
2 weeks ago
samyou-softwire
06b7ebd8d4
CLDC-4325: Fix check answers summary component
2 weeks ago
samyou-softwire
f9c2af53fd
CLDC-4325: Fix sales BU validator spec
2 weeks ago
samyou-softwire
50161119c6
CLDC-4325: Fix duplicate logs controller spec
...
also introduce a new helper for a dynamic way of setting year
2 weeks ago
samyou-softwire
62d24533dd
CLDC-4325: Fix hhmemb spec
2 weeks ago
samyou-softwire
21149f058c
CLDC-4325: Fix form controller spec
2 weeks ago
samyou-softwire
aea35f4bf2
CLDC-4325: Fix remaining model specs
2 weeks ago
samyou-softwire
4a41878630
CLDC-4221: Add 2026 collection deadlines
2 weeks ago
samyou-softwire
b4e5550058
CLDC-4325: Fix lettings household validations spec
2 weeks ago
samyou-softwire
119df7cf46
CLDC-4325: Fix collection resources controller spec
2 weeks ago
samyou-softwire
95e6b6f1b1
CLDC-4325: Fix sales soft validations
2 weeks ago
samyou-softwire
64b815c436
CLDC-4325: Fix old rake task tests
2 weeks ago
samyou-softwire
e05829ae8e
CLDC-4325: Fix check answers spec
2 weeks ago
samyou-softwire
26babfe431
CLDC-4325: Fix sale information % tests
...
I'm not sure why I turned off strict post 2026, it's wanted in the same scenarios as before as shown by the failing tests
2 weeks ago
samyou-softwire
2f74fabf13
CLDC-4325: Set date to 2026
2 weeks ago
Samuel Young
b65de0c6d8
CLDC-4179: Fix duplicate logs check ( #3245 )
...
* Reapply "CLDC-4179: Amend sales duplicate log check (#3207 )" (#3241 )
This reverts commit 3bcc6627c0 .
* CLDC-4179: Enable BU duplicate log check on staging
2 weeks ago
Carolyn Barker
de4e0945a1
CLDC-4146 infer no other partners ( #3152 )
...
* CLDC-4146 infer no to multiple partners
* CLDC-4146 try removing factory change
* Simplify inference logic
* Fix not equals logic
* Improve person_partner tests
* Add tests for new not equals logic
* Improve person_lead_partner tests
* Fix inference logic
* Revert to simpler inference logic
* Correct hidden_in_check_answers logic
* Fixed derived?
* Improve lettings log variables tests
* Pull out resetting partner fields into method
* Convert 'else next' to guard clause
* Refactor infer_only_partner!
* Match updated requirements
* Fix tests
* Small tweaks
* Remove redundant logic from infer_at_most_one_relationship!
* Remove redundant `disable_clearing_if_not_routed_or_dynamic_answer_options`
* Add tests for question number
* Remove puts
* Refactor derived fields tests
* Fix lint
* After build, set nil values for `details_known` to 0
* Add details_known to tests
* Add question mark to method name
* Rewrite `is_another_person_partner?` to be `is_any_person_partner?`
* Move skip in form flow method from page to question
* Fix tests
* Fix tests after merge
---------
Co-authored-by: Carolyn <carolyn.barker@softwire.com>
Co-authored-by: oscar-richardson-softwire <oscar.richardson@softwire.com>
2 weeks ago
Samuel Young
3bcc6627c0
Revert "CLDC-4179: Amend sales duplicate log check ( #3207 )" ( #3241 )
...
This reverts commit c085cbb572 .
2 weeks ago