* CLDC-3499: Update selenium
allows for the tests to run locally as it can download a browser version that exists
* CLDC-3499: Fix validations spec to be non year specific
* CLDC-3499: Remove unneeded 2020 dates from bulk scheme locations spec
* CLDC-3499: Remove year specific tests from form_handler_spec
* CLDC-3499: Remove 2020 test from lettings_log_spec
* CLDC-3499: Remove 2020 test from sales_log_spec
* CLDC-3499: Remove 2020 test from location_spec
makes the current_collection_after_crossover_start_date method a bit more useful, returns the date in the current collection year that crossover will end, rather than the crossover end date of the current period (which will be next year)
* CLDC-3499: Remove 2020 test from scheme_spec
* CLDC-3499: Remove 2020 test from setup_validations_spec
adds missing archived method to collection_time_helper
* CLDC-3499: Start changes to lettings log export service
* CLDC-3499: Remove unneeded old test from check answers summary list component spec
* CLDC-3499: Update check answers page spec for modern years
* CLDC-3499: Add more form helpers
* CLDC-3499: Remove year specific tests from lettings setup validations
* CLDC-3499: Remove year specific tests from managing org rake spec
* CLDC-3499: Update lettings log spec
* CLDC-3499: Update task list spec
* CLDC-3499: Update sales logs controller
* CLDC-3499: Remove old tests from sales log spec
* CLDC-3499: Fix some final old tests
* Revert "CLDC-3499: Start changes to lettings log export service"
This reverts commit 1edbc9ab8c.
* CLDC-3499: Lint
* CLDC-3676: date validations
* CLDC-3676: sales financial validations
* CLDC-3676: sales household validations
* CLDC-3676: lettings household validations
* CLDC-3676: sales property validations
* CLDC-3676: lettings property validations
* CLDC-3676: lettings sale validations
* CLDC-3676: lettings tenancy validations
* CLDC-3676: sales soft validations year edits
* CLDC-3676: sales discounted sale soft validation
* CLDC-3676: sales extra borrowing soft validation
* CLDC-3676: sales deposit value soft validation
* CLDC-3676: update other specs
* CLDC-3676: update net income value check spec
* CLDC-3676: lint
* CLDC-3676: remove old bulk upload specs
* CLDC-3676: add 2024 soft validation behaviour back
* feat: improve validate_person_age_matches_economic_status test case coverage
* feat: enforce crossover tests pass
* feat: re-include archived log display test
---------
Co-authored-by: Nat Dean-Lewis <nat.dean-lewis@softwire.com>
Co-authored-by: Nat Dean-Lewis <94526761+natdeanlewissoftwire@users.noreply.github.com>
* CLDC-4237: Upgrade ruby to 3.4.4
* CLDC-4237: Add additional build dependencies to Dockerfile
* CLDC-4237: Update rubocop
* CLDC-4237: Fix new rubocop rules
most auto applies
RSpec/IndexedLet had 200 hits needing manual correction so left these for now
* CLDC-4237: Resolve vulnerable dependencies
* CLDC-4237: Fix erb files
* CLDC-4237: Downgrade connection_pool
* Add validation message for missing charge fields in bulk upload
* Update error messages for missing charges in row parser tests
* only annotate errors to the other fields if there was an error
---------
Co-authored-by: Samuel <samuel.young@softwire.com>
* Update text copy to use curly apostrophes for consistency
* Update BU text copy to use curly apostrophes for consistency
* Update BU text copy to use curly apostrophes for consistency
* Update text copy to use 'Other' for consistency in instead of 'other'
* Update text copy for 'Reasonable preference reason' fields to improve clarity
* Update tests
* Conditional assignment for irproduct_other based on rent type 2025
* Conditional assignment for irproduct_other based on rent type 2024
* Update irproduct_other attributes to include field_11 in test
* Update irproduct_other attributes to include field_11 in test
* Add validation on reasonpref dontknow
* Add test
* Update method
* Update setting errors
* Update test
* Add tests for rake task
* separate out tests
* Test updated at, excluding pre 2024
* Update 2025 row parser
* Clear values if rp_dontknow conflict exists
* Reorder, no change just precautionary
* Put back code removed
* Copy row and csv parser for 2025 lettings
* Add 2025 BU translations file
* Update row parser field number
* Add "apecified accommodation" to rent type mapping
* Update csv parser
* Add prepare your file and connect the csv parser to log creator and validator
* Update test file creation
* Refactor some csv methods, add person relationship mapping
* Update row parser specs
* Further refactor some test helper methods
* Merge update
* Copy update
* Update copy
* Check address options returned is more than 1
* Update test
* Update and add test
* Update error messaging for single and multiple returns
* lint
* Fix lint
* Check correct benefits value in the validation
* Update some tests
* Update validation
* clear invalid benefits
* Update more tests
* Fix world
* Clear the benefits
* Move benefits assign
* CLDC-3330: Use partial postcodes in bulk upload
* Adjust key address fields provided validations
* Use join to only insert space when both parts of postcode are provided
* Make full stops consistent in error messages
* Fix test
* Update few hardcoded errors
* Update join in remaining row parsers
* Update some more tests
* Update more hard coded BU errors
* Fix typo I introduced - bedrooms to bedroom
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
* create presenter class to hold all the db calls and data for showing the home page
plus tests, some changes to factoreis and helpers necessary
this should avoid an overly bloated controller method or calling the DB from a view helper
* view partial changes
to accommodate design changes, decouple box with counter and blue link boxes
since various boxes show or not or in a different order depending on whether the org logs sales and whether we are in the crossover period I have also made grid and row partials to improve readability on the index page.
* redesign the home page using the new presenter and partials, deliver the presenter object to the view from the controller
* adjust tests and factories and address api call stub
* remove view helpers that are no longer being used and remove outdated tests for home page
* amend presenter and associated calls from view, tests, to ensure support user always sees sales data
* write request specs for the homepage
* undo unnecessary change to factory
* make corrections following rebase conflicts
* various minor changes following tech review
* logs assigned to a provider should be vivisble to them in the homepage count rather than logs created by them
* resolve rebase confusion in csv fixture files
* Empty
* CLDC-3345 Rename created_by to assigned_to (#2372)
* Rename created_by to assigned_to
* Replace created_by with assigned_to
* Update created_by to assigned_to in exports, remove blank assigned to
* CLDC-3345 Add and set created_by fields (#2373)
* Add created_by
* Update existing created_by values
* Set created_by on single log
* Set created_by on BU
* Add created_by to exports
* feat: update since last merge
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
* Fix papertrail create version
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
* feat: validate nulls last in bu
* feat: add tests
* feat: update org errors and tests
* feat: update test copy
* feat: update tests
* CLDC-3328 Make bulk upload errors consistent between lettings and sales (#2341)
* feat: add validate_address_fields to lettings for 2024
* CLDC-3338: Add tolerance to discounted sale calculations (#2333)
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
* C:DC-3338: Add tolerance to grant calculations
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
* feat: add validate_address_fields to lettings for 2024
* feat: update tests
* Revert "CLDC-3338: Add tolerance to discounted sale calculations (#2333)"
This reverts commit cdecdfebfe.
---------
Co-authored-by: Robert Sullivan <Robert.Sullivan@Softwire.com>
Co-authored-by: Kat <katrina@kosiak.co.uk>
---------
Co-authored-by: Robert Sullivan <Robert.Sullivan@Softwire.com>
Co-authored-by: Kat <katrina@kosiak.co.uk>
* feat: mvp commit with address selector from address line 1 and postcode using OS places find endpoint
* feat: build out alternative routes through the address lookup flow
* refactor: lint
* refactor: remove commented lines
* feat: make nil safe
* feat: test address client
* feat: store address input separately
* feat: add migration
* feat: display inputs in answer label
* feat: update data presenter and test
* feat: revert precicions schema update
* feat: revert precision schema update
* feat: migrate new fields to sales logs
* feat: update shared log examples tests
* feat: use -1 for not listed address for extensibility
* feat: add service error to address_selection
* feat: handle case when no addresses are found
* feat: allow re-entering different uprns
* feat: improve error handling and don't accept "no match" precisions
* feat: add page tests
* feat: confirm uprn on address update
* feat: add question tests
* feat: don't set minimum match for initial search
* feat: mvp commit with address selector from address line 1 and postcode using OS places find endpoint
* feat: build out alternative routes through the address lookup flow
* refactor: lint
* refactor: remove commented lines
* feat: make nil safe
* feat: test address client
* feat: store address input separately
* feat: add migration
* feat: display inputs in answer label
* feat: update data presenter and test
* feat: revert precision schema update
* feat: migrate new fields to sales logs
* feat: update shared log examples tests
* feat: use -1 for not listed address for extensibility
* feat: add service error to address_selection
* feat: handle case when no addresses are found
* feat: allow re-entering different uprns
* feat: improve error handling and don't accept "no match" precisions
* feat: add page tests
* feat: confirm uprn on address update
* feat: add question tests
* feat: don't set minimum match for initial search
* feat: add no address found page
* feat: allow uprn known to be skipped, and set 0.4 min precision
* feat: accept best "good" match in bulk upload
* feat: update validations and test
* refactor: avoid stubbing using any_instance_of
* refactor: use change_table in migrations
* feat: add lettings behaviour to sales logs
* feat: update sales tests
* feat: xit test that is xited in lettings
* feat: stub os api in sales row parser
* feat: stub os api in sales row parser
* feat: add address line 1 to required attributes
* feat: update matching details and fix row parser validation
* refactor: improve readability
* feat: set uprns as option IDs to avoid multiple lookups
* feat: add sales uprn_selection
* feat: update schema
* feat: update tests
* feat: remove redundant methods
* feat: update error message and fix tests
* feat: update tests
* feat: update tests and error behaviour
* feat: update tests
Samuel Young
Manny Dinssa
kosiakkatrina
Rachael Booth
Arthur Campbell
natdeanlewissoftwire