* CLDC-3499: Update selenium
allows for the tests to run locally as it can download a browser version that exists
* CLDC-3499: Fix validations spec to be non year specific
* CLDC-3499: Remove unneeded 2020 dates from bulk scheme locations spec
* CLDC-3499: Remove year specific tests from form_handler_spec
* CLDC-3499: Remove 2020 test from lettings_log_spec
* CLDC-3499: Remove 2020 test from sales_log_spec
* CLDC-3499: Remove 2020 test from location_spec
makes the current_collection_after_crossover_start_date method a bit more useful, returns the date in the current collection year that crossover will end, rather than the crossover end date of the current period (which will be next year)
* CLDC-3499: Remove 2020 test from scheme_spec
* CLDC-3499: Remove 2020 test from setup_validations_spec
adds missing archived method to collection_time_helper
* CLDC-3499: Start changes to lettings log export service
* CLDC-3499: Remove unneeded old test from check answers summary list component spec
* CLDC-3499: Update check answers page spec for modern years
* CLDC-3499: Add more form helpers
* CLDC-3499: Remove year specific tests from lettings setup validations
* CLDC-3499: Remove year specific tests from managing org rake spec
* CLDC-3499: Update lettings log spec
* CLDC-3499: Update task list spec
* CLDC-3499: Update sales logs controller
* CLDC-3499: Remove old tests from sales log spec
* CLDC-3499: Fix some final old tests
* Revert "CLDC-3499: Start changes to lettings log export service"
This reverts commit 1edbc9ab8c.
* CLDC-3499: Lint
* CLDC-3676: date validations
* CLDC-3676: sales financial validations
* CLDC-3676: sales household validations
* CLDC-3676: lettings household validations
* CLDC-3676: sales property validations
* CLDC-3676: lettings property validations
* CLDC-3676: lettings sale validations
* CLDC-3676: lettings tenancy validations
* CLDC-3676: sales soft validations year edits
* CLDC-3676: sales discounted sale soft validation
* CLDC-3676: sales extra borrowing soft validation
* CLDC-3676: sales deposit value soft validation
* CLDC-3676: update other specs
* CLDC-3676: update net income value check spec
* CLDC-3676: lint
* CLDC-3676: remove old bulk upload specs
* CLDC-3676: add 2024 soft validation behaviour back
* feat: improve validate_person_age_matches_economic_status test case coverage
* feat: enforce crossover tests pass
* feat: re-include archived log display test
---------
Co-authored-by: Nat Dean-Lewis <nat.dean-lewis@softwire.com>
Co-authored-by: Nat Dean-Lewis <94526761+natdeanlewissoftwire@users.noreply.github.com>
* CLDC-3499: Update selenium
allows for the tests to run locally as it can download a browser version that exists
* CLDC-3499: Fix validations spec to be non year specific
* CLDC-3499: Remove unneeded 2020 dates from bulk scheme locations spec
* CLDC-3499: Remove year specific tests from form_handler_spec
* CLDC-3499: Remove 2020 test from lettings_log_spec
* CLDC-3499: Remove 2020 test from sales_log_spec
* CLDC-3499: Remove 2020 test from location_spec
makes the current_collection_after_crossover_start_date method a bit more useful, returns the date in the current collection year that crossover will end, rather than the crossover end date of the current period (which will be next year)
* CLDC-3499: Remove 2020 test from scheme_spec
* CLDC-3499: Remove 2020 test from setup_validations_spec
adds missing archived method to collection_time_helper
* CLDC-3499: Start changes to lettings log export service
* CLDC-3499: Remove unneeded old test from check answers summary list component spec
* CLDC-3499: Update check answers page spec for modern years
* CLDC-3499: Add more form helpers
* CLDC-3499: Remove year specific tests from lettings setup validations
* CLDC-3499: Remove year specific tests from managing org rake spec
* CLDC-3499: Update lettings log spec
* CLDC-3499: Update task list spec
* CLDC-3499: Update sales logs controller
* CLDC-3499: Remove old tests from sales log spec
* CLDC-3499: Fix some final old tests
* Revert "CLDC-3499: Start changes to lettings log export service"
This reverts commit 1edbc9ab8c.
* CLDC-3499: Lint
* feat: enforce crossover tests pass
* feat: re-include archived log display test
---------
Co-authored-by: Nat Dean-Lewis <nat.dean-lewis@softwire.com>
Co-authored-by: Nat Dean-Lewis <94526761+natdeanlewissoftwire@users.noreply.github.com>
* CLDC-4328: Update wrong field numbers error
* fixup! CLDC-4328: Update wrong field numbers error
* CLDC-4328: Use a specific error message per year/log type
* fixup! CLDC-4328: Use a specific error message per year/log type
* CLDC-4300: Stricten validation on initialpurchase
* CLDC-4300: Add a correction script
* CLDC-4300: Update tests
* CLDC-4300: Ensure lasttransaction cannot equal saledate or initialtransaction
* CLDC-4300: Update date correcting rake to also account for lasttransaction = initialpurchase
* CLDC-4300: Revert updates to copy
* CLDC-4300: Apply these changes from 2026 only
* CLDC-4300: Compare lasttransaction to saledate
due to the it <= lt <= sd relationship, there's no need to comparse it to sd. if it == sd then it == lt and lt == sd
* CLDC-4300: Fix script in cases where all 3 dates are equal
* CLDC-3280: Add back link to error summary page
* CLDC-3280: Hide upload button if navigating from a view url
* CLDC-3280: Update tests
* CLDC-3280: Make read only error report opt-in
this means we can be happy only the touched pages will have a change in behaviour
* CLDC-3280: Rename fix errors in tests to reupload file
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
---------
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* CLDC-4332: Check that a support user can only be in certain orgs
* CLDC-4332: Add tests
* CLDC-4332: Lint
* CLDC-4332: Only show the check for wrong org on edit
* CLDC-4332: Add the error to role if role is wrong
* fixup! CLDC-4332: Only show the check for wrong org on edit
lint
* CLDC-4332: TEMP: Add MHCLG filter for review apps
* Revert "CLDC-4332: TEMP: Add MHCLG filter for review apps"
This reverts commit b65c630ede.
* CLDC-4300: Stricten validation on initialpurchase
* CLDC-4300: Add a correction script
* CLDC-4300: Update tests
* CLDC-4300: Ensure lasttransaction cannot equal saledate or initialtransaction
* CLDC-4300: Update date correcting rake to also account for lasttransaction = initialpurchase
* CLDC-4300: Revert updates to copy
* CLDC-4300: Apply these changes from 2026 only
* fixup! CLDC-4300: Apply these changes from 2026 only
in rake too
* CLDC-4300: Compare lasttransaction to saledate
due to the it <= lt <= sd relationship, there's no need to comparse it to sd. if it == sd then it == lt and lt == sd
* fixup! CLDC-4300: Compare lasttransaction to saledate
update rake desc
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
---------
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* CLDC-4313: Add maximum bounds to value and mortgage questions for 2026
* CLDC-4313: Add a rake task to correct logs
* CLDC-4313: New max from 2025 or later
* CLDC-4313: Remove redundant queries from rake
* CLDC-4313: Fix page specs
* fixup! CLDC-4313: Fix page specs
missed one
* CLDC-4313: Update rake name
2025 or later
* CLDC-4313: Include other fields missing max
mrentprestaircasing
management_fee
* CLDC-4432: Skip invalid field errors if the question is not routed to
* CLDC-4432: Add tests
* CLDC-4432: Lint
* fixup! CLDC-4432: Add tests
comment test dependencies
* CLDC-3205: Add net income value check where missing
hhmemb
ecstat1..8
age2..8 (twice as the age question moved)
* CLDC-3205: Group household_characteristics better
* CLDC-3205: Update tests
* CLDC-3205: Update csv export specs
* fixup! CLDC-3205: Update tests
* CLDC-4250: Add a new validation for universal credit and household income sources
* CLDC-4250: Add verifying tests
* CLDC-4250: Add a post release script
* fixup! CLDC-4250: Add verifying tests
remove unneeded setup
* fixup! CLDC-4250: Add verifying tests
fix test name
* CLDC-4250: make benefits also invalid
as requested on ticket
update rake
* CLDC-4356: Add hyphen to builtype Purpose-built in lettings
* CLDC-4356: Add hyphen to building type Purpose-built in sales
* CLDC-4356: Update CSV export tests
* CLDC-4356: Update model tests
* CLDC-4363: Set date to 1st August
* CLDC-4363: Update lettings log csv service spec
* CLDC-4363: Update collection resources controller spec
* CLDC-4363: Update lettings log derived fields
* CLDC-4363: Update remaining model tests
* CLDC-4363: Test August 2nd
* CLDC-4363: Test July 31st
* CLDC-4363: Test back in present
* fixup! CLDC-4363: Update remaining model tests
wrong field
* CLDC-4114: Silence DPO warning if DSA is signed
also restructure redundant logic in the file
* CLDC-4114: Update tests
* fixup! CLDC-4114: Silence DPO warning if DSA is signed
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* CLDC-4114: Restructure data protection confirmation banner tests
* fixup! CLDC-4114: Restructure data protection confirmation banner tests
* fixup! CLDC-4114: Restructure data protection confirmation banner tests
fix typo
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* CLDC-4114: Lint after merge
since rubocop updated
---------
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* CLDC-4333: update purchase price soft vals to take stairbought into account
* CLDC-4333: set hard min to 0 for staircasing
* CLDC-4333: add dynamic hard min based on stairbought
* CLDC-4333: step value input width up to next option
* CLDC-4333: update value spec
* CLDC-4333: update hint text instead to ensure value is 100% of equity
* CLDC-4333: update hint text instead to ensure value is 100% of equity
* CLDC-4333: revert q text change to align with spec
* CLDC-4333: revert spec changes
* CLDC-4333: revert 2025 changes
* CLDC-4333: clarify 2026 question
* CLDC-4333: revert question fix
* CLDC-4333: revert initial purchase hint text update
* CLDC-4340: Account for nil location name on location select
use postcode as a fallback, which should never be nil
* CLDC-4340: Add a verifying test
* CLDC-4340: Put all postcode locations at the end
* CLDC-4340: Sort locations by postcode
* CLDC-4325: Set date to 2026
* CLDC-4325: Fix sale information % tests
I'm not sure why I turned off strict post 2026, it's wanted in the same scenarios as before as shown by the failing tests
* CLDC-4325: Fix check answers spec
* CLDC-4325: Fix old rake task tests
* CLDC-4325: Fix sales soft validations
* CLDC-4325: Fix collection resources controller spec
* CLDC-4325: Only add noms and org to CSV row if prp
in most cases this was done by default but some tests construct an invalid log
* CLDC-4325: Fix lettings household validations spec
* CLDC-4221: Add 2026 collection deadlines
* CLDC-4325: Fix remaining model specs
* CLDC-4325: Fix form controller spec
* CLDC-4325: Fix hhmemb spec
* CLDC-4325: Fix duplicate logs controller spec
also introduce a new helper for a dynamic way of setting year
* CLDC-4325: Fix sales BU validator spec
* CLDC-4325: Fix check answers summary component
* CLDC-4325: Remove 2024 rake
* CLDC-4325: Use or later in all touched tests
* CLDC-4325: Fix guidance helper spec
* CLDC-4325: Run all tests now and in 2026
* CLDC-4325: Turn off 2026 override
* CLDC-4325: Add a corresponding return to timecop missing one
* CLDC-4325: Fix sales log spec in 2025
need to use let rather than let! so the timecop can run first
* CLDC-4325: Fix lettings log derived spec in 2025
timecop required for the start dates to work
* CLDC-4325: Turn the 2026 override on again
* fixup! CLDC-4325: Fix check answers summary component
* CLDC-4325: Delete recalculate_reasonpref_dontknow rake
only needed for 2024 logs
* fixup! CLDC-4325: Fix lettings household validations spec
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* fixup! CLDC-4325: Fix sales log spec in 2025
* fixup! CLDC-4325: Fix sales log spec in 2025
* CLDC-4325: Make start controller spec not year specific
* CLDC-4325: Run tests in current day
* CLDC-4325: Run tests on 31st march
* CLDC-4325: Run tests on 2nd april
* CLDC-4325: Properly run tests on current day
* fixup! CLDC-4325: Fix sales soft validations
* fixup! CLDC-4325: Make start controller spec not year specific
* CLDC-4325: Run tests on 31st march
* CLDC-4325: Run tests on 1st april
* CLDC-4325: Run tests on 2nd april
* CLDC-4325: Revert time travel
---------
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
* CLDC-4270: Add tests
* CLDC-4270: Port changes to other years' parsers
sales 2025 2026
lettings 2026
* fixup! CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
* fixup! CLDC-4270: Port changes to other years' parsers
* CLDC-4270: Fix tests post merge
* fixup! CLDC-4270: Add tests
* CLDC-4270: Add ? to boolean method
* CLDC-4263: align new service charge questions with bu spec
* CLDC-4263: fix "no" mapping and allow decimal mscharge
* CLDC-4263: update tests
* CLDC-4297: clarify test naming
* CLDC-4297: add tests for inferences and confirm R inference
* CLDC-4297: add test override
* CLDC-4297: remove R tests
* CLDC-4297: add R behaviour back in
* CLDC-4297: updated error handling
* CLDC-4297: add warning comment on block_log_creation!
* CLDC-4297: test updates
* CLDC-4297: comment update
* CLDC-4297: allow 0 for newservicecharges
* CLDC-4297: test improvements
* CLDC-4297: test negatives and unify order
* CLDC-4297: misc cleanup
* CLDC-4297: specify same value errors
* CLDC-4297: don't allow 0 for mscharge and update tests
* CLDC-4297: update case insensitive field tests
* CLDC-4297: don't allow 0.0
* CLDC-4297: test 0.0 and r explicitly
* CLDC-4297: refactor and simplify
* CLDC-4297: final validation test tweaks
---------
Co-authored-by: samyou-softwire <samuel.young@softwire.com>
* CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
* CLDC-4270: Add tests
* CLDC-4270: Port changes to other years' parsers
sales 2025 2026
lettings 2026
* fixup! CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
* fixup! CLDC-4270: Port changes to other years' parsers
* CLDC-4270: Fix tests post merge
* fixup! CLDC-4270: Add tests
* CLDC-4270: Add ? to boolean method
oscric
Nat Dean-Lewis
Samuel Young
Nat Dean-Lewis
Frank Ma