Browse Source

lint

pull/2571/head
Kat 2 years ago
parent
commit
fb726dedf5
  1. 3
      app/controllers/merge_requests_controller.rb
  2. 6
      app/views/merge_requests/merge_date.html.erb

3
app/controllers/merge_requests_controller.rb

@ -82,7 +82,7 @@ private
:requesting_organisation_id, :requesting_organisation_id,
:status, :status,
:absorbing_organisation_id, :absorbing_organisation_id,
:merge_date :merge_date,
) )
merge_params[:requesting_organisation_id] = current_user.organisation.id merge_params[:requesting_organisation_id] = current_user.organisation.id
@ -102,6 +102,7 @@ private
year = merge_request_params["merge_date(1i)"] year = merge_request_params["merge_date(1i)"]
return @merge_request.errors.add(:merge_date, :blank) if [day, month, year].all?(&:blank?) return @merge_request.errors.add(:merge_date, :blank) if [day, month, year].all?(&:blank?)
if [day, month, year].none?(&:blank?) && Date.valid_date?(year.to_i, month.to_i, day.to_i) if [day, month, year].none?(&:blank?) && Date.valid_date?(year.to_i, month.to_i, day.to_i)
merge_request_params["merge_date"] = Time.zone.local(year.to_i, month.to_i, day.to_i) merge_request_params["merge_date"] = Time.zone.local(year.to_i, month.to_i, day.to_i)
else else

6
app/views/merge_requests/merge_date.html.erb

@ -10,10 +10,10 @@
<h2 class="govuk-heading-l">What is the merge date?</h2> <h2 class="govuk-heading-l">What is the merge date?</h2>
<p class="govuk-hint"> <p class="govuk-hint">
Enter the official merge date. Log and organisation page data will show the new organisation name from this date. <br/><br/> Enter the official merge date. Log and organisation page data will show the new organisation name from this date. <br><br>
For example, 27 3 2024</p> For example, 27 3 2024</p>
<%= f.govuk_date_field :merge_date, <%= f.govuk_date_field :merge_date,
legend: {hidden: true}, legend: { hidden: true },
width: 20 do %> width: 20 do %>
<% end %> <% end %>
<%= f.hidden_field :page, value: "merge_date" %> <%= f.hidden_field :page, value: "merge_date" %>
@ -21,4 +21,4 @@
<%= f.govuk_submit %> <%= f.govuk_submit %>
<% end %> <% end %>
</div> </div>
</div> </div>

Loading…
Cancel
Save