From f82bccd7d8388d72d4937d9acf40de77bb765edd Mon Sep 17 00:00:00 2001 From: Kat Date: Thu, 11 Jul 2024 12:00:09 +0100 Subject: [PATCH] Reuse rent_type mapping --- lib/tasks/correct_rent_type_value.rake | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/tasks/correct_rent_type_value.rake b/lib/tasks/correct_rent_type_value.rake index 96a8e0a05..8ecf01c1f 100644 --- a/lib/tasks/correct_rent_type_value.rake +++ b/lib/tasks/correct_rent_type_value.rake @@ -1,13 +1,5 @@ desc "Alter rent_type values for bulk uploaded lettings logs for 2024 where they were not mapped correctly" task correct_rent_type_value: :environment do - rent_type_detail_mapping = { - 1 => 0, - 2 => 1, - 3 => 2, - 4 => 3, - 5 => 4, - 6 => 5, - } affected_uploads = BulkUpload.where(log_type: "lettings", year: 2024) affected_uploads.each do |upload| upload.logs.where.not(rent_type: nil).each do |log| @@ -15,7 +7,8 @@ task correct_rent_type_value: :environment do rent_type_at_upload = log.versions.length == 1 ? log.rent_type : log.versions.first.next.reify.rent_type next unless rent_type_at_upload == current_rent_type - log.rent_type = rent_type_detail_mapping[rent_type_at_upload] + new_rent_type_value = BulkUpload::Lettings::Year2024::RowParser::RENT_TYPE_BU_MAPPING[rent_type_at_upload] + log.rent_type = new_rent_type_value log.skip_update_status = true if log.status == "pending" if log.save Rails.logger.info("Log #{log.id} rent_type updated from #{rent_type_at_upload} to #{log.rent_type}")