Browse Source

Add fields check to 2023 sales

pull/2233/head
Kat 2 years ago
parent
commit
f430ff7b62
  1. 5
      app/services/bulk_upload/sales/year2023/csv_parser.rb
  2. 4
      spec/services/bulk_upload/sales/year2023/csv_parser_spec.rb

5
app/services/bulk_upload/sales/year2023/csv_parser.rb

@ -4,6 +4,7 @@ class BulkUpload::Sales::Year2023::CsvParser
include CollectionTimeHelper
MAX_COLUMNS = 142
FIELDS = 135
FORM_YEAR = 2023
attr_reader :path
@ -60,7 +61,9 @@ class BulkUpload::Sales::Year2023::CsvParser
end
def correct_field_count?
true
valid_field_numbers_count = field_numbers.count { |f| f != "field_blank" }
valid_field_numbers_count == FIELDS
end
private

4
spec/services/bulk_upload/sales/year2023/csv_parser_spec.rb

@ -28,6 +28,10 @@ RSpec.describe BulkUpload::Sales::Year2023::CsvParser do
it "parses csv correctly" do
expect(service.row_parsers[0].field_19).to eql(log.uprn)
end
it "counts the number of valid field numbers correctly" do
expect(service).to be_correct_field_count
end
end
context "when parsing csv with headers in arbitrary order" do

Loading…
Cancel
Save