test: update tests

spec/models/form/sales/pages/person_age_spec.rb

@@ -35,9 +35,7 @@ RSpec.describe Form::Sales::Pages::PersonAge, type: :model do
 
       it "has correct depends_on" do
         expect(page.depends_on).to eq(
-          [
-            { "details_known_1" => 1, "jointpur" => 2 },
-          ],
+          [{ "hholdcount" => 1, "jointpur" => 2 }, { "hholdcount" => 2, "jointpur" => 2 }, { "hholdcount" => 3, "jointpur" => 2 }, { "hholdcount" => 4, "jointpur" => 2 }],
         )
       end
     end
@@ -121,9 +119,7 @@ RSpec.describe Form::Sales::Pages::PersonAge, type: :model do
 
       it "has correct depends_on" do
         expect(page.depends_on).to eq(
-          [
-            { "details_known_1" => 1, "jointpur" => 1 },
-          ],
+          [{ "hholdcount" => 1, "jointpur" => 1 }, { "hholdcount" => 2, "jointpur" => 1 }, { "hholdcount" => 3, "jointpur" => 1 }, { "hholdcount" => 4, "jointpur" => 1 }],
         )
       end
     end

spec/models/form/sales/pages/person_known_spec.rb

@@ -66,11 +66,7 @@ RSpec.describe Form::Sales::Pages::PersonKnown, type: :model do
 
     it "has correct depends_on" do
       expect(page.depends_on).to eq(
-        [
-          { "hholdcount" => 2, "details_known_1" => 1 },
-          { "hholdcount" => 3, "details_known_1" => 1 },
-          { "hholdcount" => 4, "details_known_1" => 1 },
-        ],
+        [{ "hholdcount" => 2 }, { "hholdcount" => 3 }, { "hholdcount" => 4 }],
       )
     end
   end
@@ -93,10 +89,7 @@ RSpec.describe Form::Sales::Pages::PersonKnown, type: :model do
 
     it "has correct depends_on" do
       expect(page.depends_on).to eq(
-        [
-          { "hholdcount" => 3, "details_known_2" => 1 },
-          { "hholdcount" => 4, "details_known_2" => 1 },
-        ],
+        [{ "hholdcount" => 3 }, { "hholdcount" => 4 }],
       )
     end
   end
@@ -119,9 +112,7 @@ RSpec.describe Form::Sales::Pages::PersonKnown, type: :model do
 
     it "has correct depends_on" do
       expect(page.depends_on).to eq(
-        [
-          { "hholdcount" => 4, "details_known_3" => 1 },
-        ],
+        [{ "hholdcount" => 4 }],
       )
     end
   end

spec/models/form/sales/pages/person_working_situation_spec.rb

@@ -35,7 +35,7 @@ RSpec.describe Form::Sales::Pages::PersonWorkingSituation, type: :model do
       end
 
       it "has correct depends_on" do
-        expect(page.depends_on).to eq([{ "details_known_1" => 1, "jointpur" => 2 }])
+        expect(page.depends_on).to eq([{ "hholdcount" => 1, "jointpur" => 2 }, { "hholdcount" => 2, "jointpur" => 2 }, { "hholdcount" => 3, "jointpur" => 2 }, { "hholdcount" => 4, "jointpur" => 2 }])
       end
     end
 
@@ -119,7 +119,7 @@ RSpec.describe Form::Sales::Pages::PersonWorkingSituation, type: :model do
       end
 
       it "has correct depends_on" do
-        expect(page.depends_on).to eq([{ "details_known_1" => 1, "jointpur" => 1 }])
+        expect(page.depends_on).to eq([{ "hholdcount" => 1, "jointpur" => 1 }, { "hholdcount" => 2, "jointpur" => 1 }, { "hholdcount" => 3, "jointpur" => 1 }, { "hholdcount" => 4, "jointpur" => 1 }])
       end
     end
 

spec/models/form/sales/subsections/household_characteristics_spec.rb

@@ -34,7 +34,6 @@ RSpec.describe Form::Sales::Subsections::HouseholdCharacteristics, type: :model
         buyer_2_working_situation
         buyer_2_live_in_property
         number_of_others_in_property
-        person_1_known
         person_1_age
         person_1_age_joint_purchase
         person_1_gender_identity

spec/models/form_handler_spec.rb

@@ -52,14 +52,14 @@ RSpec.describe FormHandler do
     it "is able to load a current sales form" do
       form = form_handler.get_form("current_sales")
       expect(form).to be_a(Form)
-      expect(form.pages.count).to eq(68)
+      expect(form.pages.count).to eq(67)
       expect(form.name).to eq("2022_2023_sales")
     end
 
     it "is able to load a previous sales form" do
       form = form_handler.get_form("previous_sales")
       expect(form).to be_a(Form)
-      expect(form.pages.count).to eq(68)
+      expect(form.pages.count).to eq(67)
       expect(form.name).to eq("2021_2022_sales")
     end
   end