Browse Source

add method to sales log and use in depends on to increase readability

pull/1445/head
Arthur Campbell 3 years ago
parent
commit
f0732497d0
  1. 4
      app/models/form/sales/pages/mortgage_amount.rb
  2. 4
      app/models/sales_log.rb
  3. 4
      spec/models/form/sales/pages/mortgage_amount_spec.rb

4
app/models/form/sales/pages/mortgage_amount.rb

@ -3,9 +3,7 @@ class Form::Sales::Pages::MortgageAmount < ::Form::Page
super(id, hsh, subsection)
@ownershipsch = ownershipsch
@header = "Mortgage Amount"
@depends_on = [{
"mortgageused" => 1,
}]
@depends_on = [{ "mortgage_used?" => true }]
end
def questions

4
app/models/sales_log.rb

@ -229,6 +229,10 @@ class SalesLog < Log
ownershipsch == 2
end
def mortgage_used?
mortgageused == 1
end
def mortgage_not_used?
mortgageused == 2
end

4
spec/models/form/sales/pages/mortgage_amount_spec.rb

@ -28,8 +28,6 @@ RSpec.describe Form::Sales::Pages::MortgageAmount, type: :model do
end
it "has correct depends_on" do
expect(page.depends_on).to eq([{
"mortgageused" => 1,
}])
expect(page.depends_on).to eq([{ "mortgage_used?" => true }])
end
end

Loading…
Cancel
Save