From eeb441406185676c71d8ad87097ab7ff468e9aef Mon Sep 17 00:00:00 2001 From: Kat Date: Thu, 16 May 2024 10:57:06 +0100 Subject: [PATCH] Update cancel and back buttons --- app/controllers/lettings_logs_controller.rb | 2 +- app/controllers/organisations_controller.rb | 4 ++-- app/controllers/sales_logs_controller.rb | 2 +- app/helpers/filters_helper.rb | 8 ++++++++ app/views/filters/assigned_to.html.erb | 2 +- app/views/filters/managed_by.html.erb | 2 +- app/views/filters/needstype.html.erb | 2 +- app/views/filters/owned_by.html.erb | 2 +- app/views/filters/status.html.erb | 2 +- app/views/filters/years.html.erb | 2 +- app/views/logs/download_csv.html.erb | 2 +- 11 files changed, 19 insertions(+), 11 deletions(-) diff --git a/app/controllers/lettings_logs_controller.rb b/app/controllers/lettings_logs_controller.rb index ebe38a895..3ab6e8a10 100644 --- a/app/controllers/lettings_logs_controller.rb +++ b/app/controllers/lettings_logs_controller.rb @@ -92,7 +92,7 @@ class LettingsLogsController < LogsController unpaginated_filtered_logs = filter_manager.filtered_logs(current_user.lettings_logs, search_term, session_filters) - render "download_csv", locals: { search_term:, count: unpaginated_filtered_logs.size, post_path: email_csv_lettings_logs_path, codes_only: codes_only_export?, session_filters:, filter_type: "lettings_logs" } + render "download_csv", locals: { search_term:, count: unpaginated_filtered_logs.size, post_path: email_csv_lettings_logs_path, codes_only: codes_only_export?, session_filters:, filter_type: "lettings_logs", download_csv_back_link: lettings_logs_path } end def email_csv diff --git a/app/controllers/organisations_controller.rb b/app/controllers/organisations_controller.rb index 45426179f..1207461d1 100644 --- a/app/controllers/organisations_controller.rb +++ b/app/controllers/organisations_controller.rb @@ -154,7 +154,7 @@ class OrganisationsController < ApplicationController unpaginated_filtered_logs = filter_manager.filtered_logs(organisation_logs, search_term, session_filters) codes_only = params.require(:codes_only) == "true" - render "logs/download_csv", locals: { search_term:, count: unpaginated_filtered_logs.size, post_path: lettings_logs_email_csv_organisation_path, codes_only:, session_filters:, filter_type: "lettings_logs" } + render "logs/download_csv", locals: { search_term:, count: unpaginated_filtered_logs.size, post_path: lettings_logs_email_csv_organisation_path, codes_only:, session_filters:, filter_type: "lettings_logs", download_csv_back_link: lettings_logs_organisation_path(@organisation) } end def email_lettings_csv @@ -192,7 +192,7 @@ class OrganisationsController < ApplicationController unpaginated_filtered_logs = filter_manager.filtered_logs(organisation_logs, search_term, session_filters) codes_only = params.require(:codes_only) == "true" - render "logs/download_csv", locals: { search_term:, count: unpaginated_filtered_logs.size, post_path: sales_logs_email_csv_organisation_path, codes_only:, session_filters:, filter_type: "sales_logs" } + render "logs/download_csv", locals: { search_term:, count: unpaginated_filtered_logs.size, post_path: sales_logs_email_csv_organisation_path, codes_only:, session_filters:, filter_type: "sales_logs", download_csv_back_link: sales_logs_organisation_path(@organisation) } end def email_sales_csv diff --git a/app/controllers/sales_logs_controller.rb b/app/controllers/sales_logs_controller.rb index e86d841ce..ebfcc1524 100644 --- a/app/controllers/sales_logs_controller.rb +++ b/app/controllers/sales_logs_controller.rb @@ -66,7 +66,7 @@ class SalesLogsController < LogsController unpaginated_filtered_logs = filter_manager.filtered_logs(current_user.sales_logs, search_term, session_filters) - render "download_csv", locals: { search_term:, count: unpaginated_filtered_logs.size, post_path: email_csv_sales_logs_path, codes_only: codes_only_export?, session_filters:, filter_type: "sales_logs" } + render "download_csv", locals: { search_term:, count: unpaginated_filtered_logs.size, post_path: email_csv_sales_logs_path, codes_only: codes_only_export?, session_filters:, filter_type: "sales_logs", download_csv_back_link: sales_logs_path } end def email_csv diff --git a/app/helpers/filters_helper.rb b/app/helpers/filters_helper.rb index 571677f04..0fdb01d21 100644 --- a/app/helpers/filters_helper.rb +++ b/app/helpers/filters_helper.rb @@ -184,6 +184,14 @@ module FiltersHelper end end + def cancel_csv_filters_update_url(filter_type, search, codes_only, organisation_id) + if organisation_id.present? + send("#{filter_type}_csv_download_organisation_path", id: organisation_id, search:, codes_only:) + else + send("csv_download_#{filter_type}_path", search:, codes_only:) + end + end + def change_filter_for_csv_url(filter, filter_type, search_term, codes_only, organisation_id) if organisation_id.present? send("#{filter_type}_filters_#{filter[:id]}_organisation_path", organisation_id, search: search_term, codes_only:, referrer: "check_answers") diff --git a/app/views/filters/assigned_to.html.erb b/app/views/filters/assigned_to.html.erb index 8af513587..9f0582fbb 100644 --- a/app/views/filters/assigned_to.html.erb +++ b/app/views/filters/assigned_to.html.erb @@ -26,6 +26,6 @@
<%= f.govuk_submit "Save changes" %> - <%= govuk_button_link_to "Cancel", send("csv_download_#{@filter_type}_path", search: request.params["search"], codes_only: request.params["codes_only"]), secondary: true %> + <%= govuk_button_link_to "Cancel", cancel_csv_filters_update_url(@filter_type, request.params["search"], request.params["codes_only"], @organisation_id), secondary: true %>
<% end %> diff --git a/app/views/filters/managed_by.html.erb b/app/views/filters/managed_by.html.erb index 9675656ba..e3d849c9b 100644 --- a/app/views/filters/managed_by.html.erb +++ b/app/views/filters/managed_by.html.erb @@ -25,6 +25,6 @@
<%= f.govuk_submit "Save changes" %> - <%= govuk_button_link_to "Cancel", send("csv_download_#{@filter_type}_path", search: request.params["search"], codes_only: request.params["codes_only"]), secondary: true %> + <%= govuk_button_link_to "Cancel", cancel_csv_filters_update_url(@filter_type, request.params["search"], request.params["codes_only"], @organisation_id), secondary: true %>
<% end %> diff --git a/app/views/filters/needstype.html.erb b/app/views/filters/needstype.html.erb index c761acb51..35a986e9c 100644 --- a/app/views/filters/needstype.html.erb +++ b/app/views/filters/needstype.html.erb @@ -15,6 +15,6 @@
<%= f.govuk_submit "Save changes" %> - <%= govuk_button_link_to "Cancel", send("csv_download_#{@filter_type}_path", search: request.params["search"], codes_only: request.params["codes_only"]), secondary: true %> + <%= govuk_button_link_to "Cancel", cancel_csv_filters_update_url(@filter_type, request.params["search"], request.params["codes_only"], @organisation_id), secondary: true %>
<% end %> diff --git a/app/views/filters/owned_by.html.erb b/app/views/filters/owned_by.html.erb index f11b15204..7acfd459c 100644 --- a/app/views/filters/owned_by.html.erb +++ b/app/views/filters/owned_by.html.erb @@ -25,6 +25,6 @@
<%= f.govuk_submit "Save changes" %> - <%= govuk_button_link_to "Cancel", send("csv_download_#{@filter_type}_path", search: request.params["search"], codes_only: request.params["codes_only"]), secondary: true %> + <%= govuk_button_link_to "Cancel", cancel_csv_filters_update_url(@filter_type, request.params["search"], request.params["codes_only"], @organisation_id), secondary: true %>
<% end %> diff --git a/app/views/filters/status.html.erb b/app/views/filters/status.html.erb index a6664056f..a5629bfe7 100644 --- a/app/views/filters/status.html.erb +++ b/app/views/filters/status.html.erb @@ -15,6 +15,6 @@
<%= f.govuk_submit "Save changes" %> - <%= govuk_button_link_to "Cancel", send("csv_download_#{@filter_type}_path", search: request.params["search"], codes_only: request.params["codes_only"]), secondary: true %> + <%= govuk_button_link_to "Cancel", cancel_csv_filters_update_url(@filter_type, request.params["search"], request.params["codes_only"], @organisation_id), secondary: true %>
<% end %> diff --git a/app/views/filters/years.html.erb b/app/views/filters/years.html.erb index 91af95378..b81278f41 100644 --- a/app/views/filters/years.html.erb +++ b/app/views/filters/years.html.erb @@ -32,6 +32,6 @@
<%= f.govuk_submit "Save changes" %> - <%= govuk_button_link_to "Cancel", params["referrer"] == "check_answers" ? send("csv_download_#{@filter_type}_path", search: request.params["search"], codes_only: request.params["codes_only"]) : send("#{@filter_type}_path"), secondary: true %> + <%= govuk_button_link_to "Cancel", params["referrer"] == "check_answers" ? cancel_csv_filters_update_url(@filter_type, request.params["search"], request.params["codes_only"], @organisation_id) : send("#{@filter_type}_path"), secondary: true %>
<% end %> diff --git a/app/views/logs/download_csv.html.erb b/app/views/logs/download_csv.html.erb index a357d466b..6520d0386 100644 --- a/app/views/logs/download_csv.html.erb +++ b/app/views/logs/download_csv.html.erb @@ -1,7 +1,7 @@ <% content_for :title, "Download CSV" %> <% content_for :before_content do %> - <%= govuk_back_link(href: :back) %> + <%= govuk_back_link(href: download_csv_back_link) %> <% end %>