From edcaea48e5ebe95d5f9233f3dd271eac5bf31542 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Wed, 2 Oct 2024 12:09:22 +0100
Subject: [PATCH] Fix and change how we're setting the title

---
 app/helpers/bulk_upload_helper.rb             | 4 ++--
 app/views/bulk_upload_shared/uploads.html.erb | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/helpers/bulk_upload_helper.rb b/app/helpers/bulk_upload_helper.rb
index 4039c20a1..7c2fe6972 100644
--- a/app/helpers/bulk_upload_helper.rb
+++ b/app/helpers/bulk_upload_helper.rb
@@ -1,6 +1,6 @@
 module BulkUploadHelper
-  def bulk_upload_title(controller)
-    case controller.controller_name
+  def bulk_upload_title(controller_name)
+    case controller_name
     when "lettings_logs"
       "Lettings bulk uploads"
     when "sales_logs"
diff --git a/app/views/bulk_upload_shared/uploads.html.erb b/app/views/bulk_upload_shared/uploads.html.erb
index 958964ff6..958887453 100644
--- a/app/views/bulk_upload_shared/uploads.html.erb
+++ b/app/views/bulk_upload_shared/uploads.html.erb
@@ -1,10 +1,10 @@
 <% item_label = format_label(@pagy.count, "uploads") %>
-<% title = format_title(@searched, "Lettings bulk uploads", current_user, item_label, @pagy.count, nil) %>
+<% title = format_title(@searched, bulk_upload_title(controller.controller_name), current_user, item_label, @pagy.count, nil) %>
 
 <% content_for :title, title %>
 
 <h1 class="govuk-heading-l govuk-!-margin-bottom-7">
-  <%= bulk_upload_title(controller) %>
+  <%= bulk_upload_title(controller.controller_name) %>
 </h1>
 
 <div class="app-filter-layout" data-controller="filter-layout">