Browse Source

Clear mortgage if it's 0

pull/1472/head
Kat 3 years ago
parent
commit
e9ff793de5
  1. 2
      app/models/validations/sales/financial_validations.rb
  2. 5
      app/services/imports/sales_logs_import_service.rb
  3. 24
      spec/services/imports/sales_logs_import_service_spec.rb

2
app/models/validations/sales/financial_validations.rb

@ -37,7 +37,7 @@ module Validations::Sales::FinancialValidations
end
def validate_mortgage(record)
record.errors.add :mortgage, I18n.t("validations.financial.mortgage") if record.mortgage_used? && record.mortgage&.zero?
record.errors.add :mortgage, :cannot_be_0, message: I18n.t("validations.financial.mortgage") if record.mortgage_used? && record.mortgage&.zero?
end
def validate_cash_discount(record)

5
app/services/imports/sales_logs_import_service.rb

@ -225,6 +225,11 @@ module Imports
attributes.delete("postcode_full")
attributes["pcodenk"] = attributes["la"].present? ? 1 : nil
save_sales_log(attributes, previous_status)
elsif sales_log.errors.of_kind?(:mortgage, :cannot_be_0)
@logger.warn("Log #{sales_log.old_id}: Removing mortgage because it cannot be 0")
@logs_overridden << sales_log.old_id
attributes.delete("mortgage")
save_sales_log(attributes, previous_status)
else
@logger.error("Log #{sales_log.old_id}: Failed to import")
sales_log.errors.each do |error|

24
spec/services/imports/sales_logs_import_service_spec.rb

@ -637,6 +637,30 @@ RSpec.describe Imports::SalesLogsImportService do
end
end
context "when mortgage value is 0" do
let(:sales_log_id) { "shared_ownership_sales_log" }
before do
sales_log_xml.at_xpath("//xmlns:CALCMORT").content = "0"
end
it "intercepts the relevant validation error" do
expect(logger).to receive(:warn).with(/Removing mortgage because it cannot be 0/)
expect { sales_log_service.send(:create_log, sales_log_xml) }
.not_to raise_error
end
it "clears out the referral answer" do
allow(logger).to receive(:warn)
sales_log_service.send(:create_log, sales_log_xml)
sales_log = SalesLog.find_by(old_id: sales_log_id)
expect(sales_log).not_to be_nil
expect(sales_log.mortgage).to be_nil
end
end
context "and it has an invalid income" do
let(:sales_log_id) { "shared_ownership_sales_log" }

Loading…
Cancel
Save