From e790e4af63eddb1ad3e633625719f012a6dd35f1 Mon Sep 17 00:00:00 2001 From: Kat Date: Wed, 9 Oct 2024 11:01:09 +0100 Subject: [PATCH] Update tests --- spec/features/accessibility_spec.rb | 2 +- spec/features/lettings_log_spec.rb | 2 +- spec/features/notifications_spec.rb | 2 +- spec/features/organisation_spec.rb | 2 +- spec/features/start_page_spec.rb | 2 +- spec/features/test_spec.rb | 2 +- spec/features/user_spec.rb | 2 +- spec/helpers/collection_resources_helper_spec.rb | 2 +- spec/requests/auth/passwords_controller_spec.rb | 2 +- spec/requests/maintenance_controller_spec.rb | 2 +- spec/requests/rails_admin_controller_spec.rb | 2 +- spec/requests/start_controller_spec.rb | 2 +- spec/requests/users_controller_spec.rb | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/spec/features/accessibility_spec.rb b/spec/features/accessibility_spec.rb index 6f950cffc..2a95b684e 100644 --- a/spec/features/accessibility_spec.rb +++ b/spec/features/accessibility_spec.rb @@ -3,7 +3,7 @@ require "rails_helper" RSpec.describe "Accessibility", js: true do let(:user) { create(:user, :support) } let!(:other_user) { create(:user, name: "new user", organisation: user.organisation, email: "new_user@example.com", confirmation_token: "abc") } - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } def find_routes(type, resource, subresource) routes = Rails.application.routes.routes.select do |route| diff --git a/spec/features/lettings_log_spec.rb b/spec/features/lettings_log_spec.rb index b1d6f8dae..ea250529d 100644 --- a/spec/features/lettings_log_spec.rb +++ b/spec/features/lettings_log_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" RSpec.describe "Lettings Log Features" do - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(Storage::S3Service).to receive(:new).and_return(storage_service) diff --git a/spec/features/notifications_spec.rb b/spec/features/notifications_spec.rb index 360569dbb..a542cc97f 100644 --- a/spec/features/notifications_spec.rb +++ b/spec/features/notifications_spec.rb @@ -3,7 +3,7 @@ require_relative "form/helpers" RSpec.describe "Notifications Features" do include Helpers - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(Storage::S3Service).to receive(:new).and_return(storage_service) diff --git a/spec/features/organisation_spec.rb b/spec/features/organisation_spec.rb index 1e3f89b72..98ae86475 100644 --- a/spec/features/organisation_spec.rb +++ b/spec/features/organisation_spec.rb @@ -10,7 +10,7 @@ RSpec.describe "User Features" do let(:notify_client) { instance_double(Notifications::Client) } let(:confirmation_token) { "MCDH5y6Km-U7CFPgAMVS" } let(:devise_notify_mailer) { DeviseNotifyMailer.new } - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(Storage::S3Service).to receive(:new).and_return(storage_service) diff --git a/spec/features/start_page_spec.rb b/spec/features/start_page_spec.rb index 3f1102869..555db9238 100644 --- a/spec/features/start_page_spec.rb +++ b/spec/features/start_page_spec.rb @@ -4,7 +4,7 @@ require_relative "form/helpers" RSpec.describe "Start Page Features" do include Helpers let(:user) { FactoryBot.create(:user) } - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(Storage::S3Service).to receive(:new).and_return(storage_service) diff --git a/spec/features/test_spec.rb b/spec/features/test_spec.rb index 7ea2eebc9..a58867182 100644 --- a/spec/features/test_spec.rb +++ b/spec/features/test_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" RSpec.describe "Test Features" do - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(Storage::S3Service).to receive(:new).and_return(storage_service) diff --git a/spec/features/user_spec.rb b/spec/features/user_spec.rb index a2680fb95..bc562824c 100644 --- a/spec/features/user_spec.rb +++ b/spec/features/user_spec.rb @@ -6,7 +6,7 @@ RSpec.describe "User Features" do let(:notify_client) { instance_double(Notifications::Client) } let(:reset_password_token) { "MCDH5y6Km-U7CFPgAMVS" } let(:devise_notify_mailer) { DeviseNotifyMailer.new } - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(DeviseNotifyMailer).to receive(:new).and_return(devise_notify_mailer) diff --git a/spec/helpers/collection_resources_helper_spec.rb b/spec/helpers/collection_resources_helper_spec.rb index 5a07dcb66..7b3d190a1 100644 --- a/spec/helpers/collection_resources_helper_spec.rb +++ b/spec/helpers/collection_resources_helper_spec.rb @@ -3,7 +3,7 @@ require "rails_helper" RSpec.describe CollectionResourcesHelper do let(:current_user) { create(:user, :data_coordinator) } let(:user) { create(:user, :data_coordinator) } - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(Storage::S3Service).to receive(:new).and_return(storage_service) diff --git a/spec/requests/auth/passwords_controller_spec.rb b/spec/requests/auth/passwords_controller_spec.rb index 544dedab5..7f9bdfa30 100644 --- a/spec/requests/auth/passwords_controller_spec.rb +++ b/spec/requests/auth/passwords_controller_spec.rb @@ -5,7 +5,7 @@ RSpec.describe Auth::PasswordsController, type: :request do let(:page) { Capybara::Node::Simple.new(response.body) } let(:notify_client) { instance_double(Notifications::Client) } let(:devise_notify_mailer) { DeviseNotifyMailer.new } - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(DeviseNotifyMailer).to receive(:new).and_return(devise_notify_mailer) diff --git a/spec/requests/maintenance_controller_spec.rb b/spec/requests/maintenance_controller_spec.rb index fa5b47fd0..28287dbc0 100644 --- a/spec/requests/maintenance_controller_spec.rb +++ b/spec/requests/maintenance_controller_spec.rb @@ -3,7 +3,7 @@ require "rails_helper" RSpec.describe MaintenanceController, type: :request do let(:page) { Capybara::Node::Simple.new(response.body) } let(:user) { FactoryBot.create(:user) } - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(Storage::S3Service).to receive(:new).and_return(storage_service) diff --git a/spec/requests/rails_admin_controller_spec.rb b/spec/requests/rails_admin_controller_spec.rb index 3f83896d0..79f56d18f 100644 --- a/spec/requests/rails_admin_controller_spec.rb +++ b/spec/requests/rails_admin_controller_spec.rb @@ -4,7 +4,7 @@ RSpec.describe "RailsAdmin", type: :request do let(:user) { create(:user) } let(:support_user) { create(:user, :support) } let(:page) { Capybara::Node::Simple.new(response.body) } - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(support_user).to receive(:need_two_factor_authentication?).and_return(false) diff --git a/spec/requests/start_controller_spec.rb b/spec/requests/start_controller_spec.rb index 77c8e27f8..40c45a9f9 100644 --- a/spec/requests/start_controller_spec.rb +++ b/spec/requests/start_controller_spec.rb @@ -5,7 +5,7 @@ RSpec.describe StartController, type: :request do let(:page) { Capybara::Node::Simple.new(response.body) } let(:notify_client) { instance_double(Notifications::Client) } let(:devise_notify_mailer) { DeviseNotifyMailer.new } - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(DeviseNotifyMailer).to receive(:new).and_return(devise_notify_mailer) diff --git a/spec/requests/users_controller_spec.rb b/spec/requests/users_controller_spec.rb index 95239b658..05dc06d5b 100644 --- a/spec/requests/users_controller_spec.rb +++ b/spec/requests/users_controller_spec.rb @@ -10,7 +10,7 @@ RSpec.describe UsersController, type: :request do let(:params) { { id: user.id, user: { name: new_name } } } let(:notify_client) { instance_double(Notifications::Client) } let(:devise_notify_mailer) { DeviseNotifyMailer.new } - let(:storage_service) { instance_double(Storage::S3Service) } + let(:storage_service) { instance_double(Storage::S3Service, get_file_metadata: nil) } before do allow(DeviseNotifyMailer).to receive(:new).and_return(devise_notify_mailer)