From e778c09e4c5e0c90cbe920f688b714ea3769d52c Mon Sep 17 00:00:00 2001 From: Sam Seed Date: Tue, 25 Apr 2023 12:31:02 +0100 Subject: [PATCH] test: ensure row as a whole is not blank in 'blank field' tests --- .../lettings/year2022/row_parser_spec.rb | 12 ++++++------ .../lettings/year2023/row_parser_spec.rb | 16 ++++++++-------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb index bd78e469b..43a4ad822 100644 --- a/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb @@ -775,7 +775,7 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do describe "#field_112" do # username for created_by context "when blank" do - let(:attributes) { { bulk_upload:, field_112: "" } } + let(:attributes) { { bulk_upload:, field_112: "", field_4: 1 } } it "is permitted" do expect(parser.errors[:field_112]).to be_blank @@ -827,7 +827,7 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do describe "#field_113" do # managing org context "when blank" do - let(:attributes) { { bulk_upload:, field_113: "" } } + let(:attributes) { { bulk_upload:, field_113: "", field_4: 1 } } it "is not permitted as setup error" do setup_errors = parser.errors.select { |e| e.options[:category] == :setup } @@ -919,7 +919,7 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do ].each do |known, age, field| describe "##{known} and ##{age}" do context "when #{field} is blank" do - let(:attributes) { { bulk_upload:, field.to_s => nil } } + let(:attributes) { { bulk_upload:, field.to_s => nil, field_4: 1 } } it "sets ##{known} 1" do expect(parser.log.public_send(known)).to be(1) @@ -1234,7 +1234,7 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do end context "when no" do - let(:attributes) { { bulk_upload:, hash[:field] => "" } } + let(:attributes) { { bulk_upload:, hash[:field] => "", field_4: 1 } } it "sets value from correct mapping" do expect(parser.log.public_send(hash[:attribute])).to be_nil @@ -1384,7 +1384,7 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do end context "when mrcdate not given" do - let(:attributes) { { bulk_upload:, field_92: "", field_93: "", field_94: "" } } + let(:attributes) { { bulk_upload:, field_92: "", field_93: "", field_94: "", field_4: 1 } } it "sets #majorrepairs to 0" do expect(parser.log.majorrepairs).to eq(0) @@ -1452,7 +1452,7 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do end context "when not known" do - let(:attributes) { { bulk_upload:, field_62: "" } } + let(:attributes) { { bulk_upload:, field_62: "", field_4: 1 } } it "sets to 0" do expect(parser.log.previous_la_known).to eq(0) diff --git a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb index ed83bafc5..17d6aa50f 100644 --- a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb @@ -273,7 +273,7 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do describe "#field_3" do # created_by context "when blank" do - let(:attributes) { { bulk_upload:, field_3: "" } } + let(:attributes) { { bulk_upload:, field_3: "", field_4: 1 } } it "is permitted" do expect(parser.errors[:field_3]).to be_blank @@ -695,7 +695,7 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do describe "#field_1" do # owning org context "when blank" do - let(:attributes) { { bulk_upload:, field_1: "" } } + let(:attributes) { { bulk_upload:, field_1: "", field_4: 1 } } it "is not permitted as setup error" do setup_errors = parser.errors.select { |e| e.options[:category] == :setup } @@ -757,7 +757,7 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do describe "#field_2" do # managing org context "when blank" do - let(:attributes) { { bulk_upload:, field_2: "" } } + let(:attributes) { { bulk_upload:, field_2: "", field_4: 1 } } it "is not permitted as setup error" do setup_errors = parser.errors.select { |e| e.options[:category] == :setup } @@ -951,7 +951,7 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do end context "when uprn blank" do - let(:attributes) { { bulk_upload:, field_18: "" } } + let(:attributes) { { bulk_upload:, field_18: "", field_4: 1 } } it "sets to 0" do expect(parser.log.uprn_known).to be(0) @@ -1003,7 +1003,7 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do ].each do |known, age, field| describe "##{known} and ##{age}" do context "when #{field} is blank" do - let(:attributes) { { bulk_upload:, field.to_s => nil } } + let(:attributes) { { bulk_upload:, field.to_s => nil, field_4: 1 } } it "sets ##{known} 1" do expect(parser.log.public_send(known)).to be(1) @@ -1298,7 +1298,7 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do end context "when no" do - let(:attributes) { { bulk_upload:, hash[:field] => "" } } + let(:attributes) { { bulk_upload:, hash[:field] => "", field_4: 1 } } it "sets value from correct mapping" do expect(parser.log.public_send(hash[:attribute])).to be_nil @@ -1448,7 +1448,7 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do end context "when mrcdate not given" do - let(:attributes) { { bulk_upload:, field_36: "", field_37: "", field_38: "" } } + let(:attributes) { { bulk_upload:, field_36: "", field_37: "", field_38: "", field_4: 1 } } it "sets #majorrepairs to 0" do expect(parser.log.majorrepairs).to eq(0) @@ -1516,7 +1516,7 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do end context "when not known" do - let(:attributes) { { bulk_upload:, field_109: "" } } + let(:attributes) { { bulk_upload:, field_109: "", field_4: 1 } } it "sets to 0" do expect(parser.log.previous_la_known).to eq(0)