From e7043c4e292ec2d59e078185060c1e550efff21e Mon Sep 17 00:00:00 2001
From: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
Date: Mon, 5 Jun 2023 11:46:30 +0100
Subject: [PATCH] feat: add tests

---
 .../lettings/year2022/csv_parser_spec.rb      | 18 +++++++++++++++
 .../lettings/year2023/csv_parser_spec.rb      | 18 +++++++++++++++
 .../sales/year2022/csv_parser_spec.rb         | 22 +++++++++++++++++++
 .../sales/year2023/csv_parser_spec.rb         | 18 +++++++++++++++
 4 files changed, 76 insertions(+)

diff --git a/spec/services/bulk_upload/lettings/year2022/csv_parser_spec.rb b/spec/services/bulk_upload/lettings/year2022/csv_parser_spec.rb
index f2b9dda6a..315bba727 100644
--- a/spec/services/bulk_upload/lettings/year2022/csv_parser_spec.rb
+++ b/spec/services/bulk_upload/lettings/year2022/csv_parser_spec.rb
@@ -169,4 +169,22 @@ RSpec.describe BulkUpload::Lettings::Year2022::CsvParser do
       end
     end
   end
+
+  context "when parsing csv with carriage returns" do
+    before do
+      file.write("Question\r\n")
+      file.write("Additional info\r\r")
+      file.write("Values\r")
+      file.write("Can be empty?\n")
+      file.write("Type of letting the question applies to\r\n")
+      file.write("Duplicate check field?\r\r")
+      file.write(BulkUpload::LettingsLogToCsv.new(log:).default_2022_field_numbers_row)
+      file.write(BulkUpload::LettingsLogToCsv.new(log:).to_2022_csv_row)
+      file.rewind
+    end
+
+    it "parses csv correctly" do
+      expect(service.row_parsers[0].field_12.to_i).to eq(35)
+    end
+  end
 end
diff --git a/spec/services/bulk_upload/lettings/year2023/csv_parser_spec.rb b/spec/services/bulk_upload/lettings/year2023/csv_parser_spec.rb
index 936cf1103..6d2842b15 100644
--- a/spec/services/bulk_upload/lettings/year2023/csv_parser_spec.rb
+++ b/spec/services/bulk_upload/lettings/year2023/csv_parser_spec.rb
@@ -150,6 +150,24 @@ RSpec.describe BulkUpload::Lettings::Year2023::CsvParser do
     end
   end
 
+  context "when parsing csv with carriage returns" do
+    before do
+      file.write("Question\r\n")
+      file.write("Additional info\r\r")
+      file.write("Values\r")
+      file.write("Can be empty?\n")
+      file.write("Type of letting the question applies to\r\n")
+      file.write("Duplicate check field?\r\r")
+      file.write(BulkUpload::LettingsLogToCsv.new(log:).default_2023_field_numbers_row)
+      file.write(BulkUpload::LettingsLogToCsv.new(log:).to_2023_csv_row)
+      file.rewind
+    end
+
+    it "parses csv correctly" do
+      expect(service.row_parsers[0].field_13).to eql(log.tenancycode)
+    end
+  end
+
   describe "#column_for_field", aggregate_failures: true do
     context "when with headers using default ordering" do
       before do
diff --git a/spec/services/bulk_upload/sales/year2022/csv_parser_spec.rb b/spec/services/bulk_upload/sales/year2022/csv_parser_spec.rb
index 2d65075b5..1a1791f70 100644
--- a/spec/services/bulk_upload/sales/year2022/csv_parser_spec.rb
+++ b/spec/services/bulk_upload/sales/year2022/csv_parser_spec.rb
@@ -94,4 +94,26 @@ RSpec.describe BulkUpload::Sales::Year2022::CsvParser do
       end
     end
   end
+
+  context "when parsing csv with carriage returns" do
+    let(:file) { Tempfile.new }
+    let(:path) { file.path }
+    let(:log) { build(:sales_log, :completed) }
+
+    before do
+      file.write("Question\r\n")
+      file.write("Additional info\r\r")
+      file.write("Values\r")
+      file.write("Can be empty?\n")
+      file.write("Type of letting the question applies to\r\n")
+      file.write("Duplicate check field?\r\r")
+      file.write(BulkUpload::SalesLogToCsv.new(log:).to_2022_csv_row)
+      file.rewind
+    end
+
+    it "parses csv correctly" do
+      expect(service.column_for_field("field_1")).to eql("A")
+      expect(service.column_for_field("field_125")).to eql("DU")
+    end
+  end
 end
diff --git a/spec/services/bulk_upload/sales/year2023/csv_parser_spec.rb b/spec/services/bulk_upload/sales/year2023/csv_parser_spec.rb
index 54af60e3d..f90b434f1 100644
--- a/spec/services/bulk_upload/sales/year2023/csv_parser_spec.rb
+++ b/spec/services/bulk_upload/sales/year2023/csv_parser_spec.rb
@@ -145,4 +145,22 @@ RSpec.describe BulkUpload::Sales::Year2023::CsvParser do
       end
     end
   end
+
+  context "when parsing csv with carriage returns" do
+    before do
+      file.write("Question\r\n")
+      file.write("Additional info\r\r")
+      file.write("Values\r")
+      file.write("Can be empty?\n")
+      file.write("Type of letting the question applies to\r\n")
+      file.write("Duplicate check field?\r\r")
+      file.write(BulkUpload::SalesLogToCsv.new(log:).default_2023_field_numbers_row)
+      file.write(BulkUpload::SalesLogToCsv.new(log:).to_2023_csv_row)
+      file.rewind
+    end
+
+    it "parses csv correctly" do
+      expect(service.row_parsers[0].field_19).to eql(log.uprn)
+    end
+  end
 end