diff --git a/spec/models/form/lettings/pages/address_matcher_spec.rb b/spec/models/form/lettings/pages/address_matcher_spec.rb index 8cc98f480..16f571754 100644 --- a/spec/models/form/lettings/pages/address_matcher_spec.rb +++ b/spec/models/form/lettings/pages/address_matcher_spec.rb @@ -6,7 +6,7 @@ RSpec.describe Form::Lettings::Pages::AddressMatcher, type: :model do let(:page_id) { nil } let(:page_definition) { nil } let(:subsection) { instance_double(Form::Subsection) } - let(:log) { create(:lettings_log) } + let(:log) { build(:lettings_log) } it "has correct subsection" do expect(page.subsection).to eq(subsection) diff --git a/spec/models/form/lettings/pages/uprn_selection_spec.rb b/spec/models/form/lettings/pages/uprn_selection_spec.rb index 5cbb08e93..a2e8086d0 100644 --- a/spec/models/form/lettings/pages/uprn_selection_spec.rb +++ b/spec/models/form/lettings/pages/uprn_selection_spec.rb @@ -6,7 +6,7 @@ RSpec.describe Form::Lettings::Pages::UprnSelection, type: :model do let(:page_id) { nil } let(:page_definition) { nil } let(:subsection) { instance_double(Form::Subsection) } - let(:log) { create(:lettings_log) } + let(:log) { build(:lettings_log) } it "has correct subsection" do expect(page.subsection).to eq(subsection) diff --git a/spec/models/form/lettings/pages/uprn_spec.rb b/spec/models/form/lettings/pages/uprn_spec.rb index 089daf4bc..c41de5f6a 100644 --- a/spec/models/form/lettings/pages/uprn_spec.rb +++ b/spec/models/form/lettings/pages/uprn_spec.rb @@ -45,7 +45,7 @@ RSpec.describe Form::Lettings::Pages::Uprn, type: :model do end context "when log is present" do - let(:log) { create(:lettings_log) } + let(:log) { build(:lettings_log) } context "with 2023/24 form" do it "points to address page" do diff --git a/spec/models/form/lettings/questions/property_reference_spec.rb b/spec/models/form/lettings/questions/property_reference_spec.rb index 2f0c21b75..970bead96 100644 --- a/spec/models/form/lettings/questions/property_reference_spec.rb +++ b/spec/models/form/lettings/questions/property_reference_spec.rb @@ -6,7 +6,7 @@ RSpec.describe Form::Lettings::Questions::PropertyReference, type: :model do let(:question_id) { nil } let(:question_definition) { nil } let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) } - let(:lettings_log) { FactoryBot.create(:lettings_log) } + let(:lettings_log) { FactoryBot.build(:lettings_log) } it "has correct page" do expect(question.page).to eq(page) diff --git a/spec/models/form/lettings/questions/uprn_confirmation_spec.rb b/spec/models/form/lettings/questions/uprn_confirmation_spec.rb index ee0235c54..c0b6ef8a4 100644 --- a/spec/models/form/lettings/questions/uprn_confirmation_spec.rb +++ b/spec/models/form/lettings/questions/uprn_confirmation_spec.rb @@ -42,7 +42,7 @@ RSpec.describe Form::Lettings::Questions::UprnConfirmation, type: :model do describe "notification_banner" do context "when address is not present" do it "returns nil" do - log = create(:lettings_log) + log = build(:lettings_log) expect(question.notification_banner(log)).to be_nil end @@ -50,7 +50,7 @@ RSpec.describe Form::Lettings::Questions::UprnConfirmation, type: :model do context "when address is present" do it "returns formatted value" do - log = create(:lettings_log, :setup_completed, address_line1: "1, Test Street", town_or_city: "Test Town", postcode_full: "AA1 1AA", uprn: "1", uprn_known: 1) + log = build(:lettings_log, :setup_completed, address_line1: "1, Test Street", town_or_city: "Test Town", postcode_full: "AA1 1AA", uprn: "1", uprn_known: 1) expect(question.notification_banner(log)).to eq( { @@ -64,7 +64,7 @@ RSpec.describe Form::Lettings::Questions::UprnConfirmation, type: :model do describe "has the correct hidden_in_check_answers" do context "when uprn_known != 1 && uprn_confirmed == nil" do - let(:log) { create(:lettings_log, uprn_known: 0, uprn_confirmed: nil) } + let(:log) { build(:lettings_log, uprn_known: 0, uprn_confirmed: nil) } it "returns true" do expect(question.hidden_in_check_answers?(log)).to eq(true) @@ -72,7 +72,7 @@ RSpec.describe Form::Lettings::Questions::UprnConfirmation, type: :model do end context "when uprn_known == 1 && uprn_confirmed == nil" do - let(:log) { create(:lettings_log, :completed, uprn_known: 1, uprn: 1, uprn_confirmed: nil) } + let(:log) { build(:lettings_log, :completed, uprn_known: 1, uprn: 1, uprn_confirmed: nil) } it "returns false" do expect(question.hidden_in_check_answers?(log)).to eq(false) @@ -80,7 +80,7 @@ RSpec.describe Form::Lettings::Questions::UprnConfirmation, type: :model do end context "when uprn_known != 1 && uprn_confirmed == 1" do - let(:log) { create(:lettings_log) } + let(:log) { build(:lettings_log) } it "returns true" do log.uprn_known = 1 diff --git a/spec/models/form/sales/pages/address_matcher_spec.rb b/spec/models/form/sales/pages/address_matcher_spec.rb index e2eea6fa0..6d6a4174f 100644 --- a/spec/models/form/sales/pages/address_matcher_spec.rb +++ b/spec/models/form/sales/pages/address_matcher_spec.rb @@ -6,7 +6,7 @@ RSpec.describe Form::Sales::Pages::AddressMatcher, type: :model do let(:page_id) { nil } let(:page_definition) { nil } let(:subsection) { instance_double(Form::Subsection) } - let(:log) { create(:sales_log) } + let(:log) { build(:sales_log) } it "has correct subsection" do expect(page.subsection).to eq(subsection) diff --git a/spec/models/form/sales/pages/uprn_confirmation_spec.rb b/spec/models/form/sales/pages/uprn_confirmation_spec.rb index a09cb2f08..bd52233b6 100644 --- a/spec/models/form/sales/pages/uprn_confirmation_spec.rb +++ b/spec/models/form/sales/pages/uprn_confirmation_spec.rb @@ -33,7 +33,7 @@ RSpec.describe Form::Sales::Pages::UprnConfirmation, type: :model do describe "has correct routed_to?" do context "when uprn present && uprn_known == 1 " do - let(:log) { create(:sales_log) } + let(:log) { build(:sales_log) } it "returns true" do log.uprn_known = 1 @@ -43,7 +43,7 @@ RSpec.describe Form::Sales::Pages::UprnConfirmation, type: :model do end context "when uprn = nil" do - let(:log) { create(:sales_log, uprn_known: 1, uprn: nil) } + let(:log) { build(:sales_log, uprn_known: 1, uprn: nil) } it "returns false" do expect(page.routed_to?(log)).to eq(false) @@ -51,7 +51,7 @@ RSpec.describe Form::Sales::Pages::UprnConfirmation, type: :model do end context "when uprn_known == 0" do - let(:log) { create(:sales_log, uprn_known: 0, uprn: "123456789") } + let(:log) { build(:sales_log, uprn_known: 0, uprn: "123456789") } it "returns false" do expect(page.routed_to?(log)).to eq(false) diff --git a/spec/models/form/sales/pages/uprn_selection_spec.rb b/spec/models/form/sales/pages/uprn_selection_spec.rb index 6013774d3..2e3f3e8f6 100644 --- a/spec/models/form/sales/pages/uprn_selection_spec.rb +++ b/spec/models/form/sales/pages/uprn_selection_spec.rb @@ -6,7 +6,7 @@ RSpec.describe Form::Sales::Pages::UprnSelection, type: :model do let(:page_id) { nil } let(:page_definition) { nil } let(:subsection) { instance_double(Form::Subsection) } - let(:log) { create(:sales_log) } + let(:log) { build(:sales_log) } it "has correct subsection" do expect(page.subsection).to eq(subsection) diff --git a/spec/models/form/sales/pages/uprn_spec.rb b/spec/models/form/sales/pages/uprn_spec.rb index ef1c9848f..8511af372 100644 --- a/spec/models/form/sales/pages/uprn_spec.rb +++ b/spec/models/form/sales/pages/uprn_spec.rb @@ -45,7 +45,7 @@ RSpec.describe Form::Sales::Pages::Uprn, type: :model do end context "when log is present" do - let(:log) { create(:sales_log) } + let(:log) { build(:sales_log) } context "with 2023/24 form" do it "points to address page" do diff --git a/spec/models/form/sales/questions/address_line1_for_address_matcher_spec.rb b/spec/models/form/sales/questions/address_line1_for_address_matcher_spec.rb index 213fddaf3..0272d1329 100644 --- a/spec/models/form/sales/questions/address_line1_for_address_matcher_spec.rb +++ b/spec/models/form/sales/questions/address_line1_for_address_matcher_spec.rb @@ -6,7 +6,7 @@ RSpec.describe Form::Sales::Questions::AddressLine1ForAddressMatcher, type: :mod let(:question_id) { nil } let(:question_definition) { nil } let(:page) { instance_double(Form::Page) } - let(:log) { create(:sales_log, :in_progress, address_line1_input: "Address line 1", postcode_full_input: "AA1 1AA") } + let(:log) { build(:sales_log, :in_progress, address_line1_input: "Address line 1", postcode_full_input: "AA1 1AA") } it "has correct page" do expect(question.page).to eq(page) diff --git a/spec/models/form/sales/questions/buyer1_mortgage_spec.rb b/spec/models/form/sales/questions/buyer1_mortgage_spec.rb index 94d78eafa..a0790c7f8 100644 --- a/spec/models/form/sales/questions/buyer1_mortgage_spec.rb +++ b/spec/models/form/sales/questions/buyer1_mortgage_spec.rb @@ -6,7 +6,7 @@ RSpec.describe Form::Sales::Questions::Buyer1Mortgage, type: :model do let(:question_id) { nil } let(:question_definition) { nil } let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) } - let(:log) { create(:sales_log) } + let(:log) { build(:sales_log) } it "has correct page" do expect(question.page).to eq(page) diff --git a/spec/models/form/sales/questions/buyer2_mortgage_spec.rb b/spec/models/form/sales/questions/buyer2_mortgage_spec.rb index 6b297423c..d96f094e2 100644 --- a/spec/models/form/sales/questions/buyer2_mortgage_spec.rb +++ b/spec/models/form/sales/questions/buyer2_mortgage_spec.rb @@ -6,7 +6,7 @@ RSpec.describe Form::Sales::Questions::Buyer2Mortgage, type: :model do let(:question_id) { nil } let(:question_definition) { nil } let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) } - let(:log) { create(:sales_log) } + let(:log) { build(:sales_log) } it "has correct page" do expect(question.page).to eq(page) diff --git a/spec/models/form/sales/questions/buyers_organisations_spec.rb b/spec/models/form/sales/questions/buyers_organisations_spec.rb index 0c28cff6f..c997c5883 100644 --- a/spec/models/form/sales/questions/buyers_organisations_spec.rb +++ b/spec/models/form/sales/questions/buyers_organisations_spec.rb @@ -48,7 +48,7 @@ RSpec.describe Form::Sales::Questions::BuyersOrganisations, type: :model do end it "has the correct displayed answer_options" do - expect(question.displayed_answer_options(FactoryBot.create(:sales_log))).to eq( + expect(question.displayed_answer_options(FactoryBot.build(:sales_log))).to eq( { "pregyrha" => { "value" => "Their private registered provider (PRP) - housing association" }, "pregother" => { "value" => "Other private registered provider (PRP) - housing association" }, diff --git a/spec/models/form/sales/questions/deposit_amount_spec.rb b/spec/models/form/sales/questions/deposit_amount_spec.rb index cb32a7ee1..22119a733 100644 --- a/spec/models/form/sales/questions/deposit_amount_spec.rb +++ b/spec/models/form/sales/questions/deposit_amount_spec.rb @@ -28,7 +28,7 @@ RSpec.describe Form::Sales::Questions::DepositAmount, type: :model do end context "when the ownership type is shared" do - let(:log) { create(:sales_log, :completed, ownershipsch: 1, mortgageused: 2) } + let(:log) { build(:sales_log, :completed, ownershipsch: 1, mortgageused: 2) } it "is not marked as derived" do expect(question.derived?(log)).to be false @@ -36,7 +36,7 @@ RSpec.describe Form::Sales::Questions::DepositAmount, type: :model do end context "when the ownership type is discounted for 2023" do - let(:log) { create(:sales_log, :completed, ownershipsch: 2, mortgageused: 2, saledate: Time.zone.local(2024, 3, 1)) } + let(:log) { build(:sales_log, :completed, ownershipsch: 2, mortgageused: 2, saledate: Time.zone.local(2024, 3, 1)) } it "is not marked as derived" do expect(question.derived?(log)).to be false @@ -44,7 +44,7 @@ RSpec.describe Form::Sales::Questions::DepositAmount, type: :model do end context "when the ownership type is outright" do - let(:log) { create(:sales_log, :completed, ownershipsch: 3, mortgageused: 2) } + let(:log) { build(:sales_log, :completed, ownershipsch: 3, mortgageused: 2) } it "is not marked as derived when a mortgage is used" do log.mortgageused = 1 diff --git a/spec/models/form/sales/questions/postcode_for_address_matcher_spec.rb b/spec/models/form/sales/questions/postcode_for_address_matcher_spec.rb index e2a2931a9..5ba7e8505 100644 --- a/spec/models/form/sales/questions/postcode_for_address_matcher_spec.rb +++ b/spec/models/form/sales/questions/postcode_for_address_matcher_spec.rb @@ -6,7 +6,7 @@ RSpec.describe Form::Sales::Questions::PostcodeForAddressMatcher, type: :model d let(:question_id) { nil } let(:question_definition) { nil } let(:page) { instance_double(Form::Page) } - let(:log) { create(:sales_log, :in_progress, address_line1_input: "Address line 1", postcode_full_input: "AA1 1AA") } + let(:log) { build(:sales_log, :in_progress, address_line1_input: "Address line 1", postcode_full_input: "AA1 1AA") } it "has correct page" do expect(question.page).to eq(page) diff --git a/spec/models/form/sales/questions/uprn_confirmation_spec.rb b/spec/models/form/sales/questions/uprn_confirmation_spec.rb index b6e9195e0..bb5688944 100644 --- a/spec/models/form/sales/questions/uprn_confirmation_spec.rb +++ b/spec/models/form/sales/questions/uprn_confirmation_spec.rb @@ -42,7 +42,7 @@ RSpec.describe Form::Sales::Questions::UprnConfirmation, type: :model do describe "notification_banner" do context "when address is not present" do it "returns nil" do - log = create(:sales_log) + log = build(:sales_log) expect(question.notification_banner(log)).to be_nil end @@ -64,7 +64,7 @@ RSpec.describe Form::Sales::Questions::UprnConfirmation, type: :model do describe "has the correct hidden_in_check_answers" do context "when uprn_known != 1 && uprn_confirmed == nil" do - let(:log) { create(:sales_log, uprn_known: 0, uprn_confirmed: nil) } + let(:log) { build(:sales_log, uprn_known: 0, uprn_confirmed: nil) } it "returns true" do expect(question.hidden_in_check_answers?(log)).to eq(true) @@ -72,7 +72,7 @@ RSpec.describe Form::Sales::Questions::UprnConfirmation, type: :model do end context "when uprn_known == 1 && uprn_confirmed == nil" do - let(:log) { create(:sales_log) } + let(:log) { build(:sales_log) } it "returns false" do log.uprn_known = 1 @@ -83,7 +83,7 @@ RSpec.describe Form::Sales::Questions::UprnConfirmation, type: :model do end context "when uprn_known != 1 && uprn_confirmed == 1" do - let(:log) { create(:sales_log, uprn_known: 1, uprn: "12345", uprn_confirmed: 1) } + let(:log) { build(:sales_log, uprn_known: 1, uprn: "12345", uprn_confirmed: 1) } it "returns true" do expect(question.hidden_in_check_answers?(log)).to eq(true) diff --git a/spec/models/form/sales/questions/uprn_selection_spec.rb b/spec/models/form/sales/questions/uprn_selection_spec.rb index 5f7951c3d..cd23a8e9f 100644 --- a/spec/models/form/sales/questions/uprn_selection_spec.rb +++ b/spec/models/form/sales/questions/uprn_selection_spec.rb @@ -6,7 +6,7 @@ RSpec.describe Form::Sales::Questions::UprnSelection, type: :model do let(:question_id) { nil } let(:question_definition) { nil } let(:page) { instance_double(Form::Page, skip_href: "skip_href") } - let(:log) { create(:sales_log, :in_progress, address_line1_input: "Address line 1", postcode_full_input: "AA1 1AA") } + let(:log) { build(:sales_log, :in_progress, address_line1_input: "Address line 1", postcode_full_input: "AA1 1AA") } let(:address_client_instance) { AddressClient.new(log.address_string) } before do diff --git a/spec/models/form/sales/questions/uprn_spec.rb b/spec/models/form/sales/questions/uprn_spec.rb index fc0c5caa7..afc4e4a24 100644 --- a/spec/models/form/sales/questions/uprn_spec.rb +++ b/spec/models/form/sales/questions/uprn_spec.rb @@ -45,7 +45,7 @@ RSpec.describe Form::Sales::Questions::Uprn, type: :model do describe "get_extra_check_answer_value" do context "when address is not present" do - let(:log) { create(:sales_log) } + let(:log) { build(:sales_log) } it "returns nil" do expect(question.get_extra_check_answer_value(log)).to be_nil diff --git a/spec/models/form/sales/subsections/discounted_ownership_scheme_spec.rb b/spec/models/form/sales/subsections/discounted_ownership_scheme_spec.rb index 99e861b6d..5f20cbb91 100644 --- a/spec/models/form/sales/subsections/discounted_ownership_scheme_spec.rb +++ b/spec/models/form/sales/subsections/discounted_ownership_scheme_spec.rb @@ -67,7 +67,7 @@ RSpec.describe Form::Sales::Subsections::DiscountedOwnershipScheme, type: :model end context "when it is a discounted ownership scheme" do - let(:log) { FactoryBot.create(:sales_log, ownershipsch: 2) } + let(:log) { FactoryBot.build(:sales_log, ownershipsch: 2) } it "is displayed in tasklist" do expect(discounted_ownership_scheme.displayed_in_tasklist?(log)).to eq(true) @@ -75,7 +75,7 @@ RSpec.describe Form::Sales::Subsections::DiscountedOwnershipScheme, type: :model end context "when it is not a discounted ownership scheme" do - let(:log) { FactoryBot.create(:sales_log, ownershipsch: 1) } + let(:log) { FactoryBot.build(:sales_log, ownershipsch: 1) } it "is displayed in tasklist" do expect(discounted_ownership_scheme.displayed_in_tasklist?(log)).to eq(false) diff --git a/spec/models/form/sales/subsections/household_characteristics_spec.rb b/spec/models/form/sales/subsections/household_characteristics_spec.rb index 2557f33c6..be78f91d3 100644 --- a/spec/models/form/sales/subsections/household_characteristics_spec.rb +++ b/spec/models/form/sales/subsections/household_characteristics_spec.rb @@ -378,7 +378,7 @@ RSpec.describe Form::Sales::Subsections::HouseholdCharacteristics, type: :model end context "when the sale is to a company buyer" do - let(:log) { FactoryBot.create(:sales_log, ownershipsch: 3, companybuy: 1) } + let(:log) { FactoryBot.build(:sales_log, ownershipsch: 3, companybuy: 1) } it "is not displayed in tasklist" do expect(household_characteristics.displayed_in_tasklist?(log)).to eq(false) @@ -386,7 +386,7 @@ RSpec.describe Form::Sales::Subsections::HouseholdCharacteristics, type: :model end context "when the sale is not to a company buyer" do - let(:log) { FactoryBot.create(:sales_log, ownershipsch: 3, companybuy: 2) } + let(:log) { FactoryBot.build(:sales_log, ownershipsch: 3, companybuy: 2) } it "is displayed in tasklist" do expect(household_characteristics.displayed_in_tasklist?(log)).to eq(true) diff --git a/spec/models/form/sales/subsections/outright_sale_spec.rb b/spec/models/form/sales/subsections/outright_sale_spec.rb index cb0f9e7b3..efb2aaad6 100644 --- a/spec/models/form/sales/subsections/outright_sale_spec.rb +++ b/spec/models/form/sales/subsections/outright_sale_spec.rb @@ -122,7 +122,7 @@ RSpec.describe Form::Sales::Subsections::OutrightSale, type: :model do end context "when it is a outright sale" do - let(:log) { FactoryBot.create(:sales_log, ownershipsch: 3) } + let(:log) { FactoryBot.build(:sales_log, ownershipsch: 3) } it "is displayed in tasklist" do expect(outright_sale.displayed_in_tasklist?(log)).to eq(true) @@ -130,7 +130,7 @@ RSpec.describe Form::Sales::Subsections::OutrightSale, type: :model do end context "when it is not a outright sale" do - let(:log) { FactoryBot.create(:sales_log, ownershipsch: 2) } + let(:log) { FactoryBot.build(:sales_log, ownershipsch: 2) } it "is displayed in tasklist" do expect(outright_sale.displayed_in_tasklist?(log)).to eq(false) diff --git a/spec/models/form/sales/subsections/shared_ownership_scheme_spec.rb b/spec/models/form/sales/subsections/shared_ownership_scheme_spec.rb index 0935ce394..59e7bfbfb 100644 --- a/spec/models/form/sales/subsections/shared_ownership_scheme_spec.rb +++ b/spec/models/form/sales/subsections/shared_ownership_scheme_spec.rb @@ -77,7 +77,7 @@ RSpec.describe Form::Sales::Subsections::SharedOwnershipScheme, type: :model do end context "when it is a shared ownership scheme" do - let(:log) { FactoryBot.create(:sales_log, ownershipsch: 1) } + let(:log) { FactoryBot.build(:sales_log, ownershipsch: 1) } it "is displayed in tasklist" do expect(shared_ownership_scheme.displayed_in_tasklist?(log)).to eq(true) @@ -85,7 +85,7 @@ RSpec.describe Form::Sales::Subsections::SharedOwnershipScheme, type: :model do end context "when it is not a shared ownership scheme" do - let(:log) { FactoryBot.create(:sales_log, ownershipsch: 2) } + let(:log) { FactoryBot.build(:sales_log, ownershipsch: 2) } it "is displayed in tasklist" do expect(shared_ownership_scheme.displayed_in_tasklist?(log)).to eq(false) diff --git a/spec/models/scheme_spec.rb b/spec/models/scheme_spec.rb index 75fe66833..a04e7d465 100644 --- a/spec/models/scheme_spec.rb +++ b/spec/models/scheme_spec.rb @@ -305,7 +305,7 @@ RSpec.describe Scheme, type: :model do end context "when scheme has discarded_at value" do - let(:scheme) { FactoryBot.create(:scheme, discarded_at: Time.zone.now) } + let(:scheme) { FactoryBot.build(:scheme, discarded_at: Time.zone.now) } it "returns deleted" do expect(scheme.status).to eq(:deleted) @@ -368,7 +368,7 @@ RSpec.describe Scheme, type: :model do describe "owning organisation" do let(:stock_owning_org) { FactoryBot.create(:organisation, holds_own_stock: true) } let(:non_stock_owning_org) { FactoryBot.create(:organisation, holds_own_stock: false) } - let(:scheme) { FactoryBot.create(:scheme, owning_organisation_id: stock_owning_org.id) } + let(:scheme) { FactoryBot.build(:scheme, owning_organisation_id: stock_owning_org.id) } context "when the owning organisation is set as a non-stock-owning organisation" do it "throws the correct validation error" do diff --git a/spec/models/validations/date_validations_spec.rb b/spec/models/validations/date_validations_spec.rb index 75907b5bc..59be2537e 100644 --- a/spec/models/validations/date_validations_spec.rb +++ b/spec/models/validations/date_validations_spec.rb @@ -4,7 +4,7 @@ RSpec.describe Validations::DateValidations do subject(:date_validator) { validator_class.new } let(:validator_class) { Class.new { include Validations::DateValidations } } - let(:record) { create(:lettings_log) } + let(:record) { build(:lettings_log) } let(:scheme) { create(:scheme, end_date: Time.zone.today - 5.days) } let(:scheme_no_end_date) { create(:scheme, end_date: nil) } diff --git a/spec/models/validations/local_authority_validations_spec.rb b/spec/models/validations/local_authority_validations_spec.rb index 3b903e4dc..6344bf427 100644 --- a/spec/models/validations/local_authority_validations_spec.rb +++ b/spec/models/validations/local_authority_validations_spec.rb @@ -4,7 +4,7 @@ RSpec.describe Validations::LocalAuthorityValidations do subject(:local_auth_validator) { validator_class.new } let(:validator_class) { Class.new { include Validations::LocalAuthorityValidations } } - let(:log) { create(:lettings_log) } + let(:log) { build(:lettings_log) } describe "#validate_previous_accommodation_postcode" do it "does not add an error if the log ppostcode_full is missing" do diff --git a/spec/models/validations/sales/soft_validations_spec.rb b/spec/models/validations/sales/soft_validations_spec.rb index 8ce602d36..c8e8618fc 100644 --- a/spec/models/validations/sales/soft_validations_spec.rb +++ b/spec/models/validations/sales/soft_validations_spec.rb @@ -1,7 +1,7 @@ require "rails_helper" RSpec.describe Validations::Sales::SoftValidations do - let(:record) { create(:sales_log) } + let(:record) { build(:sales_log) } describe "income1 min validations" do context "when validating soft min" do diff --git a/spec/models/validations/setup_validations_spec.rb b/spec/models/validations/setup_validations_spec.rb index 5e7705c6d..7fc4dd982 100644 --- a/spec/models/validations/setup_validations_spec.rb +++ b/spec/models/validations/setup_validations_spec.rb @@ -4,7 +4,7 @@ RSpec.describe Validations::SetupValidations do subject(:setup_validator) { setup_validator_class.new } let(:setup_validator_class) { Class.new { include Validations::SetupValidations } } - let(:record) { create(:lettings_log) } + let(:record) { build(:lettings_log) } describe "tenancy start date" do context "when in 22/23 collection" do @@ -853,7 +853,7 @@ RSpec.describe Validations::SetupValidations do end context "when updating" do - let(:log) { create(:lettings_log, :in_progress) } + let(:log) { build(:lettings_log, :in_progress) } let(:org_with_dpc) { create(:organisation) } let(:org_without_dpc) { create(:organisation, :without_dpc) } diff --git a/spec/models/validations/tenancy_validations_spec.rb b/spec/models/validations/tenancy_validations_spec.rb index f5ffc05b0..a41752616 100644 --- a/spec/models/validations/tenancy_validations_spec.rb +++ b/spec/models/validations/tenancy_validations_spec.rb @@ -6,7 +6,7 @@ RSpec.describe Validations::TenancyValidations do let(:validator_class) { Class.new { include Validations::TenancyValidations } } describe "tenancy length validations" do - let(:record) { FactoryBot.create(:lettings_log, :setup_completed) } + let(:record) { FactoryBot.build(:lettings_log, :setup_completed) } shared_examples "adds expected errors based on the tenancy length" do |tenancy_type_case, error_fields, min_tenancy_length| context "and tenancy type is #{tenancy_type_case[:name]}" do @@ -276,7 +276,7 @@ RSpec.describe Validations::TenancyValidations do end describe "tenancy type validations" do - let(:record) { FactoryBot.create(:lettings_log, :setup_completed) } + let(:record) { FactoryBot.build(:lettings_log, :setup_completed) } let(:field) { "validations.other_field_missing" } let(:main_field_label) { "tenancy type" } let(:other_field) { "tenancyother" } @@ -320,7 +320,7 @@ RSpec.describe Validations::TenancyValidations do describe "joint tenancy validation" do context "when the data inputter has said that there is only one member in the household" do - let(:record) { FactoryBot.create(:lettings_log, :setup_completed, hhmemb: 1) } + let(:record) { FactoryBot.build(:lettings_log, :setup_completed, hhmemb: 1) } let(:expected_error) { I18n.t("validations.tenancy.not_joint") } let(:hhmemb_expected_error) { I18n.t("validations.tenancy.joint_more_than_one_member") }