Check that undesired person details don't get saved

spec/services/imports/lettings_logs_import_service_spec.rb

@@ -1308,30 +1308,44 @@ RSpec.describe Imports::LettingsLogsImportService do
             expect(lettings_log&.age2).to eq(7)
             expect(lettings_log&.sex2).to eq("M")
             expect(lettings_log&.relat2).to eq("C")
+
+            [3, 4, 5].each do |i|
+              expect(lettings_log&.send("details_known_#{i}")).to eq(nil)
+              expect(lettings_log&.send("age#{i}_known")).to eq(nil)
+              expect(lettings_log&.send("age#{i}")).to eq(nil)
+              expect(lettings_log&.send("sex#{i}")).to eq(nil)
+              expect(lettings_log&.send("relat#{i}")).to eq(nil)
+              expect(lettings_log&.send("ecstat#{i}")).to eq(nil)
+            end
           end
         end
 
         context "and several consecutive person details are skipped" do
           before do
             lettings_log_xml.at_xpath("//xmlns:HHMEMB").content = 4
+
             lettings_log_xml.at_xpath("//xmlns:P2AR").content = nil
             lettings_log_xml.at_xpath("//xmlns:P2Age").content = nil
             lettings_log_xml.at_xpath("//xmlns:P2Sex").content = nil
             lettings_log_xml.at_xpath("//xmlns:P2Rel").content = nil
             lettings_log_xml.at_xpath("//xmlns:P2Eco").content = nil
+
             lettings_log_xml.at_xpath("//xmlns:P3AR").content = nil
             lettings_log_xml.at_xpath("//xmlns:P3Age").content = nil
             lettings_log_xml.at_xpath("//xmlns:P3Sex").content = nil
             lettings_log_xml.at_xpath("//xmlns:P3Rel").content = nil
             lettings_log_xml.at_xpath("//xmlns:P3Eco").content = nil
+
             lettings_log_xml.at_xpath("//xmlns:P4Age").content = 7
             lettings_log_xml.at_xpath("//xmlns:P4Sex").content = "Male"
             lettings_log_xml.at_xpath("//xmlns:P4Rel").content = "Child"
             lettings_log_xml.at_xpath("//xmlns:P4Eco").content = "9) Child under 16"
+
             lettings_log_xml.at_xpath("//xmlns:P5Age").content = nil
             lettings_log_xml.at_xpath("//xmlns:P5Sex").content = "Male"
             lettings_log_xml.at_xpath("//xmlns:P5Rel").content = nil
             lettings_log_xml.at_xpath("//xmlns:P5Eco").content = nil
+
             lettings_log_xml.at_xpath("//xmlns:P6Age").content = 12
             lettings_log_xml.at_xpath("//xmlns:P6Sex").content = "Female"
             lettings_log_xml.at_xpath("//xmlns:P6Rel").content = "Child"
@@ -1360,6 +1374,15 @@ RSpec.describe Imports::LettingsLogsImportService do
             expect(lettings_log&.age4).to eq(12)
             expect(lettings_log&.sex4).to eq("F")
             expect(lettings_log&.relat4).to eq("C")
+
+            [5, 6, 7, 8].each do |i|
+              expect(lettings_log&.send("details_known_#{i}")).to eq(nil)
+              expect(lettings_log&.send("age#{i}_known")).to eq(nil)
+              expect(lettings_log&.send("age#{i}")).to eq(nil)
+              expect(lettings_log&.send("sex#{i}")).to eq(nil)
+              expect(lettings_log&.send("relat#{i}")).to eq(nil)
+              expect(lettings_log&.send("ecstat#{i}")).to eq(nil)
+            end
           end
         end
 
@@ -1416,6 +1439,60 @@ RSpec.describe Imports::LettingsLogsImportService do
             expect(lettings_log&.age4).to eq(12)
             expect(lettings_log&.sex4).to eq("F")
             expect(lettings_log&.relat4).to eq("C")
+
+            [5, 6, 7, 8].each do |i|
+              expect(lettings_log&.send("details_known_#{i}")).to eq(nil)
+              expect(lettings_log&.send("age#{i}_known")).to eq(nil)
+              expect(lettings_log&.send("age#{i}")).to eq(nil)
+              expect(lettings_log&.send("sex#{i}")).to eq(nil)
+              expect(lettings_log&.send("relat#{i}")).to eq(nil)
+              expect(lettings_log&.send("ecstat#{i}")).to eq(nil)
+            end
+          end
+        end
+
+        context "with 3 houusehold members without any person data" do
+          before do
+            lettings_log_xml.at_xpath("//xmlns:HHMEMB").content = 3
+            lettings_log_xml.at_xpath("//xmlns:P2AR").content = "No"
+            lettings_log_xml.at_xpath("//xmlns:P2Age").content = nil
+            lettings_log_xml.at_xpath("//xmlns:P2Sex").content = nil
+            lettings_log_xml.at_xpath("//xmlns:P2Rel").content = nil
+            lettings_log_xml.at_xpath("//xmlns:P2Eco").content = nil
+
+            lettings_log_xml.at_xpath("//xmlns:P3AR").content = "No"
+            lettings_log_xml.at_xpath("//xmlns:P3Age").content = nil
+            lettings_log_xml.at_xpath("//xmlns:P3Sex").content = nil
+            lettings_log_xml.at_xpath("//xmlns:P3Rel").content = nil
+            lettings_log_xml.at_xpath("//xmlns:P3Eco").content = nil
+          end
+
+          it "correctly sets person details" do
+            lettings_log_service.send(:create_log, lettings_log_xml)
+
+            lettings_log = LettingsLog.where(old_id: lettings_log_id).first
+            expect(lettings_log&.hhmemb).to eq(3)
+
+            expect(lettings_log&.details_known_2).to eq(0)
+            expect(lettings_log&.age2_known).to eq(1)
+            expect(lettings_log&.age2).to eq(nil)
+            expect(lettings_log&.sex2).to eq(nil)
+            expect(lettings_log&.relat2).to eq(nil)
+
+            expect(lettings_log&.details_known_3).to eq(0)
+            expect(lettings_log&.age3_known).to eq(1)
+            expect(lettings_log&.age3).to eq(nil)
+            expect(lettings_log&.sex3).to eq(nil)
+            expect(lettings_log&.relat3).to eq(nil)
+
+            [4, 5, 6, 7, 8].each do |i|
+              expect(lettings_log&.send("details_known_#{i}")).to eq(nil)
+              expect(lettings_log&.send("age#{i}_known")).to eq(nil)
+              expect(lettings_log&.send("age#{i}")).to eq(nil)
+              expect(lettings_log&.send("sex#{i}")).to eq(nil)
+              expect(lettings_log&.send("relat#{i}")).to eq(nil)
+              expect(lettings_log&.send("ecstat#{i}")).to eq(nil)
+            end
           end
         end
       end