Rachael Booth
2 years ago
committed by
GitHub
21 changed files with 164 additions and 110 deletions
@ -1,9 +1,80 @@ |
|||||||
require "rails_helper" |
require "rails_helper" |
||||||
|
|
||||||
describe PostcodeService do |
describe PostcodeService do |
||||||
let(:postcode) { "s r81LS\u00A0" } |
let(:service) { described_class.new } |
||||||
|
|
||||||
it "returns clean postcode" do |
describe "clean" do |
||||||
expect(described_class.clean(postcode)).to eq "SR81LS" |
let(:postcode) { "s r81LS\u00A0" } |
||||||
|
|
||||||
|
it "returns clean postcode" do |
||||||
|
expect(described_class.clean(postcode)).to eq "SR81LS" |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
describe "lookup" do |
||||||
|
before do |
||||||
|
Excon.defaults[:mock] = true |
||||||
|
Excon.defaults[:stubs] = :local |
||||||
|
end |
||||||
|
|
||||||
|
context "when the request returns a success response" do |
||||||
|
before do |
||||||
|
Excon.stub({}, { body: '{"result": { "admin_district": "District", "codes": { "admin_district": "123" } } }', status: 200 }) |
||||||
|
end |
||||||
|
|
||||||
|
it "returns the admin district and admin district code" do |
||||||
|
result = service.lookup("A00 0AA") |
||||||
|
expect(result[:location_code]).to eq("123") |
||||||
|
expect(result[:location_admin_district]).to eq("District") |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
context "when the request returns a not found response" do |
||||||
|
before do |
||||||
|
Excon.stub({}, { status: 404 }) |
||||||
|
end |
||||||
|
|
||||||
|
it "returns nil" do |
||||||
|
result = service.lookup("A00 0AA") |
||||||
|
expect(result).to be_nil |
||||||
|
end |
||||||
|
|
||||||
|
it "logs the error at warning level" do |
||||||
|
expect(Rails.logger).to receive(:warn).with(match "404 Not Found") |
||||||
|
service.lookup("A00 0AA") |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
context "when the request returns an error response" do |
||||||
|
before do |
||||||
|
Excon.stub({}, { body: "This is an error message that is not valid json", status: 500 }) |
||||||
|
end |
||||||
|
|
||||||
|
it "returns nil" do |
||||||
|
result = service.lookup("A00 0AA") |
||||||
|
expect(result).to be_nil |
||||||
|
end |
||||||
|
|
||||||
|
it "logs the error at warning level" do |
||||||
|
expect(Rails.logger).to receive(:warn).with(match "This is an error message that is not valid json") |
||||||
|
service.lookup("A00 0AA") |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
context "when the request returns a success response that causes later errors" do |
||||||
|
before do |
||||||
|
Excon.stub({}, { body: '{"result": { "admin_district": "District" } }', status: 200 }) |
||||||
|
end |
||||||
|
|
||||||
|
it "returns nil" do |
||||||
|
result = service.lookup("A00 0AA") |
||||||
|
expect(result).to be_nil |
||||||
|
end |
||||||
|
|
||||||
|
it "logs the error at error level" do |
||||||
|
expect(Rails.logger).to receive(:error).with(match "Unexpected error with postcode lookup request") |
||||||
|
service.lookup("A00 0AA") |
||||||
|
end |
||||||
|
end |
||||||
end |
end |
||||||
end |
end |
||||||
|
|||||||
Loading…
Reference in new issue