alter way of setting question options to reduce future tech debt

app/models/form/sales/questions/shared_ownership_type.rb

@@ -6,27 +6,31 @@ class Form::Sales::Questions::SharedOwnershipType < ::Form::Question
     @header = "What is the type of shared ownership sale?"
     @hint_text = "A shared ownership sale is when the purchaser buys up to 75% of the property value and pays rent to the Private Registered Provider (PRP) on the remaining portion"
     @type = "radio"
-    @answer_options = form.start_date.year >= 2023 ? ANSWER_OPTIONS_23_24 : ANSWER_OPTIONS
+    @answer_options = answer_options
   end
 
-  ANSWER_OPTIONS = {
+  def answer_options
-    "2" => { "value" => "Shared Ownership" },
+    if form.start_date.year >= 2023
-    "24" => { "value" => "Old Persons Shared Ownership" },
+      {
-    "18" => { "value" => "Social HomeBuy (shared ownership purchase)" },
+        "2" => { "value" => "Shared Ownership (old model lease)" },
-    "16" => { "value" => "Home Ownership for people with Long Term Disabilities (HOLD)" },
+        "30" => { "value" => "Shared Ownership (new model lease)" },
-    "28" => { "value" => "Rent to Buy - Shared Ownership" },
+        "18" => { "value" => "Social HomeBuy — shared ownership purchase" },
-    "31" => { "value" => "Right to Shared Ownership" },
+        "16" => { "value" => "Home Ownership for people with Long Term Disabilities (HOLD)" },
-    "30" => { "value" => "Shared Ownership - 2021 model lease" },
+        "24" => { "value" => "Older Persons Shared Ownership" },
-  }.freeze
+        "28" => { "value" => "Rent to Buy — Shared Ownership" },
-
+        "31" => { "value" => "Right to Shared Ownership (RtSO)" },
-  ANSWER_OPTIONS_23_24 = {
+        "32" => { "value" => "London Living Rent — Shared Ownership" },
-    "2" => { "value" => "Shared Ownership (old model lease)" },
+      }
-    "30" => { "value" => "Shared Ownership (new model lease)" },
+    else
-    "18" => { "value" => "Social HomeBuy — shared ownership purchase" },
+      {
-    "16" => { "value" => "Home Ownership for people with Long Term Disabilities (HOLD)" },
+        "2" => { "value" => "Shared Ownership" },
-    "24" => { "value" => "Older Persons Shared Ownership" },
+        "24" => { "value" => "Old Persons Shared Ownership" },
-    "28" => { "value" => "Rent to Buy — Shared Ownership" },
+        "18" => { "value" => "Social HomeBuy (shared ownership purchase)" },
-    "31" => { "value" => "Right to Shared Ownership (RtSO)" },
+        "16" => { "value" => "Home Ownership for people with Long Term Disabilities (HOLD)" },
-    "32" => { "value" => "London Living Rent — Shared Ownership" },
+        "28" => { "value" => "Rent to Buy - Shared Ownership" },
-  }.freeze
+        "31" => { "value" => "Right to Shared Ownership" },
+        "30" => { "value" => "Shared Ownership - 2021 model lease" },
+      }
+    end
+  end
 end