From e340e7b551188cd2d176958782c33444eccc6b80 Mon Sep 17 00:00:00 2001
From: Arthur Campbell <arfa.camble@gmail.com>
Date: Wed, 5 Jun 2024 21:08:53 +0100
Subject: [PATCH] initial spec file refactor remove create for build, extract
 form to own variable, remove non-valuable tests run time from 0.29s to0.11s

---
 .../form/sales/questions/mortgageused_spec.rb | 37 ++-----------------
 1 file changed, 3 insertions(+), 34 deletions(-)

diff --git a/spec/models/form/sales/questions/mortgageused_spec.rb b/spec/models/form/sales/questions/mortgageused_spec.rb
index 5c98360af..af62244a4 100644
--- a/spec/models/form/sales/questions/mortgageused_spec.rb
+++ b/spec/models/form/sales/questions/mortgageused_spec.rb
@@ -5,32 +5,9 @@ RSpec.describe Form::Sales::Questions::Mortgageused, type: :model do
 
   let(:question_id) { nil }
   let(:question_definition) { nil }
-  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2023, 4, 1)))) }
-  let(:log) { create(:sales_log) }
-
-  it "has correct page" do
-    expect(question.page).to eq(page)
-  end
-
-  it "has the correct id" do
-    expect(question.id).to eq("mortgageused")
-  end
-
-  it "has the correct header" do
-    expect(question.header).to eq("Was a mortgage used for the purchase of this property?")
-  end
-
-  it "has the correct check_answer_label" do
-    expect(question.check_answer_label).to eq("Mortgage used")
-  end
-
-  it "has the correct type" do
-    expect(question.type).to eq("radio")
-  end
-
-  it "is not marked as derived" do
-    expect(question.derived?(nil)).to be false
-  end
+  let(:form) { instance_double(Form, start_date: Time.zone.local(2024, 4, 1)) }
+  let(:page) { instance_double(Form::Page, subsection: instance_double(Form::Subsection, form:)) }
+  let(:log) { build(:sales_log) }
 
   it "has the correct answer_options" do
     expect(question.answer_options).to eq({
@@ -40,14 +17,6 @@ RSpec.describe Form::Sales::Questions::Mortgageused, type: :model do
     })
   end
 
-  it "has correct conditional for" do
-    expect(question.conditional_for).to eq(nil)
-  end
-
-  it "has the correct hint" do
-    expect(question.hint_text).to be_nil
-  end
-
   context "when staircase owned percentage is 100%" do
     let(:log) { build(:sales_log, stairowned: 100) }