From e32354dfcabbaf6563a34b1759785d203ee9ca73 Mon Sep 17 00:00:00 2001
From: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
Date: Mon, 12 Jun 2023 16:40:42 +0100
Subject: [PATCH] feat: update max and add new spec

---
 app/models/form/lettings/questions/offered.rb |  2 +-
 .../lettings/questions/offered_social_let.rb  |  2 +-
 .../questions/offered_social_let_spec.rb      |  2 +-
 .../form/lettings/questions/offered_spec.rb   | 44 +++++++++++++++++++
 4 files changed, 47 insertions(+), 3 deletions(-)
 create mode 100644 spec/models/form/lettings/questions/offered_spec.rb

diff --git a/app/models/form/lettings/questions/offered.rb b/app/models/form/lettings/questions/offered.rb
index 2c9828d31..e41def301 100644
--- a/app/models/form/lettings/questions/offered.rb
+++ b/app/models/form/lettings/questions/offered.rb
@@ -7,7 +7,7 @@ class Form::Lettings::Questions::Offered < ::Form::Question
     @type = "numeric"
     @width = 2
     @check_answers_card_number = 0
-    @max = 20
+    @max = 150
     @min = 0
     @hint_text = I18n.t("hints.offered")
     @step = 1
diff --git a/app/models/form/lettings/questions/offered_social_let.rb b/app/models/form/lettings/questions/offered_social_let.rb
index dd57acbfe..d3ac29516 100644
--- a/app/models/form/lettings/questions/offered_social_let.rb
+++ b/app/models/form/lettings/questions/offered_social_let.rb
@@ -7,7 +7,7 @@ class Form::Lettings::Questions::OfferedSocialLet < ::Form::Question
     @type = "numeric"
     @width = 2
     @check_answers_card_number = 0
-    @max = 20
+    @max = 150
     @min = 0
     @hint_text = I18n.t("hints.offered")
     @step = 1
diff --git a/spec/models/form/lettings/questions/offered_social_let_spec.rb b/spec/models/form/lettings/questions/offered_social_let_spec.rb
index ac1930495..724c0dcc1 100644
--- a/spec/models/form/lettings/questions/offered_social_let_spec.rb
+++ b/spec/models/form/lettings/questions/offered_social_let_spec.rb
@@ -27,7 +27,7 @@ RSpec.describe Form::Lettings::Questions::OfferedSocialLet, type: :model do
 
   it "has the correct minimum and maximum values" do
     expect(question.min).to be 0
-    expect(question.max).to be 20
+    expect(question.max).to be 150
   end
 
   it "has the correct step" do
diff --git a/spec/models/form/lettings/questions/offered_spec.rb b/spec/models/form/lettings/questions/offered_spec.rb
new file mode 100644
index 000000000..09d103a1b
--- /dev/null
+++ b/spec/models/form/lettings/questions/offered_spec.rb
@@ -0,0 +1,44 @@
+require "rails_helper"
+
+RSpec.describe Form::Lettings::Questions::Offered, type: :model do
+  subject(:question) { described_class.new(nil, nil, page) }
+
+  let(:page) { instance_double(Form::Page) }
+
+  it "has correct page" do
+    expect(question.page).to be page
+  end
+
+  it "has the correct id" do
+    expect(question.id).to eq "offered"
+  end
+
+  it "has the correct header" do
+    expect(question.header).to eq "How many times was the property offered between becoming vacant and this letting?"
+  end
+
+  it "has the correct check_answer_label" do
+    expect(question.check_answer_label).to eq "Times previously offered since becoming available"
+  end
+
+  it "has the correct type" do
+    expect(question.type).to eq "numeric"
+  end
+
+  it "has the correct minimum and maximum values" do
+    expect(question.min).to be 0
+    expect(question.max).to be 150
+  end
+
+  it "has the correct step" do
+    expect(question.step).to be 1
+  end
+
+  it "is not marked as derived" do
+    expect(question.derived?).to be false
+  end
+
+  it "has the correct hint_text" do
+    expect(question.hint_text).to eq "Do not include the offer that led to this letting. This is after the last tenancy ended. If the property is being offered for let for the first time, enter 0."
+  end
+end