From e2b36ddae54eb533e2a8230ee2febafc5da7839b Mon Sep 17 00:00:00 2001 From: Paul Robert Lloyd Date: Thu, 28 Apr 2022 16:26:49 +0100 Subject: [PATCH] Include full stops in hint text --- config/forms/2021_2022.json | 2 +- config/forms/2022_2023.json | 2 +- config/locales/en.yml | 6 +++--- spec/models/validations/financial_validations_spec.rb | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/config/forms/2021_2022.json b/config/forms/2021_2022.json index ffc561999..0cb6d499b 100644 --- a/config/forms/2021_2022.json +++ b/config/forms/2021_2022.json @@ -4264,7 +4264,7 @@ "reasonable_preference_reason": { "check_answer_label": "Reason for reasonable preference", "header": "Why was the household given ‘reasonable preference’?", - "hint_text": "Select all that apply", + "hint_text": "Select all that apply.", "type": "checkbox", "answer_options": { "rp_homeless": { diff --git a/config/forms/2022_2023.json b/config/forms/2022_2023.json index 72e8c4e3e..c45192439 100644 --- a/config/forms/2022_2023.json +++ b/config/forms/2022_2023.json @@ -4275,7 +4275,7 @@ "reasonable_preference_reason": { "check_answer_label": "Reason for reasonable preference", "header": "Why was the household given ‘reasonable preference’?", - "hint_text": "Select all that apply", + "hint_text": "Select all that apply.", "type": "checkbox", "answer_options": { "rp_homeless": { diff --git a/config/locales/en.yml b/config/locales/en.yml index 55e860fe4..123a616d9 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -227,16 +227,16 @@ en: soft_validations: net_income: - hint_text: "

You told us the lead tenant’s working situation is: %{ecstat1}

The household income you have entered is %{earnings}

" + hint_text: "

You told us the lead tenant’s working situation is: %{ecstat1}.

The household income you have entered is %{earnings}.

" in_soft_min_range: message: "Net income is lower than expected based on the lead tenant’s working situation. Are you sure this is correct?" in_soft_max_range: message: "Net income is higher than expected based on the lead tenant’s working situation. Are you sure this is correct?" rent: min: - hint_text: "

You told us the rent is %{brent}

The minimum rent for this type of property in %{la} is £%{soft_min_for_period}

" + hint_text: "

You told us the rent is %{brent}

The minimum rent for this type of property in %{la} is £%{soft_min_for_period}.

" max: - hint_text: "

You told us the rent is %{brent}

The maximum rent for this type of property in %{la} is £%{soft_max_for_period}

" + hint_text: "

You told us the rent is %{brent}

The maximum rent for this type of property in %{la} is £%{soft_max_for_period}.

" devise: two_factor_authentication: success: "Two-factor authentication successful" diff --git a/spec/models/validations/financial_validations_spec.rb b/spec/models/validations/financial_validations_spec.rb index 537986bf5..a8b217b02 100644 --- a/spec/models/validations/financial_validations_spec.rb +++ b/spec/models/validations/financial_validations_spec.rb @@ -47,7 +47,7 @@ RSpec.describe Validations::FinancialValidations do expect(record.errors["benefits"]).to be_empty end - it "validates that the tenant's partner is not in full time employment" do + it "validates that the tenant’s partner is not in full time employment" do record.benefits = 0 record.ecstat2 = 0 record.relat2 = "P" @@ -55,7 +55,7 @@ RSpec.describe Validations::FinancialValidations do expect(record.errors["benefits"]).to include(match I18n.t("validations.financial.benefits.part_or_full_time")) end - it "expects that the tenant's partner is not in full-time or part-time employment" do + it "expects that the tenant’s partner is not in full-time or part-time employment" do record.benefits = 0 record.ecstat2 = 4 record.relat2 = "P" @@ -144,7 +144,7 @@ RSpec.describe Validations::FinancialValidations do end describe "net income validations" do - it "validates that the net income is within the expected range for the tenant's employment status" do + it "validates that the net income is within the expected range for the tenant’s employment status" do record.earnings = 200 record.incfreq = 1 record.ecstat1 = 1