From dda7f71e1ddf35ba2b003b321647aa44243c95f1 Mon Sep 17 00:00:00 2001
From: Phil Lee <asmega@users.noreply.github.com>
Date: Thu, 15 Dec 2022 15:58:59 +0000
Subject: [PATCH] populate errors with cell, row + metadata

---
 .../bulk_upload/lettings/validator.rb         | 24 +++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/app/services/bulk_upload/lettings/validator.rb b/app/services/bulk_upload/lettings/validator.rb
index db19e784a..d03d59bd9 100644
--- a/app/services/bulk_upload/lettings/validator.rb
+++ b/app/services/bulk_upload/lettings/validator.rb
@@ -151,11 +151,23 @@ class BulkUpload::Lettings::Validator
   end
 
   def call
-    row_parsers.each do |row_parser|
+    row_offset = 6
+    col_offset = 0
+
+    row_parsers.each_with_index do |row_parser, index|
       row_parser.valid?
 
+      row = index + row_offset
+
       row_parser.errors.each do |error|
-        bulk_upload.bulk_upload_errors.create!(field: error.attribute, error: error.type)
+        bulk_upload.bulk_upload_errors.create!(
+          field: error.attribute,
+          error: error.type,
+          tenant_code: row_parser.field_7,
+          property_ref: row_parser.field_100,
+          row:,
+          cell: "#{cols[field_number_for_attribute(error.attribute) + col_offset]}#{row}",
+        )
       end
     end
   end
@@ -166,6 +178,14 @@ class BulkUpload::Lettings::Validator
 
 private
 
+  def field_number_for_attribute(attribute)
+    attribute.to_s.split("_").last.to_i
+  end
+
+  def cols
+    @cols ||= ("A".."EE").to_a
+  end
+
   def row_parsers
     @row_parsers ||= body_rows.map do |row|
       stripped_row = row[1..]