From dc3c118bbd6ca5e6ae8ad76a21308d2f32e6d154 Mon Sep 17 00:00:00 2001
From: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
Date: Mon, 6 Mar 2023 11:41:51 +0000
Subject: [PATCH] Improve import error logging (#1382)

---
 app/services/imports/sales_logs_import_service.rb | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/app/services/imports/sales_logs_import_service.rb b/app/services/imports/sales_logs_import_service.rb
index d9ac0b0d4..4c49f0037 100644
--- a/app/services/imports/sales_logs_import_service.rb
+++ b/app/services/imports/sales_logs_import_service.rb
@@ -168,8 +168,16 @@ module Imports
       end
     end
 
-    def rescue_validation_or_raise(sales_log, _attributes, _previous_status, exception)
+    def rescue_validation_or_raise(sales_log, attributes, _previous_status, exception)
       @logger.error("Log #{sales_log.old_id}: Failed to import")
+      sales_log.errors.each do |error|
+        @logger.error("Validation error: Field #{error.attribute}:")
+        @logger.error("\tOwning Organisation: #{sales_log.owning_organisation&.name}")
+        @logger.error("\tOld CORE ID: #{sales_log.old_id}")
+        @logger.error("\tOld CORE: #{attributes[error.attribute.to_s]&.inspect}")
+        @logger.error("\tNew CORE: #{sales_log.read_attribute(error.attribute)&.inspect}")
+        @logger.error("\tError message: #{error.type}")
+      end
       raise exception
     end