Browse Source

Uncomment skipped tests

pull/2363/head
Kat 2 years ago
parent
commit
dbfc18a11f
  1. 12
      spec/features/home_page_spec.rb
  2. 6
      spec/requests/lettings_logs_controller_spec.rb
  3. 12
      spec/requests/locations_controller_spec.rb

12
spec/features/home_page_spec.rb

@ -163,7 +163,7 @@ RSpec.describe "Home Page Features" do
Singleton.__init__(FormHandler)
end
xit "displays correct data boxes, counts and links" do
it "displays correct data boxes, counts and links" do
data_boxes = page.find_all(class: "app-data-box-one-half")
expect(data_boxes.count).to eq(2)
expect(data_boxes[0].all("a").map(&:text)).to eq(["6", "Your lettings in progress", "View all lettings"])
@ -188,7 +188,7 @@ RSpec.describe "Home Page Features" do
Singleton.__init__(FormHandler)
end
xit "displays correct data boxes, counts and links" do
it "displays correct data boxes, counts and links" do
data_boxes = page.find_all(class: "app-data-box-one-half")
expect(data_boxes.count).to eq(2)
@ -205,7 +205,7 @@ RSpec.describe "Home Page Features" do
visit(root_path)
end
xit "displays correct data boxes, counts and links" do
it "displays correct data boxes, counts and links" do
data_boxes = page.find_all(class: "app-data-box-one-half")
expect(data_boxes.count).to eq(2)
expect(data_boxes[0].all("a").map(&:text)).to eq(["6", "Your lettings in progress", "View all lettings"])
@ -244,7 +244,7 @@ RSpec.describe "Home Page Features" do
visit(root_path)
end
xit "displays correct data boxes, counts and links" do
it "displays correct data boxes, counts and links" do
data_boxes = page.find_all(class: "app-data-box-one-third")
expect(data_boxes.count).to eq(3)
expect(data_boxes[0].all("a").map(&:text)).to eq(["8", "Lettings in progress", "View all lettings"])
@ -261,7 +261,7 @@ RSpec.describe "Home Page Features" do
visit(root_path)
end
xit "displays correct data boxes, counts and links" do
it "displays correct data boxes, counts and links" do
data_boxes = page.find_all(class: "app-data-box-one-half")
expect(data_boxes.count).to eq(2)
expect(data_boxes[0].all("a").map(&:text)).to eq(["8", "Lettings in progress", "View all lettings"])
@ -309,7 +309,7 @@ RSpec.describe "Home Page Features" do
expect(page).to have_content("Manage all data")
end
xit "displays correct data boxes, counts and links" do
it "displays correct data boxes, counts and links" do
data_boxes = page.find_all(class: "app-data-box-one-third")
expect(data_boxes.count).to eq(3)
expect(data_boxes[0].all("a").map(&:text)).to eq(["2", "Lettings in progress", "View all lettings"])

6
spec/requests/lettings_logs_controller_spec.rb

@ -812,7 +812,7 @@ RSpec.describe LettingsLogsController, type: :request do
expect(page).to have_title("Lettings logs (#{logs.count} logs matching ‘#{postcode}’) (page 1 of 2) - Submit social housing lettings and sales data (CORE) - GOV.UK")
end
xit "has title with pagination details for page 2" do
it "has title with pagination details for page 2" do
get "/lettings-logs?search=#{logs[0].postcode_full}&page=2", headers:, params: {}
expect(page).to have_title("Lettings logs (#{logs.count} logs matching ‘#{postcode}’) (page 2 of 2) - Submit social housing lettings and sales data (CORE) - GOV.UK")
end
@ -969,7 +969,7 @@ RSpec.describe LettingsLogsController, type: :request do
end
end
xcontext "when on the second page" do
context "when on the second page" do
before do
get "/lettings-logs?page=2", headers:, params: {}
end
@ -1641,7 +1641,7 @@ RSpec.describe LettingsLogsController, type: :request do
expect(page).to have_content("Log #{id} has been deleted.")
end
xit "marks the log as deleted" do
it "marks the log as deleted" do
expect { delete_request }.to change { lettings_log.reload.status }.from("completed").to("deleted")
end
end

12
spec/requests/locations_controller_spec.rb

@ -249,16 +249,16 @@ RSpec.describe LocationsController, type: :request do
get "/schemes/#{scheme.id}/locations?page=2"
end
xit "shows which schemes are being shown on the current page" do
it "shows which schemes are being shown on the current page" do
expect(CGI.unescape_html(response.body)).to match("Showing <b>21</b> to <b>25</b> of <b>#{locations.count}</b> locations")
end
xit "has correct page 2 of 2 title" do
it "has correct page 2 of 2 title" do
expected_title = CGI.escapeHTML("#{scheme.service_name} (page 2 of 2) - Submit social housing lettings and sales data (CORE) - GOV.UK")
expect(page).to have_title(expected_title)
end
xit "has pagination links" do
it "has pagination links" do
expect(page).to have_content("Previous")
expect(page).to have_link("Previous")
expect(page).not_to have_content("Next")
@ -377,16 +377,16 @@ RSpec.describe LocationsController, type: :request do
get "/schemes/#{scheme.id}/locations?page=2"
end
xit "shows which schemes are being shown on the current page" do
it "shows which schemes are being shown on the current page" do
expect(CGI.unescape_html(response.body)).to match("Showing <b>21</b> to <b>25</b> of <b>#{locations.count}</b> locations")
end
xit "has correct page 1 of 2 title" do
it "has correct page 1 of 2 title" do
expected_title = CGI.escapeHTML("#{scheme.service_name} (page 2 of 2) - Submit social housing lettings and sales data (CORE) - GOV.UK")
expect(page).to have_title(expected_title)
end
xit "has pagination links" do
it "has pagination links" do
expect(page).to have_content("Previous")
expect(page).to have_link("Previous")
expect(page).not_to have_content("Next")

Loading…
Cancel
Save