From dbe12960aa2e100286031a7763c897ac7c71ddaf Mon Sep 17 00:00:00 2001
From: baarkerlounger <db@slothlife.xyz>
Date: Wed, 8 Sep 2021 16:34:29 +0100
Subject: [PATCH] Rubocop

---
 Gemfile                        | 6 +++---
 app/models/case_log.rb         | 2 +-
 spec/factories/case_log.rb     | 2 +-
 spec/features/case_log_spec.rb | 4 ++--
 spec/spec_helper.rb            | 3 +--
 5 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/Gemfile b/Gemfile
index 4066943b0..c41b43646 100644
--- a/Gemfile
+++ b/Gemfile
@@ -25,10 +25,10 @@ group :development, :test do
   # Call 'byebug' anywhere in the code to stop execution and get a debugger console
   gem "byebug", platforms: %i[mri mingw x64_mingw]
   gem "capybara"
-  gem "pry-byebug"
   gem "dotenv-rails"
-  gem "selenium-webdriver"
   gem "factory_bot_rails"
+  gem "pry-byebug"
+  gem "selenium-webdriver"
   %w[rspec-core rspec-expectations rspec-mocks rspec-rails rspec-support].each do |lib|
     gem lib, git: "https://github.com/rspec/#{lib}.git", branch: "main"
   end
@@ -40,12 +40,12 @@ group :development do
   # Display performance information such as SQL time and flame graphs for each request in your browser.
   # Can be configured to work on production as well see: https://github.com/MiniProfiler/rack-mini-profiler/blob/master/README.md
   gem "listen", "~> 3.3"
+  gem "overcommit", ">= 0.37.0", require: false
   gem "rack-mini-profiler", "~> 2.0"
   gem "rubocop-govuk"
   gem "rubocop-performance", require: false
   gem "rubocop-rails"
   gem "scss_lint-govuk"
-  gem "overcommit", ">= 0.37.0", require: false
 end
 
 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
diff --git a/app/models/case_log.rb b/app/models/case_log.rb
index 9fd005fb7..3f860cc08 100644
--- a/app/models/case_log.rb
+++ b/app/models/case_log.rb
@@ -1,3 +1,3 @@
 class CaseLog < ApplicationRecord
-  enum status: ["in progress", "submitted"]
+  enum status: { "in progress" => 0, "submitted" => 1 }
 end
diff --git a/spec/factories/case_log.rb b/spec/factories/case_log.rb
index cefc12c97..9380466df 100644
--- a/spec/factories/case_log.rb
+++ b/spec/factories/case_log.rb
@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :case_log do
-    id { 342351 }
+    id { 342_351 }
     status { 0 }
   end
 end
diff --git a/spec/features/case_log_spec.rb b/spec/features/case_log_spec.rb
index 05bdaa6c1..149a39575 100644
--- a/spec/features/case_log_spec.rb
+++ b/spec/features/case_log_spec.rb
@@ -1,7 +1,7 @@
 require "rails_helper"
 RSpec.describe "Test Features" do
-  let!(:case_log){ FactoryBot.create(:case_log) }
-  let(:id){ case_log.id }
+  let!(:case_log) { FactoryBot.create(:case_log) }
+  let(:id) { case_log.id }
   let(:status) { case_log.status }
 
   it "Displays a tasklist header" do
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index 6cf19332c..efc2ff51f 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -87,7 +87,7 @@ RSpec.configure do |config|
   #   # order dependency and want to debug it, you can fix the order by providing
   #   # the seed, which is printed after each run.
   #   #     --seed 1234
-     config.order = :random
+  config.order = :random
   #
   #   # Seed global randomization in this process using the `--seed` CLI option.
   #   # Setting this allows you to use `--seed` to deterministically reproduce
@@ -95,6 +95,5 @@ RSpec.configure do |config|
   #   # as the one that triggered the failure.
   #   Kernel.srand config.seed
 
-
   config.include FactoryBot::Syntax::Methods
 end