baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Fix lint

pull/2685/head
Manny Dinssa 2 years ago
parent
622ff7c364
commit
da80f9cd94
1 changed files with 12 additions and 12 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 24
      lib/tasks/duplicate_rent_periods.rake

24
lib/tasks/duplicate_rent_periods.rake
Unescape View File

@ -1,9 +1,9 @@
desc "Find and output each group of duplicate rent periods with a total count" desc "Find and output each group of duplicate rent periods with a total count"
task find_redundant_rent_periods: :environment do task find_redundant_rent_periods: :environment do
duplicate_groups = OrganisationRentPeriod duplicate_groups = OrganisationRentPeriod
.select('organisation_id, rent_period') .select("organisation_id, rent_period")
.group('organisation_id, rent_period') .group("organisation_id, rent_period")
.having('COUNT(*) > 1') .having("COUNT(*) > 1")
duplicate_records = OrganisationRentPeriod duplicate_records = OrganisationRentPeriod
.where(organisation_id: duplicate_groups.map(&:organisation_id), rent_period: duplicate_groups.map(&:rent_period)) .where(organisation_id: duplicate_groups.map(&:organisation_id), rent_period: duplicate_groups.map(&:rent_period))
@ -17,9 +17,9 @@ task find_redundant_rent_periods: :environment do
end end
ids_to_keep = OrganisationRentPeriod ids_to_keep = OrganisationRentPeriod
.select('MIN(id) as id') .select("MIN(id) as id")
.group('organisation_id, rent_period') .group("organisation_id, rent_period")
.having('COUNT(*) > 1') .having("COUNT(*) > 1")
.map(&:id) .map(&:id)
redundant_ids = duplicate_records.pluck(:id) - ids_to_keep redundant_ids = duplicate_records.pluck(:id) - ids_to_keep
@ -31,18 +31,18 @@ end
desc "Delete redundant rent periods" desc "Delete redundant rent periods"
task delete_duplicate_rent_periods: :environment do task delete_duplicate_rent_periods: :environment do
duplicate_groups = OrganisationRentPeriod duplicate_groups = OrganisationRentPeriod
.select('organisation_id, rent_period') .select("organisation_id, rent_period")
.group('organisation_id, rent_period') .group("organisation_id, rent_period")
.having('COUNT(*) > 1') .having("COUNT(*) > 1")
duplicate_ids = OrganisationRentPeriod duplicate_ids = OrganisationRentPeriod
.where(organisation_id: duplicate_groups.map(&:organisation_id), rent_period: duplicate_groups.map(&:rent_period)) .where(organisation_id: duplicate_groups.map(&:organisation_id), rent_period: duplicate_groups.map(&:rent_period))
.pluck(:id) .pluck(:id)
ids_to_keep = OrganisationRentPeriod ids_to_keep = OrganisationRentPeriod
.select('MIN(id) as id') .select("MIN(id) as id")
.group('organisation_id, rent_period') .group("organisation_id, rent_period")
.having('COUNT(*) > 1') .having("COUNT(*) > 1")
.map(&:id) .map(&:id)
redundant_ids = duplicate_ids - ids_to_keep redundant_ids = duplicate_ids - ids_to_keep

Write Preview
Loading…
Cancel
Save