diff --git a/app/services/imports/logs_import_service.rb b/app/services/imports/logs_import_service.rb index 240fa7620..f6a4f8a22 100644 --- a/app/services/imports/logs_import_service.rb +++ b/app/services/imports/logs_import_service.rb @@ -31,8 +31,8 @@ module Imports }.freeze def creation_method(xml_doc) - upload_method = meta_field_value(xml_doc, "upload-method") - CREATION_METHODS[upload_method] + upload_id = meta_field_value(xml_doc, "upload-id") + upload_id.present? ? "bulk upload" : "single log" end def find_organisation_id(xml_doc, id_field) diff --git a/lib/tasks/creation_method.rake b/lib/tasks/creation_method.rake index 7dde5ad80..4f3f46539 100644 --- a/lib/tasks/creation_method.rake +++ b/lib/tasks/creation_method.rake @@ -1,5 +1,5 @@ desc "set creation method to bulk upload if a log has a bulk upload id" task set_creation_method: :environment do - LettingsLog.where.not(bulk_upload_id: nil).each(&:creation_method_bulk_upload!) - SalesLog.where.not(bulk_upload_id: nil).each(&:creation_method_bulk_upload!) + LettingsLog.where.not(bulk_upload_id: nil).find_each(&:creation_method_bulk_upload!) + SalesLog.where.not(bulk_upload_id: nil).find_each(&:creation_method_bulk_upload!) end diff --git a/spec/fixtures/imports/logs/166fc004-392e-47a8-acb8-1c018734882b.xml b/spec/fixtures/imports/logs/166fc004-392e-47a8-acb8-1c018734882b.xml index 8c5119bd0..0ddca74c3 100644 --- a/spec/fixtures/imports/logs/166fc004-392e-47a8-acb8-1c018734882b.xml +++ b/spec/fixtures/imports/logs/166fc004-392e-47a8-acb8-1c018734882b.xml @@ -9,7 +9,7 @@ 2022-04-12T14:10:59.953121Z submitted-valid 2021 - Bulk Upload + Manual Entry diff --git a/spec/fixtures/imports/sales_logs/shared_ownership_sales_log2.xml b/spec/fixtures/imports/sales_logs/shared_ownership_sales_log2.xml index 678d8a71c..50c31ec6f 100644 --- a/spec/fixtures/imports/sales_logs/shared_ownership_sales_log2.xml +++ b/spec/fixtures/imports/sales_logs/shared_ownership_sales_log2.xml @@ -10,6 +10,7 @@ submitted-valid 2022 Bulk Upload + 8dda8f1a-f5a1-4827-8d82-dd7fd9258eab diff --git a/spec/services/imports/lettings_logs_import_service_spec.rb b/spec/services/imports/lettings_logs_import_service_spec.rb index 34f51d7da..bc4bc91b4 100644 --- a/spec/services/imports/lettings_logs_import_service_spec.rb +++ b/spec/services/imports/lettings_logs_import_service_spec.rb @@ -483,20 +483,21 @@ RSpec.describe Imports::LettingsLogsImportService do lettings_log_service.send(:create_log, lettings_log_xml) lettings_log = LettingsLog.find_by(old_id: lettings_log_id) - expect(lettings_log.creation_method).to eq "single log" + expect(lettings_log.creation_method_single_log?).to be true end end context "when the log being imported was bulk uploaded" do before do - lettings_log_xml.at_xpath("//meta:upload-method", { "meta" => "http://data.gov.uk/core/metadata" }).content = "Bulk Upload" + metadata = lettings_log_xml.at_xpath("//meta:metadata", { "meta" => "http://data.gov.uk/core/metadata" }) + metadata << "#{SecureRandom.uuid}" end it "sets the creation method correctly" do lettings_log_service.send(:create_log, lettings_log_xml) lettings_log = LettingsLog.find_by(old_id: lettings_log_id) - expect(lettings_log.creation_method).to eq "bulk upload" + expect(lettings_log.creation_method_bulk_upload?).to be true end end diff --git a/spec/services/imports/sales_logs_import_service_spec.rb b/spec/services/imports/sales_logs_import_service_spec.rb index 6413f4f89..e1b1df082 100644 --- a/spec/services/imports/sales_logs_import_service_spec.rb +++ b/spec/services/imports/sales_logs_import_service_spec.rb @@ -1061,7 +1061,7 @@ RSpec.describe Imports::SalesLogsImportService do sales_log_service.send(:create_log, sales_log_xml) sales_log = SalesLog.find_by(old_id: sales_log_id) - expect(sales_log.creation_method).to eq "single log" + expect(sales_log.creation_method_single_log?).to be true end end @@ -1072,7 +1072,7 @@ RSpec.describe Imports::SalesLogsImportService do sales_log_service.send(:create_log, sales_log_xml) sales_log = SalesLog.find_by(old_id: sales_log_id) - expect(sales_log.creation_method).to eq "bulk upload" + expect(sales_log.creation_method_bulk_upload?).to be true end end