From d7bd4741fcff94344e12e7256aba4ed023068ce2 Mon Sep 17 00:00:00 2001 From: oscar-richardson-softwire Date: Tue, 27 Jan 2026 16:46:03 +0000 Subject: [PATCH] Add comments --- app/models/lettings_log.rb | 2 +- .../services/bulk_upload/lettings/year2026/row_parser_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/lettings_log.rb b/app/models/lettings_log.rb index bf43a3c4d..be742297b 100644 --- a/app/models/lettings_log.rb +++ b/app/models/lettings_log.rb @@ -190,7 +190,7 @@ class LettingsLog < Log location.linked_local_authorities.active(form.start_date).first&.code || location.location_code end - def postcode_full + def postcode_full # TODO: CLDC-4119: Beware! This method may cause issues when testing supported housing log duplicate detection after postcode is added, as it can return `location.postcode` instead of the actual `postcode_full` stored on the log record (`super`). If this happens, investigate why it isn't returning `super`, as it should when `form.start_year_2026_or_later? && super`. return super unless location return super if form.start_year_2026_or_later? && super diff --git a/spec/services/bulk_upload/lettings/year2026/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2026/row_parser_spec.rb index 2f282596c..8187b0a09 100644 --- a/spec/services/bulk_upload/lettings/year2026/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2026/row_parser_spec.rb @@ -296,7 +296,7 @@ RSpec.describe BulkUpload::Lettings::Year2026::RowParser do :field_13, # tenancycode :field_23, # postcode_full :field_24, # postcode_full - :field_25, # postcode_full + :field_25, # LA :field_42, # age1 :field_43, # sex1 :field_46, # ecstat1 @@ -327,7 +327,7 @@ RSpec.describe BulkUpload::Lettings::Year2026::RowParser do end end - context "when a supported housing log already exists in the db" do + context "when a supported housing log already exists in the db" do # TODO: CLDC-4119: Beware! The `postcode_full` method in the `LettingsLog` class may cause issues with these supported housing log duplicate detection tests after postcode is added. See comment on the `postcode_full` method for details. let(:attributes) { valid_attributes.merge({ field_4: "2", field_5: "S#{scheme.id}", field_6: location.old_visible_id, field_36: 3, field_122: 0 }) } before do