Move sales created_by page and question out of common

app/models/form/sales/pages/created_by.rb

@@ -1,4 +1,4 @@
-class Form::Common::Pages::CreatedBy < ::Form::Page
+class Form::Sales::Pages::CreatedBy < ::Form::Page
   def initialize(id, hsh, subsection)
     super
     @id = "created_by"
@@ -6,7 +6,7 @@ class Form::Common::Pages::CreatedBy < ::Form::Page
 
   def questions
     @questions ||= [
-      Form::Common::Questions::CreatedById.new(nil, nil, self),
+      Form::Sales::Questions::CreatedById.new(nil, nil, self),
     ]
   end
 

app/models/form/sales/questions/created_by_id.rb

@@ -1,4 +1,4 @@
-class Form::Common::Questions::CreatedById < ::Form::Question
+class Form::Sales::Questions::CreatedById < ::Form::Question
   ANSWER_OPTS = { "" => "Select an option" }.freeze
 
   def initialize(id, hsh, page)

app/models/form/sales/subsections/setup.rb

@@ -8,7 +8,7 @@ class Form::Sales::Subsections::Setup < ::Form::Subsection
   def pages
     @pages ||= [
       Form::Common::Pages::Organisation.new(nil, nil, self),
-      Form::Common::Pages::CreatedBy.new(nil, nil, self),
+      Form::Sales::Pages::CreatedBy.new(nil, nil, self),
       Form::Sales::Pages::SaleDate.new(nil, nil, self),
       Form::Sales::Pages::SaleDateCheck.new(nil, nil, self),
       Form::Sales::Pages::PurchaserCode.new(nil, nil, self),

spec/models/form/lettings/questions/created_by_id_spec.rb

@@ -129,7 +129,7 @@ RSpec.describe Form::Lettings::Questions::CreatedById, type: :model do
       end
 
       it "only displays users that belong user's org" do
-        expect(question.displayed_answer_options(lettings_log, data_provider)).to eq(Form::Common::Questions::CreatedById::ANSWER_OPTS)
+        expect(question.displayed_answer_options(lettings_log, data_provider)).to eq(Form::Lettings::Questions::CreatedById::ANSWER_OPTS)
       end
     end
   end

spec/models/form/sales/pages/created_by_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe Form::Common::Pages::CreatedBy, type: :model do
+RSpec.describe Form::Sales::Pages::CreatedBy, type: :model do
   subject(:page) { described_class.new(page_id, page_definition, subsection) }
 
   let(:page_id) { nil }

spec/models/form/sales/questions/created_by_id_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe Form::Common::Questions::CreatedById, type: :model do
+RSpec.describe Form::Sales::Questions::CreatedById, type: :model do
   subject(:question) { described_class.new(question_id, question_definition, page) }
 
   let(:question_id) { nil }
@@ -120,7 +120,7 @@ RSpec.describe Form::Common::Questions::CreatedById, type: :model do
       end
 
       it "only displays users that belong user's org" do
-        expect(question.displayed_answer_options(sales_log, data_provider)).to eq(Form::Common::Questions::CreatedById::ANSWER_OPTS)
+        expect(question.displayed_answer_options(sales_log, data_provider)).to eq(Form::Sales::Questions::CreatedById::ANSWER_OPTS)
       end
     end
   end