From d58aff7eb8ddc20958b3de8caf39c1b95a6a5a3d Mon Sep 17 00:00:00 2001 From: Kat Date: Mon, 19 Feb 2024 09:58:32 +0000 Subject: [PATCH] Remove fixed term tenancy validation for periodic --- app/models/lettings_log.rb | 5 +++++ app/models/validations/tenancy_validations.rb | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/models/lettings_log.rb b/app/models/lettings_log.rb index 73df756d0..b5eaf5ffc 100644 --- a/app/models/lettings_log.rb +++ b/app/models/lettings_log.rb @@ -345,6 +345,11 @@ class LettingsLog < Log tenancy == 4 end + def is_periodic_tenancy? + # 8: Periodic + tenancy == 8 + end + def is_internal_transfer? # 1: Internal Transfer referral == 1 diff --git a/app/models/validations/tenancy_validations.rb b/app/models/validations/tenancy_validations.rb index 01281a931..012317f1e 100644 --- a/app/models/validations/tenancy_validations.rb +++ b/app/models/validations/tenancy_validations.rb @@ -24,7 +24,7 @@ module Validations::TenancyValidations ] rent_type_independent_conditions = [ { - condition: !(record.is_secure_tenancy? || record.is_assured_shorthold_tenancy?) && is_present, + condition: !(record.is_secure_tenancy? || record.is_assured_shorthold_tenancy? || record.is_periodic_tenancy?) && is_present, error: I18n.t("validations.tenancy.length.fixed_term_not_required"), }, ]