Refactor people question numbers

app/models/form/lettings/questions/age.rb

@@ -16,10 +16,13 @@ class Form::Lettings::Questions::Age < ::Form::Question
   end
 
   def question_number
-    if form.start_date.year == 2023
+    base_question_number = case form.start_date.year
-      31 + (4 * @person_index)
+                           when 2023
-    else
+                             31
-      30 + (4 * @person_index)
+                           else
-    end
+                             30
+                           end
+
+    base_question_number + (4 * @person_index)
   end
 end

app/models/form/lettings/questions/age_known.rb

@@ -21,6 +21,13 @@ class Form::Lettings::Questions::AgeKnown < ::Form::Question
   ANSWER_OPTIONS = { "0" => { "value" => "Yes" }, "1" => { "value" => "No" } }.freeze
 
   def question_number
-    31 + (4 * @person_index)
+    base_question_number = case form.start_date.year
+                           when 2023
+                             31
+                           else
+                             30
+                           end
+
+    base_question_number + (4 * @person_index)
   end
 end

app/models/form/lettings/questions/person_gender_identity.rb

@@ -27,10 +27,13 @@ class Form::Lettings::Questions::PersonGenderIdentity < ::Form::Question
   end
 
   def question_number
-    if form.start_date.year == 2023
+    base_question_number = case form.start_date.year
-      32 + (4 * @person_index)
+                           when 2023
-    else
+                             32
-      31 + (4 * @person_index)
+                           else
-    end
+                             31
+                           end
+
+    base_question_number + (4 * @person_index)
   end
 end

app/models/form/lettings/questions/person_relationship.rb

@@ -23,10 +23,13 @@ class Form::Lettings::Questions::PersonRelationship < ::Form::Question
   }.freeze
 
   def question_number
-    if form.start_date.year == 2023
+    base_question_number = case form.start_date.year
-      30 + (4 * @person_index)
+                           when 2023
-    else
+                             30
-      29 + (4 * @person_index)
+                           else
-    end
+                             29
+                           end
+
+    base_question_number + (4 * @person_index)
   end
 end

app/models/form/lettings/questions/person_working_situation.rb

@@ -33,10 +33,13 @@ class Form::Lettings::Questions::PersonWorkingSituation < ::Form::Question
   }.freeze
 
   def question_number
-    if form.start_date.year == 2023
+    base_question_number = case form.start_date.year
-      33 + (4 * @person_index)
+                           when 2023
-    else
+                             33
-      32 + (4 * @person_index)
+                           else
-    end
+                             32
+                           end
+
+    base_question_number + (4 * @person_index)
   end
 end