bulk upload 23/24 supports BOM + invalid chars

spec/services/bulk_upload/lettings/year2023/csv_parser_spec.rb

@@ -71,37 +71,31 @@ RSpec.describe BulkUpload::Lettings::Year2023::CsvParser do
     end
   end
 
-  # context "when parsing with BOM aka byte order mark" do
-  #   let(:file) { Tempfile.new }
-  #   let(:path) { file.path }
-  #   let(:log) { build(:lettings_log, :completed) }
-  #   let(:bom) { "\uFEFF" }
-
-  #   before do
-  #     file.write(bom)
-  #     file.write(BulkUpload::LogToCsv.new(log:, col_offset: 0).to_2022_csv_row)
-  #     file.close
-  #   end
-
-  #   it "parses csv correctly" do
-  #     expect(service.row_parsers[0].field_12.to_i).to eql(log.age1)
-  #   end
-  # end
-
-  # context "when an invalid byte sequence" do
-  #   let(:file) { Tempfile.new }
-  #   let(:path) { file.path }
-  #   let(:log) { build(:lettings_log, :completed) }
-  #   let(:invalid_sequence) { "\x81" }
-
-  #   before do
-  #     file.write(invalid_sequence)
-  #     file.write(BulkUpload::LogToCsv.new(log:, col_offset: 0).to_2022_csv_row)
-  #     file.close
-  #   end
-
-  #   it "parses csv correctly" do
-  #     expect(service.row_parsers[0].field_12.to_i).to eql(log.age1)
-  #   end
-  # end
+  context "when parsing with BOM aka byte order mark" do
+    let(:bom) { "\uFEFF" }
+
+    before do
+      file.write(bom)
+      file.write(BulkUpload::LogToCsv.new(log:, col_offset: 0).to_2023_csv_row)
+      file.rewind
+    end
+
+    it "parses csv correctly" do
+      expect(service.row_parsers[0].field_13).to eql(log.tenancycode)
+    end
+  end
+
+  context "when an invalid byte sequence" do
+    let(:invalid_sequence) { "\x81" }
+
+    before do
+      file.write(invalid_sequence)
+      file.write(BulkUpload::LogToCsv.new(log:, col_offset: 0).to_2023_csv_row)
+      file.rewind
+    end
+
+    it "parses csv correctly" do
+      expect(service.row_parsers[0].field_13).to eql(log.tenancycode)
+    end
+  end
 end