feat: remove feature toggle

app/models/validations/setup_validations.rb

@@ -5,7 +5,7 @@ module Validations::SetupValidations
   def validate_startdate_setup(record)
     return unless record.startdate && date_valid?("startdate", record)
 
-    if FeatureToggle.startdate_collection_window_validation_enabled? && !record.startdate.between?(active_collection_start_date, current_collection_end_date)
+    unless record.startdate.between?(active_collection_start_date, current_collection_end_date)  || !FeatureToggle.startdate_collection_window_validation_enabled?
       record.errors.add :startdate, validation_error_message
     end
   end

config/initializers/feature_toggle.rb

@@ -5,7 +5,7 @@ class FeatureToggle
   end
 
   def self.startdate_collection_window_validation_enabled?
-    !Rails.env.test?
+    Rails.env.production? || Rails.env.test? || Rails.env.staging?
   end
 
   def self.startdate_two_week_validation_enabled?

spec/models/validations/setup_validations_spec.rb

@@ -6,10 +6,6 @@ RSpec.describe Validations::SetupValidations do
   let(:setup_validator_class) { Class.new { include Validations::SetupValidations } }
   let(:record) { FactoryBot.create(:lettings_log) }
 
-  before do
-    allow(FeatureToggle).to receive(:startdate_collection_window_validation_enabled?).and_return(true)
-  end
-
   describe "tenancy start date" do
     context "when in 22/23 collection" do
       context "when in the crossover period" do