From c936fc87fb2717ef12120a656e5170bc81a96803 Mon Sep 17 00:00:00 2001 From: oscar-richardson-softwire Date: Tue, 24 Feb 2026 16:51:41 +0000 Subject: [PATCH] Remove redundant logic from infer_at_most_one_relationship! --- app/models/derived_variables/lettings_log_variables.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/models/derived_variables/lettings_log_variables.rb b/app/models/derived_variables/lettings_log_variables.rb index 11a827f4f..718fad0a5 100644 --- a/app/models/derived_variables/lettings_log_variables.rb +++ b/app/models/derived_variables/lettings_log_variables.rb @@ -331,11 +331,9 @@ private def infer_at_most_one_relationship! new_partner_numbers = partner_numbers.select { |i| public_send("relat#{i}_changed?") } - if new_partner_numbers.any? - infer_only_partner!(new_partner_numbers.first) - elsif partner_numbers.any? - infer_only_partner!(partner_numbers.first) - end + return unless new_partner_numbers.any? + + infer_only_partner!(new_partner_numbers.first) end def infer_only_partner!(partner_number)