Browse Source

add placeholder for bulk upload error summary

pull/1242/head
Phil Lee 3 years ago
parent
commit
c7a447bd6f
  1. 4
      app/controllers/bulk_upload_lettings_results_controller.rb
  2. 6
      app/views/bulk_upload_lettings_results/show.html.erb
  3. 44
      app/views/bulk_upload_lettings_results/summary.html.erb
  4. 1
      config/routes.rb
  5. 17
      spec/requests/bulk_upload_lettings_results_controller_spec.rb

4
app/controllers/bulk_upload_lettings_results_controller.rb

@ -19,6 +19,10 @@ class BulkUploadLettingsResultsController < ApplicationController
end end
end end
def summary
@bulk_upload = current_user.bulk_uploads.lettings.find(params[:id])
end
private private
def reset_logs_filters def reset_logs_filters

6
app/views/bulk_upload_lettings_results/show.html.erb

@ -1,6 +1,10 @@
<% content_for :before_content do %>
<%= govuk_back_link(text: "Back", href: summary_bulk_upload_lettings_result_path(@bulk_upload)) %>
<% end %>
<div class="govuk-grid-row"> <div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds"> <div class="govuk-grid-column-two-thirds">
<span class="govuk-caption-l">Bulk Upload for lettings (<%= @bulk_upload.year_combo %>)</span> <span class="govuk-caption-l">Bulk upload for lettings (<%= @bulk_upload.year_combo %>)</span>
<h1 class="govuk-heading-l">We found <%= pluralize(@bulk_upload.bulk_upload_errors.count, "error") %> in your file</h1> <h1 class="govuk-heading-l">We found <%= pluralize(@bulk_upload.bulk_upload_errors.count, "error") %> in your file</h1>
<div class="govuk-body"> <div class="govuk-body">

44
app/views/bulk_upload_lettings_results/summary.html.erb

@ -0,0 +1,44 @@
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<span class="govuk-caption-l">Bulk upload for lettings (<%= @bulk_upload.year_combo %>)</span>
<h1 class="govuk-heading-l">Correct data export and reupload</h1>
<p class="govuk-body-l">
We noticed that you have a lot of similar errors for some questions. You can download the specification which we reference below to understand how to correct the data. Once you have fixed these errors you can upload again.
</p>
</div>
</div>
<%= govuk_table do |table| %>
<% table.caption(size: "m", text: @bulk_upload.filename) %>
<% table.head do |head| %>
<% head.row do |row| %>
<% row.cell(text: "Column", header: true) %>
<% row.cell(text: "Number of rows", header: true) %>
<% row.cell(text: "Question", header: true) %>
<% row.cell(text: "Error", header: true) %>
<% row.cell(text: "Specification", header: true) %>
<% end %>
<% end %>
<% table.body do |body| %>
<% body.row do |row| %>
<% row.cell(text: "Bulbasaur") %>
<% row.cell(text: "Bulbasaur") %>
<% row.cell(text: "Bulbasaur") %>
<% row.cell(text: "Bulbasaur") %>
<% row.cell(text: "Bulbasaur") %>
<% end %>
<% end %>
<% end %>
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<p class="govuk-body">
You also have other errors in your file which you can either fix them in the CSV file or you can reupload and fix on CORE. <%= govuk_link_to "View the full report", bulk_upload_lettings_result_path(@bulk_upload) %>
</p>
</div>
</div>
<%= govuk_button_link_to "Upload your file again", start_bulk_upload_lettings_logs_path %>

1
config/routes.rb

@ -137,6 +137,7 @@ Rails.application.routes.draw do
resources :bulk_upload_lettings_results, path: "bulk-upload-results", only: [:show] do resources :bulk_upload_lettings_results, path: "bulk-upload-results", only: [:show] do
member do member do
get :resume get :resume
get :summary
end end
end end

17
spec/requests/bulk_upload_lettings_results_controller_spec.rb

@ -9,12 +9,27 @@ RSpec.describe BulkUploadLettingsResultsController, type: :request do
sign_in user sign_in user
end end
describe "GET /lettings-logs/bulk-upload-results/:ID/summary" do
it "renders year combo" do
get "/lettings-logs/bulk-upload-results/#{bulk_upload.id}/summary"
expect(response).to be_successful
expect(response.body).to include("Bulk upload for lettings (2022/23)")
end
it "renders the bulk upload filename" do
get "/lettings-logs/bulk-upload-results/#{bulk_upload.id}/summary"
expect(response.body).to include(bulk_upload.filename)
end
end
describe "GET /lettings-logs/bulk-upload-results/:ID" do describe "GET /lettings-logs/bulk-upload-results/:ID" do
it "renders correct year" do it "renders correct year" do
get "/lettings-logs/bulk-upload-results/#{bulk_upload.id}" get "/lettings-logs/bulk-upload-results/#{bulk_upload.id}"
expect(response).to be_successful expect(response).to be_successful
expect(response.body).to include("Bulk Upload for lettings (2022/23)") expect(response.body).to include("Bulk upload for lettings (2022/23)")
end end
it "renders correct number of errors" do it "renders correct number of errors" do

Loading…
Cancel
Save