From c45f970c86178d61dcd8fad9e8bd9451904f163d Mon Sep 17 00:00:00 2001 From: oscar-richardson-softwire Date: Tue, 10 Feb 2026 16:56:58 +0000 Subject: [PATCH] Convert 'else next' to guard clause --- .../derived_variables/lettings_log_variables.rb | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/app/models/derived_variables/lettings_log_variables.rb b/app/models/derived_variables/lettings_log_variables.rb index 762b27f0b..19c88aeda 100644 --- a/app/models/derived_variables/lettings_log_variables.rb +++ b/app/models/derived_variables/lettings_log_variables.rb @@ -352,14 +352,12 @@ private def reset_partner_fields! person_count = hhmemb || 8 (2..person_count).each do |i| - if send("relat#{i}_changed?") && send("relat#{i}_was") == "P" - ((i + 1)..person_count).each do |j| - if self["relat#{j}"] == "X" - self["relat#{j}"] = nil - end + next unless send("relat#{i}_changed?") && send("relat#{i}_was") == "P" + + ((i + 1)..person_count).each do |j| + if self["relat#{j}"] == "X" + self["relat#{j}"] = nil end - else - next end end end