From c1ac3c71cda80e1c7db482fc38bd2a34373199b1 Mon Sep 17 00:00:00 2001 From: samyou-softwire Date: Thu, 23 Apr 2026 15:14:12 +0100 Subject: [PATCH] CLDC-4300: Compare lasttransaction to saledate due to the it <= lt <= sd relationship, there's no need to comparse it to sd. if it == sd then it == lt and lt == sd --- ..._logs_with_invalid_initialpurchase_lasttransaction.rake | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/tasks/fix_sales_logs_with_invalid_initialpurchase_lasttransaction.rake b/lib/tasks/fix_sales_logs_with_invalid_initialpurchase_lasttransaction.rake index 54cae2ff2..16d5571e5 100644 --- a/lib/tasks/fix_sales_logs_with_invalid_initialpurchase_lasttransaction.rake +++ b/lib/tasks/fix_sales_logs_with_invalid_initialpurchase_lasttransaction.rake @@ -1,11 +1,10 @@ desc "We tightened the validation between initial purchase date in 2026, last transaction date and sale date so the two can no longer be equal. To avoid invalid logs we clear initialpurchase if it equals saledate and if initialpurchase = lasttransaction we clear both" task fix_sales_logs_with_invalid_initialpurchase_lasttransaction: :environment do - initial_purchase_equal_saledate_logs = SalesLog.filter_by_year_or_later(2026).where("initialpurchase = saledate") + lasttransaction_equal_saledate_logs = SalesLog.filter_by_year_or_later(2026).where("lasttransaction = saledate") initial_purchase_equal_lasttransaction_logs = SalesLog.filter_by_year_or_later(2026).where("initialpurchase = lasttransaction") - puts "Updating #{initial_purchase_equal_saledate_logs.count} logs where initialpurchase = saledate, #{initial_purchase_equal_saledate_logs.map(&:id)}" - - initial_purchase_equal_saledate_logs.update!(initialpurchase: nil) + puts "Updating #{lasttransaction_equal_saledate_logs.count} logs where lasttransaction = saledate, #{lasttransaction_equal_saledate_logs.map(&:id)}" + lasttransaction_equal_saledate_logs.update!(lasttransaction: nil) puts "Updating #{initial_purchase_equal_lasttransaction_logs.count} logs where initialpurchase = lasttransaction, #{initial_purchase_equal_lasttransaction_logs.map(&:id)}" initial_purchase_equal_lasttransaction_logs.update!(initialpurchase: nil, lasttransaction: nil)