From c0a5a8748f29d122c3890c001998582ad4945c4e Mon Sep 17 00:00:00 2001 From: Sam Seed Date: Mon, 24 Apr 2023 12:10:52 +0100 Subject: [PATCH] feat: output "this question" if qu has no header or check_answer_label --- app/services/bulk_upload/lettings/year2023/row_parser.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/services/bulk_upload/lettings/year2023/row_parser.rb b/app/services/bulk_upload/lettings/year2023/row_parser.rb index 284163ede..7605d8d9f 100644 --- a/app/services/bulk_upload/lettings/year2023/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2023/row_parser.rb @@ -542,14 +542,14 @@ private if setup_question?(question) fields.each do |field| if errors[field].present? - question_text = question.check_answer_label.presence || question.header + question_text = question.check_answer_label.presence || question.header || "this question" errors.add(field, I18n.t("validations.not_answered", question: question_text&.downcase), category: :setup) end end else fields.each do |field| unless errors.any? { |e| fields.include?(e.attribute) } - question_text = question.check_answer_label.presence || question.header + question_text = question.check_answer_label.presence || question.header || "this question" errors.add(field, I18n.t("validations.not_answered", question: question_text&.downcase)) end end