From c07dda80a5c73f7bdd75d36360c20d460885d7c9 Mon Sep 17 00:00:00 2001 From: Kat Date: Wed, 21 Feb 2024 08:45:23 +0000 Subject: [PATCH] Add a default question number --- app/models/form/sales/questions/address_line1.rb | 2 +- app/models/form/sales/questions/age1.rb | 2 +- app/models/form/sales/questions/age2.rb | 2 +- app/models/form/sales/questions/armed_forces.rb | 2 +- app/models/form/sales/questions/armed_forces_spouse.rb | 2 +- app/models/form/sales/questions/buyer1_age_known.rb | 2 +- .../form/sales/questions/buyer1_ethnic_background_arab.rb | 2 +- .../form/sales/questions/buyer1_ethnic_background_asian.rb | 2 +- .../form/sales/questions/buyer1_ethnic_background_black.rb | 2 +- .../form/sales/questions/buyer1_ethnic_background_mixed.rb | 2 +- .../form/sales/questions/buyer1_ethnic_background_white.rb | 2 +- app/models/form/sales/questions/buyer1_ethnic_group.rb | 2 +- app/models/form/sales/questions/buyer1_income.rb | 2 +- app/models/form/sales/questions/buyer1_income_known.rb | 2 +- app/models/form/sales/questions/buyer1_live_in_property.rb | 2 +- app/models/form/sales/questions/buyer1_mortgage.rb | 2 +- app/models/form/sales/questions/buyer1_nationality.rb | 2 +- app/models/form/sales/questions/buyer1_previous_tenure.rb | 2 +- app/models/form/sales/questions/buyer1_working_situation.rb | 2 +- app/models/form/sales/questions/buyer2_age_known.rb | 2 +- .../form/sales/questions/buyer2_ethnic_background_arab.rb | 2 +- .../form/sales/questions/buyer2_ethnic_background_asian.rb | 2 +- .../form/sales/questions/buyer2_ethnic_background_black.rb | 2 +- .../form/sales/questions/buyer2_ethnic_background_mixed.rb | 2 +- .../form/sales/questions/buyer2_ethnic_background_white.rb | 2 +- app/models/form/sales/questions/buyer2_ethnic_group.rb | 2 +- app/models/form/sales/questions/buyer2_income.rb | 2 +- app/models/form/sales/questions/buyer2_income_known.rb | 2 +- app/models/form/sales/questions/buyer2_live_in_property.rb | 2 +- app/models/form/sales/questions/buyer2_living_in.rb | 2 +- app/models/form/sales/questions/buyer2_mortgage.rb | 2 +- app/models/form/sales/questions/buyer2_nationality.rb | 2 +- .../form/sales/questions/buyer2_relationship_to_buyer1.rb | 2 +- app/models/form/sales/questions/buyer2_working_situation.rb | 2 +- app/models/form/sales/questions/buyer_company.rb | 2 +- app/models/form/sales/questions/buyer_interview.rb | 2 +- app/models/form/sales/questions/buyer_live.rb | 2 +- app/models/form/sales/questions/buyer_previous.rb | 2 +- app/models/form/sales/questions/buyer_still_serving.rb | 2 +- app/models/form/sales/questions/buyers_organisations.rb | 2 +- app/models/form/sales/questions/county.rb | 2 +- app/models/form/sales/questions/deposit_amount.rb | 2 +- app/models/form/sales/questions/deposit_discount.rb | 2 +- app/models/form/sales/questions/discount.rb | 2 +- app/models/form/sales/questions/discounted_ownership_type.rb | 2 +- app/models/form/sales/questions/equity.rb | 2 +- app/models/form/sales/questions/exchange_date.rb | 2 +- app/models/form/sales/questions/extra_borrowing.rb | 2 +- app/models/form/sales/questions/fromprop.rb | 2 +- app/models/form/sales/questions/gender_identity1.rb | 2 +- app/models/form/sales/questions/gender_identity2.rb | 2 +- app/models/form/sales/questions/grant.rb | 2 +- app/models/form/sales/questions/handover_date.rb | 2 +- app/models/form/sales/questions/household_disability.rb | 2 +- app/models/form/sales/questions/household_wheelchair.rb | 2 +- app/models/form/sales/questions/housing_benefits.rb | 2 +- app/models/form/sales/questions/joint_purchase.rb | 2 +- app/models/form/sales/questions/la_nominations.rb | 2 +- app/models/form/sales/questions/leasehold_charges.rb | 2 +- app/models/form/sales/questions/living_before_purchase.rb | 2 +- app/models/form/sales/questions/managing_organisation.rb | 2 +- app/models/form/sales/questions/monthly_rent.rb | 2 +- app/models/form/sales/questions/mortgage_amount.rb | 2 +- app/models/form/sales/questions/mortgage_lender.rb | 2 +- app/models/form/sales/questions/mortgage_length.rb | 2 +- app/models/form/sales/questions/mortgageused.rb | 2 +- app/models/form/sales/questions/number_joint_buyers.rb | 2 +- .../form/sales/questions/number_of_others_in_property.rb | 2 +- app/models/form/sales/questions/other_ownership_type.rb | 2 +- app/models/form/sales/questions/outright_ownership_type.rb | 2 +- app/models/form/sales/questions/ownership_scheme.rb | 2 +- app/models/form/sales/questions/owning_organisation_id.rb | 4 ++-- app/models/form/sales/questions/postcode_for_full_address.rb | 2 +- app/models/form/sales/questions/previous_bedrooms.rb | 2 +- app/models/form/sales/questions/previous_la_known.rb | 2 +- app/models/form/sales/questions/previous_postcode.rb | 2 +- app/models/form/sales/questions/previous_postcode_known.rb | 2 +- app/models/form/sales/questions/previous_tenure.rb | 2 +- app/models/form/sales/questions/previous_tenure_buyer2.rb | 2 +- app/models/form/sales/questions/prevloc.rb | 2 +- app/models/form/sales/questions/prevown.rb | 2 +- app/models/form/sales/questions/prevshared.rb | 2 +- app/models/form/sales/questions/privacy_notice.rb | 4 ++-- app/models/form/sales/questions/property_building_type.rb | 2 +- app/models/form/sales/questions/property_local_authority.rb | 2 +- .../form/sales/questions/property_local_authority_known.rb | 2 +- .../form/sales/questions/property_number_of_bedrooms.rb | 2 +- app/models/form/sales/questions/property_unit_type.rb | 2 +- .../form/sales/questions/property_wheelchair_accessible.rb | 2 +- app/models/form/sales/questions/purchase_price.rb | 2 +- app/models/form/sales/questions/purchaser_code.rb | 2 +- app/models/form/sales/questions/resale.rb | 2 +- app/models/form/sales/questions/sale_date.rb | 2 +- app/models/form/sales/questions/savings.rb | 2 +- app/models/form/sales/questions/savings_nk.rb | 2 +- app/models/form/sales/questions/shared_ownership_type.rb | 2 +- app/models/form/sales/questions/staircase.rb | 2 +- app/models/form/sales/questions/staircase_bought.rb | 2 +- app/models/form/sales/questions/staircase_owned.rb | 2 +- app/models/form/sales/questions/staircase_sale.rb | 2 +- app/models/form/sales/questions/town_or_city.rb | 2 +- app/models/form/sales/questions/uprn.rb | 2 +- app/models/form/sales/questions/value.rb | 2 +- 103 files changed, 105 insertions(+), 105 deletions(-) diff --git a/app/models/form/sales/questions/address_line1.rb b/app/models/form/sales/questions/address_line1.rb index fc30e2d7f..208cf7136 100644 --- a/app/models/form/sales/questions/address_line1.rb +++ b/app/models/form/sales/questions/address_line1.rb @@ -8,7 +8,7 @@ class Form::Sales::Questions::AddressLine1 < ::Form::Question @plain_label = true @check_answer_label = "Address lines 1 and 2" @disable_clearing_if_not_routed_or_dynamic_answer_options = true - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @hide_question_number_on_page = true end diff --git a/app/models/form/sales/questions/age1.rb b/app/models/form/sales/questions/age1.rb index a8e51817d..fdaada0f8 100644 --- a/app/models/form/sales/questions/age1.rb +++ b/app/models/form/sales/questions/age1.rb @@ -20,7 +20,7 @@ class Form::Sales::Questions::Age1 < ::Form::Question @min = 16 @max = 110 @step = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 20, 2024 => 22 }.freeze diff --git a/app/models/form/sales/questions/age2.rb b/app/models/form/sales/questions/age2.rb index 93787fef3..ae6d9694e 100644 --- a/app/models/form/sales/questions/age2.rb +++ b/app/models/form/sales/questions/age2.rb @@ -14,7 +14,7 @@ class Form::Sales::Questions::Age2 < ::Form::Question @max = 110 @min = 0 @step = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 28, 2024 => 30 }.freeze diff --git a/app/models/form/sales/questions/armed_forces.rb b/app/models/form/sales/questions/armed_forces.rb index ccbc9f3b3..8f0d45673 100644 --- a/app/models/form/sales/questions/armed_forces.rb +++ b/app/models/form/sales/questions/armed_forces.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::ArmedForces < ::Form::Question @type = "radio" @hint_text = "A regular is somebody who has served in the Royal Navy, the Royal Marines, the Royal Airforce or Army full time and does not include reserve forces" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/armed_forces_spouse.rb b/app/models/form/sales/questions/armed_forces_spouse.rb index 6d3ddb4bf..69e2f016a 100644 --- a/app/models/form/sales/questions/armed_forces_spouse.rb +++ b/app/models/form/sales/questions/armed_forces_spouse.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::ArmedForcesSpouse < ::Form::Question @header = "Are any of the buyers a spouse or civil partner of a UK armed forces regular who died in service within the last 2 years?" @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer1_age_known.rb b/app/models/form/sales/questions/buyer1_age_known.rb index 0b8f9e0a9..d1f1f227f 100644 --- a/app/models/form/sales/questions/buyer1_age_known.rb +++ b/app/models/form/sales/questions/buyer1_age_known.rb @@ -24,7 +24,7 @@ class Form::Sales::Questions::Buyer1AgeKnown < ::Form::Question ], } @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer1_ethnic_background_arab.rb b/app/models/form/sales/questions/buyer1_ethnic_background_arab.rb index 92b5b6cca..8f5dc95e1 100644 --- a/app/models/form/sales/questions/buyer1_ethnic_background_arab.rb +++ b/app/models/form/sales/questions/buyer1_ethnic_background_arab.rb @@ -8,7 +8,7 @@ class Form::Sales::Questions::Buyer1EthnicBackgroundArab < ::Form::Question @answer_options = ANSWER_OPTIONS @hint_text = "Buyer 1 is the person in the household who does the most paid work. If it’s a joint purchase and the buyers do the same amount of paid work, buyer 1 is whoever is the oldest." @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer1_ethnic_background_asian.rb b/app/models/form/sales/questions/buyer1_ethnic_background_asian.rb index 36825f8da..a58cf6bef 100644 --- a/app/models/form/sales/questions/buyer1_ethnic_background_asian.rb +++ b/app/models/form/sales/questions/buyer1_ethnic_background_asian.rb @@ -8,7 +8,7 @@ class Form::Sales::Questions::Buyer1EthnicBackgroundAsian < ::Form::Question @answer_options = ANSWER_OPTIONS @hint_text = "Buyer 1 is the person in the household who does the most paid work. If it’s a joint purchase and the buyers do the same amount of paid work, buyer 1 is whoever is the oldest." @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer1_ethnic_background_black.rb b/app/models/form/sales/questions/buyer1_ethnic_background_black.rb index d9f1f1d1a..b1500c933 100644 --- a/app/models/form/sales/questions/buyer1_ethnic_background_black.rb +++ b/app/models/form/sales/questions/buyer1_ethnic_background_black.rb @@ -8,7 +8,7 @@ class Form::Sales::Questions::Buyer1EthnicBackgroundBlack < ::Form::Question @answer_options = ANSWER_OPTIONS @hint_text = "Buyer 1 is the person in the household who does the most paid work. If it’s a joint purchase and the buyers do the same amount of paid work, buyer 1 is whoever is the oldest." @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer1_ethnic_background_mixed.rb b/app/models/form/sales/questions/buyer1_ethnic_background_mixed.rb index f38f7cb6a..0c61a817e 100644 --- a/app/models/form/sales/questions/buyer1_ethnic_background_mixed.rb +++ b/app/models/form/sales/questions/buyer1_ethnic_background_mixed.rb @@ -8,7 +8,7 @@ class Form::Sales::Questions::Buyer1EthnicBackgroundMixed < ::Form::Question @answer_options = ANSWER_OPTIONS @hint_text = "Buyer 1 is the person in the household who does the most paid work. If it’s a joint purchase and the buyers do the same amount of paid work, buyer 1 is whoever is the oldest." @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer1_ethnic_background_white.rb b/app/models/form/sales/questions/buyer1_ethnic_background_white.rb index 13a4e3bcb..4077eb0f8 100644 --- a/app/models/form/sales/questions/buyer1_ethnic_background_white.rb +++ b/app/models/form/sales/questions/buyer1_ethnic_background_white.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Buyer1EthnicBackgroundWhite < ::Form::Question @type = "radio" @hint_text = form.start_year_after_2024? ? "" : "Buyer 1 is the person in the household who does the most paid work. If it’s a joint purchase and the buyers do the same amount of paid work, buyer 1 is whoever is the oldest." @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end def answer_options diff --git a/app/models/form/sales/questions/buyer1_ethnic_group.rb b/app/models/form/sales/questions/buyer1_ethnic_group.rb index 67a5e88d5..8ed608777 100644 --- a/app/models/form/sales/questions/buyer1_ethnic_group.rb +++ b/app/models/form/sales/questions/buyer1_ethnic_group.rb @@ -8,7 +8,7 @@ class Form::Sales::Questions::Buyer1EthnicGroup < ::Form::Question @answer_options = ANSWER_OPTIONS @hint_text = "Buyer 1 is the person in the household who does the most paid work. If it’s a joint purchase and the buyers do the same amount of paid work, buyer 1 is whoever is the oldest." @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer1_income.rb b/app/models/form/sales/questions/buyer1_income.rb index 72ec7e254..e6c3a9784 100644 --- a/app/models/form/sales/questions/buyer1_income.rb +++ b/app/models/form/sales/questions/buyer1_income.rb @@ -12,7 +12,7 @@ class Form::Sales::Questions::Buyer1Income < ::Form::Question @width = 5 @prefix = "£" @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 67, 2024 => 69 }.freeze diff --git a/app/models/form/sales/questions/buyer1_income_known.rb b/app/models/form/sales/questions/buyer1_income_known.rb index 97f8d13a7..cd1d69500 100644 --- a/app/models/form/sales/questions/buyer1_income_known.rb +++ b/app/models/form/sales/questions/buyer1_income_known.rb @@ -10,7 +10,7 @@ class Form::Sales::Questions::Buyer1IncomeKnown < ::Form::Question "income1" => [0], } @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @hidden_in_check_answers = { "depends_on" => [ { diff --git a/app/models/form/sales/questions/buyer1_live_in_property.rb b/app/models/form/sales/questions/buyer1_live_in_property.rb index a4570c4bb..d05ef05bb 100644 --- a/app/models/form/sales/questions/buyer1_live_in_property.rb +++ b/app/models/form/sales/questions/buyer1_live_in_property.rb @@ -8,7 +8,7 @@ class Form::Sales::Questions::Buyer1LiveInProperty < ::Form::Question @answer_options = ANSWER_OPTIONS @hint_text = "Buyer 1 is the person in the household who does the most paid work. If it’s a joint purchase and the buyers do the same amount of paid work, buyer 1 is whoever is the oldest." @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer1_mortgage.rb b/app/models/form/sales/questions/buyer1_mortgage.rb index 8faf858b5..48b654b71 100644 --- a/app/models/form/sales/questions/buyer1_mortgage.rb +++ b/app/models/form/sales/questions/buyer1_mortgage.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Buyer1Mortgage < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer1_nationality.rb b/app/models/form/sales/questions/buyer1_nationality.rb index e1804736b..c6756ad16 100644 --- a/app/models/form/sales/questions/buyer1_nationality.rb +++ b/app/models/form/sales/questions/buyer1_nationality.rb @@ -14,7 +14,7 @@ class Form::Sales::Questions::Buyer1Nationality < ::Form::Question }, "value" => "Prefers not to say", }] - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer1_previous_tenure.rb b/app/models/form/sales/questions/buyer1_previous_tenure.rb index bf34c73a1..457311081 100644 --- a/app/models/form/sales/questions/buyer1_previous_tenure.rb +++ b/app/models/form/sales/questions/buyer1_previous_tenure.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::Buyer1PreviousTenure < ::Form::Question @header = "What was buyer 1’s previous tenure?" @type = "radio" @answer_options = answer_options - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end def answer_options diff --git a/app/models/form/sales/questions/buyer1_working_situation.rb b/app/models/form/sales/questions/buyer1_working_situation.rb index c333d0bd3..bd9b0cc75 100644 --- a/app/models/form/sales/questions/buyer1_working_situation.rb +++ b/app/models/form/sales/questions/buyer1_working_situation.rb @@ -14,7 +14,7 @@ class Form::Sales::Questions::Buyer1WorkingSituation < ::Form::Question }, "value" => "Prefers not to say", }] - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer2_age_known.rb b/app/models/form/sales/questions/buyer2_age_known.rb index 1d6b62156..3a5086532 100644 --- a/app/models/form/sales/questions/buyer2_age_known.rb +++ b/app/models/form/sales/questions/buyer2_age_known.rb @@ -20,7 +20,7 @@ class Form::Sales::Questions::Buyer2AgeKnown < ::Form::Question ], } @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer2_ethnic_background_arab.rb b/app/models/form/sales/questions/buyer2_ethnic_background_arab.rb index 55ea7e69e..076b73079 100644 --- a/app/models/form/sales/questions/buyer2_ethnic_background_arab.rb +++ b/app/models/form/sales/questions/buyer2_ethnic_background_arab.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Buyer2EthnicBackgroundArab < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer2_ethnic_background_asian.rb b/app/models/form/sales/questions/buyer2_ethnic_background_asian.rb index 950b7c83e..69ae0bfda 100644 --- a/app/models/form/sales/questions/buyer2_ethnic_background_asian.rb +++ b/app/models/form/sales/questions/buyer2_ethnic_background_asian.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Buyer2EthnicBackgroundAsian < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer2_ethnic_background_black.rb b/app/models/form/sales/questions/buyer2_ethnic_background_black.rb index 815893590..6f5d0f8b9 100644 --- a/app/models/form/sales/questions/buyer2_ethnic_background_black.rb +++ b/app/models/form/sales/questions/buyer2_ethnic_background_black.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Buyer2EthnicBackgroundBlack < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer2_ethnic_background_mixed.rb b/app/models/form/sales/questions/buyer2_ethnic_background_mixed.rb index 83c6841a3..83bce6dc7 100644 --- a/app/models/form/sales/questions/buyer2_ethnic_background_mixed.rb +++ b/app/models/form/sales/questions/buyer2_ethnic_background_mixed.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Buyer2EthnicBackgroundMixed < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer2_ethnic_background_white.rb b/app/models/form/sales/questions/buyer2_ethnic_background_white.rb index 53d2079a0..76343eab8 100644 --- a/app/models/form/sales/questions/buyer2_ethnic_background_white.rb +++ b/app/models/form/sales/questions/buyer2_ethnic_background_white.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::Buyer2EthnicBackgroundWhite < ::Form::Question @header = "Which of the following best describes buyer 2’s White background?" @type = "radio" @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end def answer_options diff --git a/app/models/form/sales/questions/buyer2_ethnic_group.rb b/app/models/form/sales/questions/buyer2_ethnic_group.rb index 15515084d..90f17c693 100644 --- a/app/models/form/sales/questions/buyer2_ethnic_group.rb +++ b/app/models/form/sales/questions/buyer2_ethnic_group.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Buyer2EthnicGroup < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer2_income.rb b/app/models/form/sales/questions/buyer2_income.rb index b90b47403..3ada01eb0 100644 --- a/app/models/form/sales/questions/buyer2_income.rb +++ b/app/models/form/sales/questions/buyer2_income.rb @@ -12,7 +12,7 @@ class Form::Sales::Questions::Buyer2Income < ::Form::Question @width = 5 @prefix = "£" @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 69, 2024 => 71 }.freeze diff --git a/app/models/form/sales/questions/buyer2_income_known.rb b/app/models/form/sales/questions/buyer2_income_known.rb index 0e379dc30..b6dd941a8 100644 --- a/app/models/form/sales/questions/buyer2_income_known.rb +++ b/app/models/form/sales/questions/buyer2_income_known.rb @@ -10,7 +10,7 @@ class Form::Sales::Questions::Buyer2IncomeKnown < ::Form::Question "income2" => [0], } @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @hidden_in_check_answers = { "depends_on" => [ { diff --git a/app/models/form/sales/questions/buyer2_live_in_property.rb b/app/models/form/sales/questions/buyer2_live_in_property.rb index fbe7c4228..50bdff047 100644 --- a/app/models/form/sales/questions/buyer2_live_in_property.rb +++ b/app/models/form/sales/questions/buyer2_live_in_property.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Buyer2LiveInProperty < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer2_living_in.rb b/app/models/form/sales/questions/buyer2_living_in.rb index f7945a8bb..1d15fe5eb 100644 --- a/app/models/form/sales/questions/buyer2_living_in.rb +++ b/app/models/form/sales/questions/buyer2_living_in.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Buyer2LivingIn < ::Form::Question @type = "radio" @hint_text = "" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer2_mortgage.rb b/app/models/form/sales/questions/buyer2_mortgage.rb index 8c044aad3..70e3f0f8b 100644 --- a/app/models/form/sales/questions/buyer2_mortgage.rb +++ b/app/models/form/sales/questions/buyer2_mortgage.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Buyer2Mortgage < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer2_nationality.rb b/app/models/form/sales/questions/buyer2_nationality.rb index 77bc34a8e..2736a2abe 100644 --- a/app/models/form/sales/questions/buyer2_nationality.rb +++ b/app/models/form/sales/questions/buyer2_nationality.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Buyer2Nationality < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 2 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @inferred_check_answers_value = [{ "condition" => { "national" => 13, diff --git a/app/models/form/sales/questions/buyer2_relationship_to_buyer1.rb b/app/models/form/sales/questions/buyer2_relationship_to_buyer1.rb index e86414cc8..9048c0dea 100644 --- a/app/models/form/sales/questions/buyer2_relationship_to_buyer1.rb +++ b/app/models/form/sales/questions/buyer2_relationship_to_buyer1.rb @@ -13,7 +13,7 @@ class Form::Sales::Questions::Buyer2RelationshipToBuyer1 < ::Form::Question }, "value" => "Prefers not to say", }] - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer2_working_situation.rb b/app/models/form/sales/questions/buyer2_working_situation.rb index fae2577db..4795bc2b2 100644 --- a/app/models/form/sales/questions/buyer2_working_situation.rb +++ b/app/models/form/sales/questions/buyer2_working_situation.rb @@ -13,7 +13,7 @@ class Form::Sales::Questions::Buyer2WorkingSituation < ::Form::Question }, "value" => "Prefers not to say", }] - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer_company.rb b/app/models/form/sales/questions/buyer_company.rb index 40684ca16..9dc1f1066 100644 --- a/app/models/form/sales/questions/buyer_company.rb +++ b/app/models/form/sales/questions/buyer_company.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::BuyerCompany < ::Form::Question @header = "Is the buyer a company?" @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer_interview.rb b/app/models/form/sales/questions/buyer_interview.rb index 3e2dba602..e86aabcf3 100644 --- a/app/models/form/sales/questions/buyer_interview.rb +++ b/app/models/form/sales/questions/buyer_interview.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::BuyerInterview < ::Form::Question @type = "radio" @hint_text = "You should still try to answer all questions even if the #{joint_purchase ? 'buyers weren’t' : 'buyer wasn’t'} interviewed in person" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer_live.rb b/app/models/form/sales/questions/buyer_live.rb index d774f42dc..1d1ee004e 100644 --- a/app/models/form/sales/questions/buyer_live.rb +++ b/app/models/form/sales/questions/buyer_live.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::BuyerLive < ::Form::Question @header = form.start_year_after_2024? ? "Will any buyers live in the property?" : "Will the buyers live in the property?" @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer_previous.rb b/app/models/form/sales/questions/buyer_previous.rb index 55f6b8162..2b00011fa 100644 --- a/app/models/form/sales/questions/buyer_previous.rb +++ b/app/models/form/sales/questions/buyer_previous.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::BuyerPrevious < ::Form::Question @header = I18n.t("questions.soctenant", count: joint_purchase ? 2 : 1) @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyer_still_serving.rb b/app/models/form/sales/questions/buyer_still_serving.rb index aa5193da1..f2efb5309 100644 --- a/app/models/form/sales/questions/buyer_still_serving.rb +++ b/app/models/form/sales/questions/buyer_still_serving.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::BuyerStillServing < ::Form::Question @header = "Is the buyer still serving in the UK armed forces?" @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/buyers_organisations.rb b/app/models/form/sales/questions/buyers_organisations.rb index faa4adcaa..582fb5270 100644 --- a/app/models/form/sales/questions/buyers_organisations.rb +++ b/app/models/form/sales/questions/buyers_organisations.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::BuyersOrganisations < ::Form::Question @type = "checkbox" @hint_text = "Select all that apply. This question is optional. If no options are applicable, leave the options blank, and select save and continue." @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/county.rb b/app/models/form/sales/questions/county.rb index 68fede0cf..9d0cc5203 100644 --- a/app/models/form/sales/questions/county.rb +++ b/app/models/form/sales/questions/county.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::County < ::Form::Question @plain_label = true @check_answer_label = "County" @disable_clearing_if_not_routed_or_dynamic_answer_options = true - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @hide_question_number_on_page = true end diff --git a/app/models/form/sales/questions/deposit_amount.rb b/app/models/form/sales/questions/deposit_amount.rb index 26aa1b291..1fc98b82a 100644 --- a/app/models/form/sales/questions/deposit_amount.rb +++ b/app/models/form/sales/questions/deposit_amount.rb @@ -12,7 +12,7 @@ class Form::Sales::Questions::DepositAmount < ::Form::Question @prefix = "£" @derived = true @ownershipsch = ownershipsch - @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year][ownershipsch] if QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year].present? + @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.max_by { |k, _v| k }.last)[ownershipsch] @optional = optional end diff --git a/app/models/form/sales/questions/deposit_discount.rb b/app/models/form/sales/questions/deposit_discount.rb index d945f5337..70a8a051a 100644 --- a/app/models/form/sales/questions/deposit_discount.rb +++ b/app/models/form/sales/questions/deposit_discount.rb @@ -11,7 +11,7 @@ class Form::Sales::Questions::DepositDiscount < ::Form::Question @width = 5 @prefix = "£" @hint_text = "Enter the total cash discount given on the property being purchased through the Social HomeBuy scheme" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 96, 2024 => 98 }.freeze diff --git a/app/models/form/sales/questions/discount.rb b/app/models/form/sales/questions/discount.rb index 7b8618c6c..bb5f15276 100644 --- a/app/models/form/sales/questions/discount.rb +++ b/app/models/form/sales/questions/discount.rb @@ -13,7 +13,7 @@ class Form::Sales::Questions::Discount < ::Form::Question @hint_text = "For Right to Buy (RTB), Preserved Right to Buy (PRTB), and Voluntary Right to Buy (VRTB)

If discount capped, enter capped %

If the property is being sold to an existing tenant under the RTB, PRTB, or VRTB schemes, enter the % discount from the full market value that is being given." - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 102, 2024 => 104 }.freeze diff --git a/app/models/form/sales/questions/discounted_ownership_type.rb b/app/models/form/sales/questions/discounted_ownership_type.rb index aed8964f3..2e8c3f2f2 100644 --- a/app/models/form/sales/questions/discounted_ownership_type.rb +++ b/app/models/form/sales/questions/discounted_ownership_type.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::DiscountedOwnershipType < ::Form::Question @type = "radio" @top_guidance_partial = guidance_partial @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/equity.rb b/app/models/form/sales/questions/equity.rb index 3a09f906e..b64b8ba0b 100644 --- a/app/models/form/sales/questions/equity.rb +++ b/app/models/form/sales/questions/equity.rb @@ -11,7 +11,7 @@ class Form::Sales::Questions::Equity < ::Form::Question @width = 5 @suffix = "%" @hint_text = "Enter the amount of initial equity held by the purchaser (for example, 25% or 50%)" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 89, 2024 => 91 }.freeze diff --git a/app/models/form/sales/questions/exchange_date.rb b/app/models/form/sales/questions/exchange_date.rb index 446c1a217..e959d805f 100644 --- a/app/models/form/sales/questions/exchange_date.rb +++ b/app/models/form/sales/questions/exchange_date.rb @@ -5,7 +5,7 @@ class Form::Sales::Questions::ExchangeDate < ::Form::Question @check_answer_label = "Exchange of contracts date" @header = "What is the exchange of contracts date?" @type = "date" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 81, 2024 => 83 }.freeze diff --git a/app/models/form/sales/questions/extra_borrowing.rb b/app/models/form/sales/questions/extra_borrowing.rb index 6ffc636ea..ed2b69b55 100644 --- a/app/models/form/sales/questions/extra_borrowing.rb +++ b/app/models/form/sales/questions/extra_borrowing.rb @@ -9,7 +9,7 @@ class Form::Sales::Questions::ExtraBorrowing < ::Form::Question @page = page @hint_text = "" @ownershipsch = ownershipsch - @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year][ownershipsch] if QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year].present? + @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.max_by { |k, _v| k }.last)[ownershipsch] end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/fromprop.rb b/app/models/form/sales/questions/fromprop.rb index 3a79cb1a8..b267679b8 100644 --- a/app/models/form/sales/questions/fromprop.rb +++ b/app/models/form/sales/questions/fromprop.rb @@ -8,7 +8,7 @@ class Form::Sales::Questions::Fromprop < ::Form::Question @hint_text = "" @page = page @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/gender_identity1.rb b/app/models/form/sales/questions/gender_identity1.rb index 8621afbb3..18f504848 100644 --- a/app/models/form/sales/questions/gender_identity1.rb +++ b/app/models/form/sales/questions/gender_identity1.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::GenderIdentity1 < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @check_answers_card_number = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/gender_identity2.rb b/app/models/form/sales/questions/gender_identity2.rb index 2319de597..88508f798 100644 --- a/app/models/form/sales/questions/gender_identity2.rb +++ b/app/models/form/sales/questions/gender_identity2.rb @@ -13,7 +13,7 @@ class Form::Sales::Questions::GenderIdentity2 < ::Form::Question }, "value" => "Prefers not to say", }] - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/grant.rb b/app/models/form/sales/questions/grant.rb index e56229625..36870ac8a 100644 --- a/app/models/form/sales/questions/grant.rb +++ b/app/models/form/sales/questions/grant.rb @@ -11,7 +11,7 @@ class Form::Sales::Questions::Grant < ::Form::Question @width = 5 @prefix = "£" @hint_text = "For all schemes except Right to Buy (RTB), Preserved Right to Buy (PRTB), Voluntary Right to Buy (VRTB) and Rent to Buy" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 101, 2024 => 103 }.freeze diff --git a/app/models/form/sales/questions/handover_date.rb b/app/models/form/sales/questions/handover_date.rb index b8f46a91d..279dfe5f4 100644 --- a/app/models/form/sales/questions/handover_date.rb +++ b/app/models/form/sales/questions/handover_date.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::HandoverDate < ::Form::Question @header = "What is the practical completion or handover date?" @type = "date" @hint_text = "This is the date on which the building contractor hands over responsibility for the completed property to the private registered provider (PRP)" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 82, 2024 => 84 }.freeze diff --git a/app/models/form/sales/questions/household_disability.rb b/app/models/form/sales/questions/household_disability.rb index 3e55c25b6..b8eb4dcf9 100644 --- a/app/models/form/sales/questions/household_disability.rb +++ b/app/models/form/sales/questions/household_disability.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::HouseholdDisability < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @hint_text = "This includes any long-term health condition that has an impact on the person's day-to-day life" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/household_wheelchair.rb b/app/models/form/sales/questions/household_wheelchair.rb index d4ebd9bc3..138b098b5 100644 --- a/app/models/form/sales/questions/household_wheelchair.rb +++ b/app/models/form/sales/questions/household_wheelchair.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::HouseholdWheelchair < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @hint_text = "This can be inside or outside the home" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/housing_benefits.rb b/app/models/form/sales/questions/housing_benefits.rb index 693f38c54..3abc36697 100644 --- a/app/models/form/sales/questions/housing_benefits.rb +++ b/app/models/form/sales/questions/housing_benefits.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::HousingBenefits < ::Form::Question @header = "#{joint_purchase ? 'Were the buyers' : 'Was the buyer'} receiving any of these housing-related benefits immediately before buying this property?" @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/joint_purchase.rb b/app/models/form/sales/questions/joint_purchase.rb index 5cdf1e862..0d64d1be6 100644 --- a/app/models/form/sales/questions/joint_purchase.rb +++ b/app/models/form/sales/questions/joint_purchase.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::JointPurchase < ::Form::Question @header = "Is this a joint purchase?" @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/la_nominations.rb b/app/models/form/sales/questions/la_nominations.rb index 67180024a..d7e276927 100644 --- a/app/models/form/sales/questions/la_nominations.rb +++ b/app/models/form/sales/questions/la_nominations.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::LaNominations < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @hint_text = "A local authority nominations agreement is a written agreement between a local authority and private registered provider (PRP) that some or all of its sales vacancies are offered to local authorities for rehousing" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/leasehold_charges.rb b/app/models/form/sales/questions/leasehold_charges.rb index 9a10e5e9b..d3d9c7df0 100644 --- a/app/models/form/sales/questions/leasehold_charges.rb +++ b/app/models/form/sales/questions/leasehold_charges.rb @@ -10,7 +10,7 @@ class Form::Sales::Questions::LeaseholdCharges < ::Form::Question @width = 5 @prefix = "£" @ownershipsch = ownershipsch - @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year][ownershipsch] if QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year].present? + @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.max_by { |k, _v| k }.last)[ownershipsch] end QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP = { diff --git a/app/models/form/sales/questions/living_before_purchase.rb b/app/models/form/sales/questions/living_before_purchase.rb index cf1d73f13..a862f164a 100644 --- a/app/models/form/sales/questions/living_before_purchase.rb +++ b/app/models/form/sales/questions/living_before_purchase.rb @@ -18,7 +18,7 @@ class Form::Sales::Questions::LivingBeforePurchase < ::Form::Question ], } @ownershipsch = ownershipsch - @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year][ownershipsch] if QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year].present? + @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.max_by { |k, _v| k }.last)[ownershipsch] end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/managing_organisation.rb b/app/models/form/sales/questions/managing_organisation.rb index 153549a1a..9ccdb9a3c 100644 --- a/app/models/form/sales/questions/managing_organisation.rb +++ b/app/models/form/sales/questions/managing_organisation.rb @@ -5,7 +5,7 @@ class Form::Sales::Questions::ManagingOrganisation < ::Form::Question @check_answer_label = "Reported by" @header = "Which organisation is reporting this sale?" @type = "select" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end def answer_options(log = nil, user = nil) diff --git a/app/models/form/sales/questions/monthly_rent.rb b/app/models/form/sales/questions/monthly_rent.rb index 4af199d84..7a4dbb67d 100644 --- a/app/models/form/sales/questions/monthly_rent.rb +++ b/app/models/form/sales/questions/monthly_rent.rb @@ -10,7 +10,7 @@ class Form::Sales::Questions::MonthlyRent < ::Form::Question @width = 5 @prefix = "£" @hint_text = "Amount paid before any charges" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 97, 2024 => 99 }.freeze diff --git a/app/models/form/sales/questions/mortgage_amount.rb b/app/models/form/sales/questions/mortgage_amount.rb index a12a87d0d..72b8e9647 100644 --- a/app/models/form/sales/questions/mortgage_amount.rb +++ b/app/models/form/sales/questions/mortgage_amount.rb @@ -11,7 +11,7 @@ class Form::Sales::Questions::MortgageAmount < ::Form::Question @prefix = "£" @hint_text = "Enter the amount of mortgage agreed with the mortgage lender. Exclude any deposits or cash payments. Numeric in pounds. Rounded to the nearest pound." @ownershipsch = ownershipsch - @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year][ownershipsch] if QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year].present? + @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.max_by { |k, _v| k }.last)[ownershipsch] end QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP = { diff --git a/app/models/form/sales/questions/mortgage_lender.rb b/app/models/form/sales/questions/mortgage_lender.rb index 970a6fece..e24f106b2 100644 --- a/app/models/form/sales/questions/mortgage_lender.rb +++ b/app/models/form/sales/questions/mortgage_lender.rb @@ -9,7 +9,7 @@ class Form::Sales::Questions::MortgageLender < ::Form::Question @page = page @bottom_guidance_partial = "mortgage_lender" @ownershipsch = ownershipsch - @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year][ownershipsch] if QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year].present? + @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.max_by { |k, _v| k }.last)[ownershipsch] end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/mortgage_length.rb b/app/models/form/sales/questions/mortgage_length.rb index d9213f229..03e522b1e 100644 --- a/app/models/form/sales/questions/mortgage_length.rb +++ b/app/models/form/sales/questions/mortgage_length.rb @@ -11,7 +11,7 @@ class Form::Sales::Questions::MortgageLength < ::Form::Question @width = 5 @hint_text = "You should round up to the nearest year. Value should not exceed 60 years." @ownershipsch = ownershipsch - @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year][ownershipsch] if QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year].present? + @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.max_by { |k, _v| k }.last)[ownershipsch] end def suffix_label(log) diff --git a/app/models/form/sales/questions/mortgageused.rb b/app/models/form/sales/questions/mortgageused.rb index 744bed358..e6299b520 100644 --- a/app/models/form/sales/questions/mortgageused.rb +++ b/app/models/form/sales/questions/mortgageused.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Mortgageused < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @ownershipsch = ownershipsch - @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year][ownershipsch] if QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year].present? + @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.max_by { |k, _v| k }.last)[ownershipsch] end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/number_joint_buyers.rb b/app/models/form/sales/questions/number_joint_buyers.rb index b64c2d21b..84d3fc440 100644 --- a/app/models/form/sales/questions/number_joint_buyers.rb +++ b/app/models/form/sales/questions/number_joint_buyers.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::NumberJointBuyers < ::Form::Question @header = "Are there more than 2 joint buyers of this property?" @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/number_of_others_in_property.rb b/app/models/form/sales/questions/number_of_others_in_property.rb index caf413728..a34da26ef 100644 --- a/app/models/form/sales/questions/number_of_others_in_property.rb +++ b/app/models/form/sales/questions/number_of_others_in_property.rb @@ -10,7 +10,7 @@ class Form::Sales::Questions::NumberOfOthersInProperty < ::Form::Question @min = 0 @max = 15 @step = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end private diff --git a/app/models/form/sales/questions/other_ownership_type.rb b/app/models/form/sales/questions/other_ownership_type.rb index 651eb0aa2..dbaa51bfa 100644 --- a/app/models/form/sales/questions/other_ownership_type.rb +++ b/app/models/form/sales/questions/other_ownership_type.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::OtherOwnershipType < ::Form::Question @header = "What type of sale is it?" @type = "text" @width = 10 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 6, 2024 => 8 }.freeze diff --git a/app/models/form/sales/questions/outright_ownership_type.rb b/app/models/form/sales/questions/outright_ownership_type.rb index 08d71dd1c..c5c1b8c05 100644 --- a/app/models/form/sales/questions/outright_ownership_type.rb +++ b/app/models/form/sales/questions/outright_ownership_type.rb @@ -10,7 +10,7 @@ class Form::Sales::Questions::OutrightOwnershipType < ::Form::Question @conditional_for = { "othtype" => [12], } - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/ownership_scheme.rb b/app/models/form/sales/questions/ownership_scheme.rb index 225126e81..61c1276ab 100644 --- a/app/models/form/sales/questions/ownership_scheme.rb +++ b/app/models/form/sales/questions/ownership_scheme.rb @@ -5,7 +5,7 @@ class Form::Sales::Questions::OwnershipScheme < ::Form::Question @check_answer_label = "Purchase made under ownership scheme" @header = "Was this purchase made through an ownership scheme?" @type = "radio" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end def answer_options diff --git a/app/models/form/sales/questions/owning_organisation_id.rb b/app/models/form/sales/questions/owning_organisation_id.rb index 63155f3ca..c293675e4 100644 --- a/app/models/form/sales/questions/owning_organisation_id.rb +++ b/app/models/form/sales/questions/owning_organisation_id.rb @@ -5,7 +5,7 @@ class Form::Sales::Questions::OwningOrganisationId < ::Form::Question @check_answer_label = "Owning organisation" @header = "Which organisation owns this log?" @type = "select" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end def answer_options(log = nil, user = nil) @@ -101,5 +101,5 @@ private "#{name} (inactive as of #{merge_date.to_fs(:govuk_date)})" end - QUESION_NUMBER_FROM_YEAR = { 2024 => 1 }.freeze + QUESION_NUMBER_FROM_YEAR = { 2023 => nil, 2024 => 1 }.freeze end diff --git a/app/models/form/sales/questions/postcode_for_full_address.rb b/app/models/form/sales/questions/postcode_for_full_address.rb index bb8b089c8..0219522aa 100644 --- a/app/models/form/sales/questions/postcode_for_full_address.rb +++ b/app/models/form/sales/questions/postcode_for_full_address.rb @@ -19,7 +19,7 @@ class Form::Sales::Questions::PostcodeForFullAddress < ::Form::Question @plain_label = true @check_answer_label = "Postcode" @disable_clearing_if_not_routed_or_dynamic_answer_options = true - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @hide_question_number_on_page = true end diff --git a/app/models/form/sales/questions/previous_bedrooms.rb b/app/models/form/sales/questions/previous_bedrooms.rb index 864417669..3c9de8c69 100644 --- a/app/models/form/sales/questions/previous_bedrooms.rb +++ b/app/models/form/sales/questions/previous_bedrooms.rb @@ -10,7 +10,7 @@ class Form::Sales::Questions::PreviousBedrooms < ::Form::Question @max = 6 @step = 1 @hint_text = "For bedsits enter 1" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 85, 2024 => 87 }.freeze diff --git a/app/models/form/sales/questions/previous_la_known.rb b/app/models/form/sales/questions/previous_la_known.rb index 4b3717457..12c127d1c 100644 --- a/app/models/form/sales/questions/previous_la_known.rb +++ b/app/models/form/sales/questions/previous_la_known.rb @@ -20,7 +20,7 @@ class Form::Sales::Questions::PreviousLaKnown < ::Form::Question @conditional_for = { "prevloc" => [1], } - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @disable_clearing_if_not_routed_or_dynamic_answer_options = true end diff --git a/app/models/form/sales/questions/previous_postcode.rb b/app/models/form/sales/questions/previous_postcode.rb index 533413eb5..c7f576d6c 100644 --- a/app/models/form/sales/questions/previous_postcode.rb +++ b/app/models/form/sales/questions/previous_postcode.rb @@ -17,7 +17,7 @@ class Form::Sales::Questions::PreviousPostcode < ::Form::Question "is_previous_la_inferred" => true, }, } - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @disable_clearing_if_not_routed_or_dynamic_answer_options = true end diff --git a/app/models/form/sales/questions/previous_postcode_known.rb b/app/models/form/sales/questions/previous_postcode_known.rb index 2f2502dc9..40a6f4453 100644 --- a/app/models/form/sales/questions/previous_postcode_known.rb +++ b/app/models/form/sales/questions/previous_postcode_known.rb @@ -20,7 +20,7 @@ class Form::Sales::Questions::PreviousPostcodeKnown < ::Form::Question }, ], } - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @disable_clearing_if_not_routed_or_dynamic_answer_options = true end diff --git a/app/models/form/sales/questions/previous_tenure.rb b/app/models/form/sales/questions/previous_tenure.rb index 4942c7d64..9477d220a 100644 --- a/app/models/form/sales/questions/previous_tenure.rb +++ b/app/models/form/sales/questions/previous_tenure.rb @@ -8,7 +8,7 @@ class Form::Sales::Questions::PreviousTenure < ::Form::Question @hint_text = "" @page = page @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/previous_tenure_buyer2.rb b/app/models/form/sales/questions/previous_tenure_buyer2.rb index 15204bfdf..1ebd99123 100644 --- a/app/models/form/sales/questions/previous_tenure_buyer2.rb +++ b/app/models/form/sales/questions/previous_tenure_buyer2.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::PreviousTenureBuyer2 < ::Form::Question @type = "radio" @hint_text = "" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/prevloc.rb b/app/models/form/sales/questions/prevloc.rb index 1611cf3b8..b2cce548a 100644 --- a/app/models/form/sales/questions/prevloc.rb +++ b/app/models/form/sales/questions/prevloc.rb @@ -11,7 +11,7 @@ class Form::Sales::Questions::Prevloc < ::Form::Question }, "value" => "Not known", }] - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @disable_clearing_if_not_routed_or_dynamic_answer_options = true end diff --git a/app/models/form/sales/questions/prevown.rb b/app/models/form/sales/questions/prevown.rb index ad0f28a67..17365d92c 100644 --- a/app/models/form/sales/questions/prevown.rb +++ b/app/models/form/sales/questions/prevown.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::Prevown < ::Form::Question @header = I18n.t("questions.prevown", count: joint_purchase ? 2 : 1) @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/prevshared.rb b/app/models/form/sales/questions/prevshared.rb index 1926e0e43..a878c5891 100644 --- a/app/models/form/sales/questions/prevshared.rb +++ b/app/models/form/sales/questions/prevshared.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Prevshared < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @hint_text = "For any buyer" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/privacy_notice.rb b/app/models/form/sales/questions/privacy_notice.rb index 3bac7bf90..02b004842 100644 --- a/app/models/form/sales/questions/privacy_notice.rb +++ b/app/models/form/sales/questions/privacy_notice.rb @@ -5,7 +5,7 @@ class Form::Sales::Questions::PrivacyNotice < ::Form::Question @check_answer_label = "#{joint_purchase ? 'Buyers have' : 'Buyer has'} seen the privacy notice?" @header = "Declaration" @type = "checkbox" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @joint_purchase = joint_purchase @top_guidance_partial = guidance end @@ -27,6 +27,6 @@ class Form::Sales::Questions::PrivacyNotice < ::Form::Question @joint_purchase ? "privacy_notice_buyer_joint_purchase" : "privacy_notice_buyer" end end - + QUESION_NUMBER_FROM_YEAR = { 2023 => 19, 2024 => 14 }.freeze end diff --git a/app/models/form/sales/questions/property_building_type.rb b/app/models/form/sales/questions/property_building_type.rb index 9def39a55..7f0a21a48 100644 --- a/app/models/form/sales/questions/property_building_type.rb +++ b/app/models/form/sales/questions/property_building_type.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::PropertyBuildingType < ::Form::Question @header = "What type of building is the property?" @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/property_local_authority.rb b/app/models/form/sales/questions/property_local_authority.rb index de5129e10..57120541a 100644 --- a/app/models/form/sales/questions/property_local_authority.rb +++ b/app/models/form/sales/questions/property_local_authority.rb @@ -5,7 +5,7 @@ class Form::Sales::Questions::PropertyLocalAuthority < ::Form::Question @check_answer_label = "Local authority" @header = "What is the property’s local authority?" @type = "select" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @disable_clearing_if_not_routed_or_dynamic_answer_options = true end diff --git a/app/models/form/sales/questions/property_local_authority_known.rb b/app/models/form/sales/questions/property_local_authority_known.rb index 3168f2cd8..385015c4b 100644 --- a/app/models/form/sales/questions/property_local_authority_known.rb +++ b/app/models/form/sales/questions/property_local_authority_known.rb @@ -14,7 +14,7 @@ class Form::Sales::Questions::PropertyLocalAuthorityKnown < ::Form::Question }, ], } - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/property_number_of_bedrooms.rb b/app/models/form/sales/questions/property_number_of_bedrooms.rb index 731d77a7e..8dd3834b6 100644 --- a/app/models/form/sales/questions/property_number_of_bedrooms.rb +++ b/app/models/form/sales/questions/property_number_of_bedrooms.rb @@ -10,7 +10,7 @@ class Form::Sales::Questions::PropertyNumberOfBedrooms < ::Form::Question @min = 1 @max = 9 @step = 1 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 11, 2024 => 15 }.freeze diff --git a/app/models/form/sales/questions/property_unit_type.rb b/app/models/form/sales/questions/property_unit_type.rb index 04925abb3..28742d434 100644 --- a/app/models/form/sales/questions/property_unit_type.rb +++ b/app/models/form/sales/questions/property_unit_type.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::PropertyUnitType < ::Form::Question @header = "What type of unit is the property?" @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/property_wheelchair_accessible.rb b/app/models/form/sales/questions/property_wheelchair_accessible.rb index 95ff0ea54..86e59bf6e 100644 --- a/app/models/form/sales/questions/property_wheelchair_accessible.rb +++ b/app/models/form/sales/questions/property_wheelchair_accessible.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::PropertyWheelchairAccessible < ::Form::Question @header = "Is the property built or adapted to wheelchair-user standards?" @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @hint_text = form.start_year_after_2024? ? "This is whether someone who uses a wheelchair is able to make full use of all of the property’s rooms and facilities, including use of both inside and outside space, and entering and exiting the property." : nil end diff --git a/app/models/form/sales/questions/purchase_price.rb b/app/models/form/sales/questions/purchase_price.rb index 858b9ec5d..c0a1e8717 100644 --- a/app/models/form/sales/questions/purchase_price.rb +++ b/app/models/form/sales/questions/purchase_price.rb @@ -11,7 +11,7 @@ class Form::Sales::Questions::PurchasePrice < ::Form::Question @prefix = "£" @hint_text = hint_text @ownership_sch = ownershipsch - @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year][ownershipsch] if QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP[form.start_date.year].present? + @question_number = QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP.max_by { |k, _v| k }.last)[ownershipsch] end QUESION_NUMBER_FROM_YEAR_AND_OWNERSHIP = { diff --git a/app/models/form/sales/questions/purchaser_code.rb b/app/models/form/sales/questions/purchaser_code.rb index 539e76f3e..efb798934 100644 --- a/app/models/form/sales/questions/purchaser_code.rb +++ b/app/models/form/sales/questions/purchaser_code.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::PurchaserCode < ::Form::Question @hint_text = "This is how you usually refer to the purchaser on your own systems." @type = "text" @width = 10 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 2, 2024 => 4 }.freeze diff --git a/app/models/form/sales/questions/resale.rb b/app/models/form/sales/questions/resale.rb index 7f1f0160a..96b715a5e 100644 --- a/app/models/form/sales/questions/resale.rb +++ b/app/models/form/sales/questions/resale.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Resale < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @hint_text = "If the social landlord has previously sold the property to another buyer and is now reselling the property, select 'yes'. If this is the first time the property has been sold, select 'no'." - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/sale_date.rb b/app/models/form/sales/questions/sale_date.rb index 0f0589625..fbd2ad2ea 100644 --- a/app/models/form/sales/questions/sale_date.rb +++ b/app/models/form/sales/questions/sale_date.rb @@ -5,7 +5,7 @@ class Form::Sales::Questions::SaleDate < ::Form::Question @check_answer_label = "Sale completion date" @header = "What is the sale completion date?" @type = "date" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 1, 2024 => 3 }.freeze diff --git a/app/models/form/sales/questions/savings.rb b/app/models/form/sales/questions/savings.rb index 19da8bec0..5be8b315f 100644 --- a/app/models/form/sales/questions/savings.rb +++ b/app/models/form/sales/questions/savings.rb @@ -9,7 +9,7 @@ class Form::Sales::Questions::Savings < ::Form::Question @prefix = "£" @step = 10 @min = 0 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 72, 2024 => 74 }.freeze diff --git a/app/models/form/sales/questions/savings_nk.rb b/app/models/form/sales/questions/savings_nk.rb index 4cb3c49a9..f06931dd9 100644 --- a/app/models/form/sales/questions/savings_nk.rb +++ b/app/models/form/sales/questions/savings_nk.rb @@ -16,7 +16,7 @@ class Form::Sales::Questions::SavingsNk < ::Form::Question }, ], } - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/shared_ownership_type.rb b/app/models/form/sales/questions/shared_ownership_type.rb index a50866dc7..cd8ee739d 100644 --- a/app/models/form/sales/questions/shared_ownership_type.rb +++ b/app/models/form/sales/questions/shared_ownership_type.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::SharedOwnershipType < ::Form::Question @top_guidance_partial = guidance_partial @type = "radio" @answer_options = answer_options - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end def hint_text diff --git a/app/models/form/sales/questions/staircase.rb b/app/models/form/sales/questions/staircase.rb index 4af40c5ab..803ddbb24 100644 --- a/app/models/form/sales/questions/staircase.rb +++ b/app/models/form/sales/questions/staircase.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::Staircase < ::Form::Question @type = "radio" @answer_options = ANSWER_OPTIONS @hint_text = "A staircasing transaction is when the household purchases more shares in their property, increasing the proportion they own and decreasing the proportion the housing association owns. Once the household purchases 100% of the shares, they own the property" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/staircase_bought.rb b/app/models/form/sales/questions/staircase_bought.rb index 5b8bbb369..5230942b2 100644 --- a/app/models/form/sales/questions/staircase_bought.rb +++ b/app/models/form/sales/questions/staircase_bought.rb @@ -10,7 +10,7 @@ class Form::Sales::Questions::StaircaseBought < ::Form::Question @max = 100 @step = 1 @suffix = "%" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 77, 2024 => 79 }.freeze diff --git a/app/models/form/sales/questions/staircase_owned.rb b/app/models/form/sales/questions/staircase_owned.rb index 226a45a74..e6608625d 100644 --- a/app/models/form/sales/questions/staircase_owned.rb +++ b/app/models/form/sales/questions/staircase_owned.rb @@ -10,7 +10,7 @@ class Form::Sales::Questions::StaircaseOwned < ::Form::Question @max = 100 @step = 1 @suffix = "%" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 78, 2024 => 80 }.freeze diff --git a/app/models/form/sales/questions/staircase_sale.rb b/app/models/form/sales/questions/staircase_sale.rb index 6a35a5f91..70543a9e8 100644 --- a/app/models/form/sales/questions/staircase_sale.rb +++ b/app/models/form/sales/questions/staircase_sale.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::StaircaseSale < ::Form::Question @header = "Is this transaction part of a back-to-back staircasing transaction to facilitate sale of the home on the open market?" @type = "radio" @answer_options = ANSWER_OPTIONS - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end ANSWER_OPTIONS = { diff --git a/app/models/form/sales/questions/town_or_city.rb b/app/models/form/sales/questions/town_or_city.rb index ade520c38..05be49ba8 100644 --- a/app/models/form/sales/questions/town_or_city.rb +++ b/app/models/form/sales/questions/town_or_city.rb @@ -7,7 +7,7 @@ class Form::Sales::Questions::TownOrCity < ::Form::Question @plain_label = true @check_answer_label = "Town or city" @disable_clearing_if_not_routed_or_dynamic_answer_options = true - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @hide_question_number_on_page = true end diff --git a/app/models/form/sales/questions/uprn.rb b/app/models/form/sales/questions/uprn.rb index 520a41813..aa633e012 100644 --- a/app/models/form/sales/questions/uprn.rb +++ b/app/models/form/sales/questions/uprn.rb @@ -6,7 +6,7 @@ class Form::Sales::Questions::Uprn < ::Form::Question @header = "What is the property's UPRN?" @type = "text" @width = 10 - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) @inferred_check_answers_value = [ { "condition" => { "uprn_known" => 0 }, diff --git a/app/models/form/sales/questions/value.rb b/app/models/form/sales/questions/value.rb index b4652562c..af34c7229 100644 --- a/app/models/form/sales/questions/value.rb +++ b/app/models/form/sales/questions/value.rb @@ -10,7 +10,7 @@ class Form::Sales::Questions::Value < ::Form::Question @width = 5 @prefix = "£" @hint_text = "Enter the full purchase price of the property before any discounts are applied. For shared ownership, enter the full purchase price paid for 100% equity (this is equal to the value of the share owned by the PRP plus the value bought by the purchaser)" - @question_number = QUESION_NUMBER_FROM_YEAR[form.start_date.year] + @question_number = QUESION_NUMBER_FROM_YEAR.fetch(form.start_date.year, QUESION_NUMBER_FROM_YEAR.max_by { |k, _v| k }.last) end QUESION_NUMBER_FROM_YEAR = { 2023 => 88, 2024 => 90 }.freeze