From bd3a593d4a8be0540a9aba04c05a35465722c416 Mon Sep 17 00:00:00 2001
From: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
Date: Tue, 7 Nov 2023 10:03:15 +0000
Subject: [PATCH] feat: test error added correctly and fix typo

---
 lib/tasks/import_address_from_csv.rake        |  2 +-
 .../tasks/correct_address_from_csv_spec.rb    | 32 +++++++++++++++++++
 2 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/lib/tasks/import_address_from_csv.rake b/lib/tasks/import_address_from_csv.rake
index 400b8ccde..c81cc2162 100644
--- a/lib/tasks/import_address_from_csv.rake
+++ b/lib/tasks/import_address_from_csv.rake
@@ -122,7 +122,7 @@ namespace :data_import do
       if sales_log.save
         Rails.logger.info("Updated sales log #{sales_log_id}, with address: #{[sales_log.address_line1, sales_log.address_line2, sales_log.town_or_city, sales_log.county, sales_log.postcode_full].join(', ')}")
       else
-        Rails.logger.error("Validation failed for sales log with ID #{sales_log_id.id}: #{lettings_log.errors.full_messages.join(', ')}}")
+        Rails.logger.error("Validation failed for sales log with ID #{sales_log.id}: #{sales_log.errors.full_messages.join(', ')}}")
       end
     end
   end
diff --git a/spec/lib/tasks/correct_address_from_csv_spec.rb b/spec/lib/tasks/correct_address_from_csv_spec.rb
index 58bc2e080..fca5b79fb 100644
--- a/spec/lib/tasks/correct_address_from_csv_spec.rb
+++ b/spec/lib/tasks/correct_address_from_csv_spec.rb
@@ -184,6 +184,14 @@ RSpec.describe "data_import" do
         it "raises an error when no path is given" do
           expect { task.invoke(nil) }.to raise_error(RuntimeError, "Usage: rake data_import:import_lettings_addresses_from_csv['csv_file_name']")
         end
+
+        it "logs an error if a validation fails" do
+          lettings_log.ppcodenk = 0
+          lettings_log.ppostcode_full = "invalid_format"
+          lettings_log.save!(validate: false)
+          expect(Rails.logger).to receive(:error).with(/Validation failed for lettings log with ID #{lettings_log.id}: Ppostcode full/)
+          task.invoke(addresses_csv_path)
+        end
       end
 
       context "when the file does not contain issue type column" do
@@ -272,6 +280,14 @@ RSpec.describe "data_import" do
         it "raises an error when no path is given" do
           expect { task.invoke(nil) }.to raise_error(RuntimeError, "Usage: rake data_import:import_lettings_addresses_from_csv['csv_file_name']")
         end
+
+        it "logs an error if a validation fails" do
+          lettings_log.ppcodenk = 0
+          lettings_log.ppostcode_full = "invalid_format"
+          lettings_log.save!(validate: false)
+          expect(Rails.logger).to receive(:error).with(/Validation failed for lettings log with ID #{lettings_log.id}: Ppostcode full/)
+          task.invoke(addresses_csv_path)
+        end
       end
     end
   end
@@ -405,6 +421,14 @@ RSpec.describe "data_import" do
         it "raises an error when no path is given" do
           expect { task.invoke(nil) }.to raise_error(RuntimeError, "Usage: rake data_import:import_sales_addresses_from_csv['csv_file_name']")
         end
+
+        it "logs an error if a validation fails" do
+          sales_log.ppcodenk = 0
+          sales_log.ppostcode_full = "invalid_format"
+          sales_log.save!(validate: false)
+          expect(Rails.logger).to receive(:error).with(/Validation failed for sales log with ID #{sales_log.id}: Ppostcode full/)
+          task.invoke(addresses_csv_path)
+        end
       end
 
       context "when the file does not contain issue type column" do
@@ -493,6 +517,14 @@ RSpec.describe "data_import" do
         it "raises an error when no path is given" do
           expect { task.invoke(nil) }.to raise_error(RuntimeError, "Usage: rake data_import:import_sales_addresses_from_csv['csv_file_name']")
         end
+
+        it "logs an error if a validation fails" do
+          sales_log.ppcodenk = 0
+          sales_log.ppostcode_full = "invalid_format"
+          sales_log.save!(validate: false)
+          expect(Rails.logger).to receive(:error).with(/Validation failed for sales log with ID #{sales_log.id}: Ppostcode full/)
+          task.invoke(addresses_csv_path)
+        end
       end
     end
   end