Refactor ifs

2 years ago · bccf49777c
2 changed files with 6 additions and 6 deletions
--- a/app/models/form/sales/questions/gender_identity2.rb
+++ b/app/models/form/sales/questions/gender_identity2.rb
@ -24,8 +24,8 @@ class Form::Sales::Questions::GenderIdentity2 < ::Form::Question
  }.freeze

  def hint_text
-    if form.start_year_after_2024?
-      "This should be however they personally choose to identify from the options below. This may or may not be the same as their biological sex or the sex they were assigned at birth."
-    end
+    return unless form.start_year_after_2024?
+
+    "This should be however they personally choose to identify from the options below. This may or may not be the same as their biological sex or the sex they were assigned at birth."
  end
 end
--- a/app/models/form/sales/questions/person_gender_identity.rb
+++ b/app/models/form/sales/questions/person_gender_identity.rb
@ -23,8 +23,8 @@ class Form::Sales::Questions::PersonGenderIdentity < ::Form::Question
  }.freeze

  def hint_text
-    if form.start_year_after_2024?
-      "This should be however they personally choose to identify from the options below. This may or may not be the same as their biological sex or the sex they were assigned at birth."
-    end
+    return unless form.start_year_after_2024?
+
+    "This should be however they personally choose to identify from the options below. This may or may not be the same as their biological sex or the sex they were assigned at birth."
  end
 end