From bbf766393b4d3fb5c766ab614f7d7b073b90e24d Mon Sep 17 00:00:00 2001 From: Arthur Campbell Date: Tue, 4 Apr 2023 08:35:28 +0100 Subject: [PATCH] remove bulk upload tests for adding validations to unpermitted values to radio questions, these are now being cleared before validation --- .../lettings/year2022/row_parser_spec.rb | 18 ------------------ .../lettings/year2023/row_parser_spec.rb | 8 -------- 2 files changed, 26 deletions(-) diff --git a/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb index a39f0969c..fd60c4a7b 100644 --- a/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb @@ -852,16 +852,6 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do end end - describe "#field_134" do - context "when an unpermitted value" do - let(:attributes) { { bulk_upload:, field_134: "3" } } - - it "has errors on the field" do - expect(parser.errors[:field_134]).to be_present - end - end - end - describe "#field_103" do context "when null" do let(:attributes) { setup_section_params.merge({ field_103: nil }) } @@ -874,14 +864,6 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do expect(parser.errors[:field_103]).to eql(["You must answer type of building"]) end end - - context "when unpermitted values" do - let(:attributes) { setup_section_params.merge({ field_103: "4" }) } - - it "returns an error" do - expect(parser.errors[:field_103]).to be_present - end - end end end diff --git a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb index 37d8e24a5..eef3d4ab4 100644 --- a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb @@ -842,14 +842,6 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do expect(parser.errors[:field_30]).to eql(["You must answer type of building"]) end end - - context "when unpermitted values" do - let(:attributes) { setup_section_params.merge({ field_30: "4" }) } - - it "returns an error" do - expect(parser.errors[:field_30]).to be_present - end - end end describe "#field_52" do # age2