From b8cf24c5ba64db4f6906313b1f56018c4f2cc6a1 Mon Sep 17 00:00:00 2001 From: Kat Date: Thu, 30 Mar 2023 15:16:18 +0100 Subject: [PATCH] Remove routed to from the la questions --- .../pages/property_local_authority.rb | 8 ---- .../sales/pages/property_local_authority.rb | 6 --- .../pages/property_local_authority_spec.rb | 39 ------------------- .../pages/property_local_authority_spec.rb | 29 -------------- 4 files changed, 82 deletions(-) diff --git a/app/models/form/lettings/pages/property_local_authority.rb b/app/models/form/lettings/pages/property_local_authority.rb index 7692fd376..2c64e3628 100644 --- a/app/models/form/lettings/pages/property_local_authority.rb +++ b/app/models/form/lettings/pages/property_local_authority.rb @@ -8,12 +8,4 @@ class Form::Lettings::Pages::PropertyLocalAuthority < ::Form::Page def questions @questions ||= [Form::Lettings::Questions::La.new(nil, nil, self)] end - - def routed_to?(log, _current_user = nil) - return false if log.uprn_known.nil? && form.start_date.year >= 2023 - return false if log.is_la_inferred? - return false if log.is_supported_housing? - - true - end end diff --git a/app/models/form/sales/pages/property_local_authority.rb b/app/models/form/sales/pages/property_local_authority.rb index 66c4b965b..81d4382d9 100644 --- a/app/models/form/sales/pages/property_local_authority.rb +++ b/app/models/form/sales/pages/property_local_authority.rb @@ -14,12 +14,6 @@ class Form::Sales::Pages::PropertyLocalAuthority < ::Form::Page ].compact end - def routed_to?(log, _current_user = nil) - return false if log.uprn_known.nil? && form.start_date.year >= 2023 - - true - end - def la_known_question if form.start_date.year < 2023 Form::Sales::Questions::PropertyLocalAuthorityKnown.new(nil, nil, self) diff --git a/spec/models/form/lettings/pages/property_local_authority_spec.rb b/spec/models/form/lettings/pages/property_local_authority_spec.rb index 5b5ee95eb..c09d01dc7 100644 --- a/spec/models/form/lettings/pages/property_local_authority_spec.rb +++ b/spec/models/form/lettings/pages/property_local_authority_spec.rb @@ -35,43 +35,4 @@ RSpec.describe Form::Lettings::Pages::PropertyLocalAuthority, type: :model do it "has the correct depends_on" do expect(page.depends_on).to match([{ "is_general_needs?" => true, "is_la_inferred" => false }]) end - - describe "has correct routed_to?" do - context "when start_date < 2023" do - let(:log) { create(:lettings_log, uprn_known: 1) } - let(:start_date) { Time.utc(2022, 2, 8) } - - it "returns false" do - expect(page.routed_to?(log)).to eq(true) - end - end - - context "when start_date >= 2023" do - let(:log) { create(:lettings_log, uprn_known: 1) } - let(:start_date) { Time.utc(2023, 2, 8) } - - it "returns true" do - expect(page.routed_to?(log)).to eq(true) - end - end - - context "when start_date < 2023 and uprn_known: nil" do - let(:log) { create(:lettings_log, uprn_known: nil) } - let(:start_date) { Time.utc(2023, 2, 8) } - - it "returns true" do - expect(page.routed_to?(log)).to eq(false) - end - - context "when is_la_inferred: true" do - before do - allow(log).to receive(:is_la_inferred?).and_return(true) - end - - it "returns true" do - expect(page.routed_to?(log)).to eq(false) - end - end - end - end end diff --git a/spec/models/form/sales/pages/property_local_authority_spec.rb b/spec/models/form/sales/pages/property_local_authority_spec.rb index 8ac3aaa03..55234ad52 100644 --- a/spec/models/form/sales/pages/property_local_authority_spec.rb +++ b/spec/models/form/sales/pages/property_local_authority_spec.rb @@ -56,33 +56,4 @@ RSpec.describe Form::Sales::Pages::PropertyLocalAuthority, type: :model do "is_la_inferred" => false, }]) end - - describe "has correct routed_to?" do - context "when start_date < 2023" do - let(:log) { create(:sales_log, uprn_known: 1) } - let(:start_date) { Time.utc(2022, 2, 8) } - - it "returns false" do - expect(page.routed_to?(log)).to eq(true) - end - end - - context "when start_date >= 2023" do - let(:log) { create(:sales_log, uprn_known: 1) } - let(:start_date) { Time.utc(2023, 2, 8) } - - it "returns true" do - expect(page.routed_to?(log)).to eq(true) - end - end - - context "when start_date < 2023 and uprn_known: nil" do - let(:log) { create(:sales_log, uprn_known: nil) } - let(:start_date) { Time.utc(2023, 2, 8) } - - it "returns true" do - expect(page.routed_to?(log)).to eq(false) - end - end - end end