From b3620073b98d71e695b2910b6af773247e06057a Mon Sep 17 00:00:00 2001
From: Phil Lee <asmega@users.noreply.github.com>
Date: Fri, 21 Apr 2023 12:48:39 +0100
Subject: [PATCH] Use review env for review apps (#1579)

# Context

- We are mixing environments for review apps at the moment with staging
- As a result of this change bulk upload now works will CSV download

# Changes

- Created a new environment `dev` to store dev specific variables independent of staging
- Review apps now use this particular set of variables rather than the staging set
---
 .github/workflows/review_pipeline.yml          | 8 ++++----
 .github/workflows/review_teardown_pipeline.yml | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/review_pipeline.yml b/.github/workflows/review_pipeline.yml
index 440dddf5c..d5921e049 100644
--- a/.github/workflows/review_pipeline.yml
+++ b/.github/workflows/review_pipeline.yml
@@ -18,7 +18,7 @@ jobs:
   postgres:
     name: Provision postgres
     runs-on: ubuntu-latest
-    environment: staging
+    environment: review
 
     steps:
       - name: Install Cloud Foundry CLI
@@ -44,7 +44,7 @@ jobs:
   redis:
     name: Provision redis
     runs-on: ubuntu-latest
-    environment: staging
+    environment: review
 
     steps:
       - name: Install Cloud Foundry CLI
@@ -70,7 +70,7 @@ jobs:
   deploy:
     name: Deploy review app
     runs-on: ubuntu-latest
-    environment: staging
+    environment: review
     needs: [postgres, redis]
     permissions:
       issues: write
@@ -125,7 +125,7 @@ jobs:
           cf set-env $APP_NAME IMPORT_PAAS_INSTANCE $IMPORT_PAAS_INSTANCE
           cf set-env $APP_NAME EXPORT_PAAS_INSTANCE "dluhc-core-review-export-bucket"
           cf set-env $APP_NAME S3_CONFIG $S3_CONFIG
-          cf set-env $APP_NAME CSV_DOWNLOAD_PAAS_INSTANCE "dluhc-core-staging-csv-bucket"
+          cf set-env $APP_NAME CSV_DOWNLOAD_PAAS_INSTANCE "dluhc-core-review-csv-bucket"
           cf set-env $APP_NAME SENTRY_DSN $SENTRY_DSN
           cf set-env $APP_NAME APP_HOST "https://dluhc-core-review-${{ github.event.pull_request.number }}.london.cloudapps.digital"
 
diff --git a/.github/workflows/review_teardown_pipeline.yml b/.github/workflows/review_teardown_pipeline.yml
index 08032596d..3962243c4 100644
--- a/.github/workflows/review_teardown_pipeline.yml
+++ b/.github/workflows/review_teardown_pipeline.yml
@@ -14,7 +14,7 @@ jobs:
   app:
     name: Teardown app
     runs-on: ubuntu-latest
-    environment: staging
+    environment: review
 
     steps:
       - name: Install Cloud Foundry CLI
@@ -40,7 +40,7 @@ jobs:
   postgres:
     name: Teardown postgres
     runs-on: ubuntu-latest
-    environment: staging
+    environment: review
     needs: [app]
 
     steps:
@@ -67,7 +67,7 @@ jobs:
   redis:
     name: Teardown redis
     runs-on: ubuntu-latest
-    environment: staging
+    environment: review
     needs: [app]
 
     steps: