From b357bcec9783fb3c7cf3522f3a788ca1e97ac22f Mon Sep 17 00:00:00 2001 From: Samuel Young Date: Wed, 21 Jan 2026 09:26:20 +0000 Subject: [PATCH] fixup! CLDC-4145: Add a depends_on to ensure partner is hidden remove unnecessary depends_on make test ranges clearer --- app/models/form/lettings/pages/person_lead_partner.rb | 1 - .../form/lettings/pages/person_lead_partner_spec.rb | 8 ++------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/app/models/form/lettings/pages/person_lead_partner.rb b/app/models/form/lettings/pages/person_lead_partner.rb index 6f5e7e5f2..36f2e9b11 100644 --- a/app/models/form/lettings/pages/person_lead_partner.rb +++ b/app/models/form/lettings/pages/person_lead_partner.rb @@ -2,7 +2,6 @@ class Form::Lettings::Pages::PersonLeadPartner < ::Form::Page def initialize(id, hsh, subsection, person_index:) super(id, hsh, subsection) @id = "person_#{person_index}_lead_partner" - @depends_on = [{ "details_known_#{person_index}" => 0 }] @person_index = person_index end diff --git a/spec/models/form/lettings/pages/person_lead_partner_spec.rb b/spec/models/form/lettings/pages/person_lead_partner_spec.rb index 588911f6a..55ee97e1d 100644 --- a/spec/models/form/lettings/pages/person_lead_partner_spec.rb +++ b/spec/models/form/lettings/pages/person_lead_partner_spec.rb @@ -8,10 +8,6 @@ RSpec.describe Form::Lettings::Pages::PersonLeadPartner, type: :model do let(:subsection) { instance_double(Form::Subsection, form:) } let(:person_index) { 2 } - before do - allow(form).to receive(:start_year_2026_or_later?).and_return(false) - end - it "has correct subsection" do expect(page.subsection).to eq(subsection) end @@ -29,7 +25,7 @@ RSpec.describe Form::Lettings::Pages::PersonLeadPartner, type: :model do expect(page.id).to eq("person_2_lead_partner") end - context "with start year >= 2025", metadata: { year: 25 } do + context "with start year < 2026", metadata: { year: 25 } do before do allow(form).to receive(:start_year_2026_or_later?).and_return(false) end @@ -74,7 +70,7 @@ RSpec.describe Form::Lettings::Pages::PersonLeadPartner, type: :model do expect(page.id).to eq("person_3_lead_partner") end - context "with start year >= 2025", metadata: { year: 25 } do + context "with start year < 2026", metadata: { year: 25 } do before do allow(form).to receive(:start_year_2026_or_later?).and_return(false) end