remove changes made for testing on review app

.github/workflows/review_pipeline.yml

@@ -123,7 +123,7 @@ jobs:
           cf set-env $APP_NAME IMPORT_PAAS_INSTANCE $IMPORT_PAAS_INSTANCE
           cf set-env $APP_NAME EXPORT_PAAS_INSTANCE "dluhc-core-review-export-bucket"
           cf set-env $APP_NAME S3_CONFIG $S3_CONFIG
-          cf set-env $APP_NAME CSV_DOWNLOAD_PAAS_INSTANCE "dluhc-core-staging-csv-bucket"
+          cf set-env $APP_NAME CSV_DOWNLOAD_PAAS_INSTANCE "dluhc-core-review-csv-bucket"
           cf set-env $APP_NAME SENTRY_DSN $SENTRY_DSN
           cf set-env $APP_NAME APP_HOST "https://dluhc-core-review-${{ github.event.pull_request.number }}.london.cloudapps.digital"
 

db/seeds.rb

@@ -177,16 +177,6 @@ unless Rails.env.test?
       user.confirmed_at = Time.zone.now
     end
 
-    User.find_or_create_by!(
-      name: "Arthur",
-      email: "arthur.campbell@softwire.com",
-      organisation: org,
-      role: "support",
-    ) do |user|
-      user.password = "password"
-      user.confirmed_at = Time.zone.now
-    end
-
     pp "Seeded 3 dummy users"
   end
 

spec/db/seeds_spec.rb

@@ -24,7 +24,7 @@ RSpec.describe "seeding process", type: task do
   it "sets up correct data" do
     expect {
       Rails.application.load_seed
-    }.to change(User, :count).by(8)
+    }.to change(User, :count).by(7)
      .and change(Organisation, :count).by(8)
      .and change(OrganisationRelationship, :count).by(4)
      .and change(Scheme, :count).by(3)