From aac2c9c0fd19f7243d5bffcdfee72da4e49a9182 Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Wed, 4 Jan 2023 14:37:12 +0000 Subject: [PATCH] feat: respond to PR comments --- app/models/form/sales/pages/privacy_notice.rb | 2 +- app/models/form/sales/questions/buyer_interview.rb | 2 +- spec/models/form/sales/pages/privacy_notice_spec.rb | 2 +- spec/models/form/sales/questions/buyer_interview_spec.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/models/form/sales/pages/privacy_notice.rb b/app/models/form/sales/pages/privacy_notice.rb index a7e8ca219..7c1056ccb 100644 --- a/app/models/form/sales/pages/privacy_notice.rb +++ b/app/models/form/sales/pages/privacy_notice.rb @@ -6,7 +6,7 @@ class Form::Sales::Pages::PrivacyNotice < ::Form::Page @description = "" @subsection = subsection @depends_on = [{ - "noint" => 1, + "noint" => 2, }] end diff --git a/app/models/form/sales/questions/buyer_interview.rb b/app/models/form/sales/questions/buyer_interview.rb index d270d9d33..1b354b1d5 100644 --- a/app/models/form/sales/questions/buyer_interview.rb +++ b/app/models/form/sales/questions/buyer_interview.rb @@ -11,7 +11,7 @@ class Form::Sales::Questions::BuyerInterview < ::Form::Question end ANSWER_OPTIONS = { - "1" => { "value" => "No" }, "2" => { "value" => "Yes" }, + "1" => { "value" => "No" }, }.freeze end diff --git a/spec/models/form/sales/pages/privacy_notice_spec.rb b/spec/models/form/sales/pages/privacy_notice_spec.rb index 9c957b0b5..8a8de04f1 100644 --- a/spec/models/form/sales/pages/privacy_notice_spec.rb +++ b/spec/models/form/sales/pages/privacy_notice_spec.rb @@ -28,6 +28,6 @@ RSpec.describe Form::Sales::Pages::PrivacyNotice, type: :model do end it "has correct depends_on" do - expect(page.depends_on).to eq([{ "noint" => 1 }]) + expect(page.depends_on).to eq([{ "noint" => 2 }]) end end diff --git a/spec/models/form/sales/questions/buyer_interview_spec.rb b/spec/models/form/sales/questions/buyer_interview_spec.rb index 69c45ee4e..433d46f8b 100644 --- a/spec/models/form/sales/questions/buyer_interview_spec.rb +++ b/spec/models/form/sales/questions/buyer_interview_spec.rb @@ -37,8 +37,8 @@ RSpec.describe Form::Sales::Questions::BuyerInterview, type: :model do it "has the correct answer_options" do expect(question.answer_options).to eq({ - "1" => { "value" => "No" }, "2" => { "value" => "Yes" }, + "1" => { "value" => "No" }, }) end end