Reverse year check mathod

app/services/bulk_upload/lettings/validator.rb

@@ -162,7 +162,7 @@ private
   def validate_correct_template
     return if halt_validations?
 
-    errors.add(:base, :wrong_template) unless csv_parser.correct_template_for_year?
+    errors.add(:base, :wrong_template) if csv_parser.wrong_template_for_year?
   end
 
   def halt_validations!

app/services/bulk_upload/lettings/year2022/csv_parser.rb

@@ -61,8 +61,8 @@ class BulkUpload::Lettings::Year2022::CsvParser
     max_columns_count > MAX_COLUMNS
   end
 
-  def correct_template_for_year?
-    true
+  def wrong_template_for_year?
+    false
   end
 
 private

app/services/bulk_upload/lettings/year2023/csv_parser.rb

@@ -64,10 +64,10 @@ class BulkUpload::Lettings::Year2023::CsvParser
     max_columns_count > MAX_COLUMNS
   end
 
-  def correct_template_for_year?
-    collection_start_year_for_date(first_record_start_date) == FORM_YEAR
+  def wrong_template_for_year?
+    collection_start_year_for_date(first_record_start_date) != FORM_YEAR
   rescue Date::Error
-    true
+    false
   end
 
 private

app/services/bulk_upload/sales/validator.rb

@@ -137,7 +137,7 @@ private
   def validate_correct_template
     return if halt_validations?
 
-    errors.add(:base, :wrong_template) unless csv_parser.correct_template_for_year?
+    errors.add(:base, :wrong_template) if csv_parser.wrong_template_for_year?
   end
 
   def halt_validations!

app/services/bulk_upload/sales/year2022/csv_parser.rb

@@ -43,8 +43,8 @@ class BulkUpload::Sales::Year2022::CsvParser
     cols[headers.find_index(field) + col_offset]
   end
 
-  def correct_template_for_year?
-    true
+  def wrong_template_for_year?
+    false
   end
 
 private

app/services/bulk_upload/sales/year2023/csv_parser.rb

@@ -49,10 +49,10 @@ class BulkUpload::Sales::Year2023::CsvParser
     cols[field_numbers.find_index(field) + col_offset]
   end
 
-  def correct_template_for_year?
-    collection_start_year_for_date(first_record_start_date) == FORM_YEAR
+  def wrong_template_for_year?
+    collection_start_year_for_date(first_record_start_date) != FORM_YEAR
   rescue Date::Error
-    true
+    false
   end
 
 private